From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45165C3DA61 for ; Mon, 29 Jul 2024 16:16:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D12666B0092; Mon, 29 Jul 2024 12:16:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC2336B0093; Mon, 29 Jul 2024 12:16:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB1676B0095; Mon, 29 Jul 2024 12:16:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9BCF06B0092 for ; Mon, 29 Jul 2024 12:16:08 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 45DD6404B8 for ; Mon, 29 Jul 2024 16:16:08 +0000 (UTC) X-FDA: 82393292016.19.8959EED Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 3160B40028 for ; Mon, 29 Jul 2024 16:16:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=31hkYsyV; spf=pass (imf17.hostedemail.com: domain of jannh@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722269712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d18Gy67ikbYuUZdaoOJUpFbMEluKyBKjTm4b3S21oFY=; b=osBdu9qolOGK6RgDJbhMW3V+UYVK7QujFyMrKbUuJIWOPzqfWg3HMuefLFvR90lzSoljUI beByBWrmoDzX/GY94qNGOd4tEWhQ7HyeEbk3ey0pdK7ewSWy5eC2SSWVVIultqeyLOEwUn 4XNhBkVWRHeAT38IQWN5PrdgcrfQQXw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722269712; a=rsa-sha256; cv=none; b=GUjvlavyBlmmIHrsDBZFhKCq/0Z7zecH51wPetzqErVhwJbn+6nSOnpB8iC1kcXxcabgR7 mnfPb99H96edYPBWMpgU0q7V1h2Fb8aDFAImdGq9XmxlRcvmVGo7RwjF003qsBnDZnmnrR B455Ud5bWe1EEzMX9GsGT5V64ggGqhw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=31hkYsyV; spf=pass (imf17.hostedemail.com: domain of jannh@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5a28b61b880so15559a12.1 for ; Mon, 29 Jul 2024 09:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722269765; x=1722874565; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d18Gy67ikbYuUZdaoOJUpFbMEluKyBKjTm4b3S21oFY=; b=31hkYsyVaIWkEB58zFRqWuIBL1LFG9e4Ilqa6MwzpXH35JRWK5spab+IbfOaijNdc2 U9V8wqHT+g65p7OFqP5NVOzzHhMoPDk9Ck/bZKkJlyN2F9G3iOzJC2V2fxVXGgELD8cv q9L6y6UQNdm63HyyYwM2GRk82m23Oq743YPqFJyW7lNetYhPf2buxXYEuw4TfHWhA3Dd C7AOcSm5BdNiRMx5JMTVEplLTNDBt9E2f+XnoT4Be+JdXfvlLl+voKBI+TMTYYmq6zRH VjWwXSCUdzXj+qFX+s5oGJPHMfStIPfDaslddrUX+X7DhN8N+PBzosvekesbuLu0+XwS irKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722269765; x=1722874565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d18Gy67ikbYuUZdaoOJUpFbMEluKyBKjTm4b3S21oFY=; b=RhY630bNOuGrtt3tspaPT2IQblVRwipkwT+cVeWkP044S203AJfbijpSf6rDn4SQK4 JF3XduJnRRp86rUeRj0QYy6NvxERujgcc5i9mttwrMYYOQdeUrbQfNvQkqB1chZf/iFR nJ8ge86FTFsGUy/KAu6wAP5adQZEDeD9xTmKQjZsp4mT1hRrQ62yOHWlJOdIKLuOeCgk v+eeHc1QnS4TwP/SVk49YhtD68aTFBvKgpJb41mgjpiNI3X+WjTu1yB696F/MjTipLkY QROZIEU7hr6AoG+KUWR96Z4fNpU3FYTlwHeb3EvPmdLmdLSXOaFjKV5nhD3qSQHSo4FU uwrg== X-Forwarded-Encrypted: i=1; AJvYcCU0FJGsV+XuZATvlimUpSpyocwMOcVDyqPht/lZ+ahFEv+1W8te7K5skkFZ3YLSD1wt/VQSqil8C2JHAArD9k9lZfc= X-Gm-Message-State: AOJu0Yxo/wO4rxuEFxAJ6HCMAo3EPBMBha7lBnpBlZ06cA9BkpO8c5q6 IZA8jXxHaWK8NIIcfZk6qIqpNzXZk9WgjTs2Z5uVO6QeKIJFz3g1meAPMVUADakIY4/yCAfzK7E JHLGoBwyX4boBglmX986qtqvhiCSPOnlKga7k X-Google-Smtp-Source: AGHT+IFq7wwFm0yDbIXrhXFmEY2q6vGwMcUWFfTzQ0yzkf4W85Zpi28KqinyomoROUU4QxcEIMksYCFXQcQW1eegr9A= X-Received: by 2002:a05:6402:430c:b0:57c:b712:47b5 with SMTP id 4fb4d7f45d1cf-5b40cede5c1mr22853a12.4.1722269764183; Mon, 29 Jul 2024 09:16:04 -0700 (PDT) MIME-Version: 1.0 References: <20240724225210.545423-1-andrii@kernel.org> <20240724225210.545423-8-andrii@kernel.org> In-Reply-To: <20240724225210.545423-8-andrii@kernel.org> From: Jann Horn Date: Mon, 29 Jul 2024 18:15:28 +0200 Message-ID: Subject: Re: [PATCH v2 bpf-next 07/10] lib/buildid: harden build ID parsing logic some more To: Andrii Nakryiko Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, adobriyan@gmail.com, shakeel.butt@linux.dev, hannes@cmpxchg.org, ak@linux.intel.com, osandov@osandov.com, song@kernel.org, Jiri Olsa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: y84gim8w69eosym5bzip4ucxxq6y1iz4 X-Rspamd-Queue-Id: 3160B40028 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722269765-17370 X-HE-Meta: U2FsdGVkX18GqAH43BMLDf4u/oEK0NDujzt+BCzhw/iisnX0OpqUs+BsvdUSOeAlxkyAAMvz+PdH+6EUS84i7MiNBdHrYKk89mWpODGyMKpodFd48dEIL/gB3rlfqJEsLtXLEq5H7enDYY2E5KG+Sc/zUHPMQtrvP8KCP9CzPkyJrEPcvnE87TQuP1dWpFeLaxkdz7/wLAs98/NlsB4jj0GbhpIIsF2kGyVqPChXFJJl8y++6fuurmgdth4B8sK/TeiNyg89MuYhlZa6XoZy8kIrAWaEw0SRtxZb2Ip54PdajupnqJ0mW/xSYIMD77YBBB/rOVZEfvRkZKHgViSFvKDHWQuGod6oRyvu9I5gpM3Ox6tbc+EqqCJEkzrh6Wil+7DzhhFaxS2qUE9yaSl9cCXWqQ+ppgfV3oEQ1Xmc+gXqaRBxmrWtKGqudYtsaUkQzx2uyI0VqgRe8M2VsklS4fbbSVAXAjoemUv5ljKwWEx/nqv/+iDPA4TB+W7ewOfw97Qohp1IeNu2/u3eT0QQULll38Q/0moGkAIEpClMisQsn8Y4Grg/yspsaFWftgLsnPReUqqItU4oeze2mDI+OKNl8UUzWJaxBANwqNAXgmveZ9cKWJcS5fyYnEfVIfwGSF+xEJw2E2m9GfhKBkm8JKhhWkITQCOiI4wPnWPRFoRd37XpPazu7e0HAaboxT0sPwRbeYc0VaqfOiT0h2yWYITM/+VyVw1rw3m7gy/AhCJvxbuv8KMjkhHMrM0guMJhE/hRCIQZZOR4kC0QBWLqs9XiQUgwCwFNEtsKgB089dRTVstj/tFTN2qXzEXiIxVRMPWhMM1oKG5rPtrbHuMBiy2IPqUAD6GmQhlhYUkP8zb4+VoSboLOHx0d0IAUqaQTOc3BnmbUNZxaDCHJ3wVUyaJ/DHT3Nhj6KevoY1O3BrQyiGF/9VuY9lX9miYU4rdREwRV6r11H/wJfkxWXFd kc3gndrz 0UiJh2Oxr17PhG1KO6l+/6dwz+E9+i/6THPexnoa/kF7Qo6/ywykik4o2iPQjau/kbVg7ZgEMPoddpccOjOXsQ/iSmKnx6H4HzJlJTNQl9YYR4z1aH0CviQsADWE7xgKVdUeIU1zF/LQdIB1TCx8JVMpl7pUDAf2KxNQVpJx2r6zRqO5W5Fw0dxHIM0RTzMYvromJVXAoJJu5oFin7wkUMsDhsjjW6NZEY+Cdd7FKlfLf0Xmlybxhb2e4GMz6pBpsVyl2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 25, 2024 at 12:52=E2=80=AFAM Andrii Nakryiko wrote: > Harden build ID parsing logic some more, adding explicit READ_ONCE() > when fetching values that we then use to check correctness and various > note iteration invariants. > > Suggested-by: Andi Kleen > Signed-off-by: Andrii Nakryiko If I understand correctly, build ID parsing is already exposed to untrusted code since commit 88a16a130933 ("perf: Add build id data in mmap2 event"), which first landed in v5.12, right? Can you put fixes for parsing build IDs from untrusted memory at the start of your series with stable backport markers, so that we can fix this on existing systems? Or should this be fixed on existing stable trees with a separate stable-only fix?