From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F4CC02183 for ; Mon, 13 Jan 2025 15:50:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B5DF6B0099; Mon, 13 Jan 2025 10:50:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 665466B009A; Mon, 13 Jan 2025 10:50:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506B26B009B; Mon, 13 Jan 2025 10:50:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 334E76B0099 for ; Mon, 13 Jan 2025 10:50:52 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A4E99AEB20 for ; Mon, 13 Jan 2025 15:50:51 +0000 (UTC) X-FDA: 83002866702.12.4BB9DBC Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf02.hostedemail.com (Postfix) with ESMTP id 5637780009 for ; Mon, 13 Jan 2025 15:50:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=li41Oa8u; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736783449; a=rsa-sha256; cv=none; b=DoNBHu4R/QafpTwPqblzmTvGo2IcS43VejYf4MVRSUsmTranlKwNdL56TvsIO5mJn/qypq IKEvJ2B9EMMIHeX8KDaMMtU3A19byD4PmmGbsmV+7/ldQpfqqIZbVxaHJCOgfvdXEz+Wen 0FDc58DnRkn+yLw2jAau3I/PuOOfJAI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=li41Oa8u; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736783449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sdzbHJenGqn4P67PfzTu0/El8zYlgmiqEyHkspIEBR4=; b=ufegWvUWcGi4iAae8Ye2futvv9tOAlG4cGIAqpmOiqHwbjk8rX2KZFXDXZhoxi/XwgIvv+ 29uLH1aRLkoDJmbMvo1iIScNcpbZkbnQow5fEGUbXVlY7kP4UW6M1Nga7RU3Rf7gLNBLAo iGBL/KFsrCsPb0NCdzhJg12IVwXbaVo= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d442f9d285so8450a12.1 for ; Mon, 13 Jan 2025 07:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736783448; x=1737388248; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sdzbHJenGqn4P67PfzTu0/El8zYlgmiqEyHkspIEBR4=; b=li41Oa8uBcOsEEdIlmIMlOTUPg9KVZx62tVccLl7UzQfHyuo4WvLMAq8GDlBPhzyDg 2ekpQSRMRayDya0+lXJq0floxYtM5VY++8HCueXF4kwS3CUVu/yKJoDDfnpfzd5cJyLI Rqqch2REKLKAtrOhPeqSm2RmjMfCIm9GI85L1/O2qrFJLgDIjJXsgWnj6L5jRpWohhEZ wP4lYR1xf1ixzQQ56KsQi+ZEJG6IgueiLWzcB21inwp39qW6q+Inlv6vU09DmRQWsyLH xRjKnK0F4EameLfItCr43e2D2TfGEKnHj7UcrGHMUEmShz4zcZB13+rsWOpVRBmxiZLk peNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736783448; x=1737388248; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sdzbHJenGqn4P67PfzTu0/El8zYlgmiqEyHkspIEBR4=; b=cWV79Xjk0nIv/ZjtHWkZYE2jItSSmoYkfoafoHT8FK7p5POLePbVGguawk8nhsLxrv TgVtzN5wQtlMZzeB3FH227pv/MfJHm7YBtrnNvgNHWzn4DhZyumXkpDm5U2jhqApTGhQ Rc3tap6KfOxOlZQBPzFnGIyKkNgr5k4f43kZk0zC8SJH/DODDNcmvqTEr24z0YImUxXc p8LI+VHXLphcno7SY7z991jTpvzYQ1lE19jfHVhk/Ag0LNx2eyeAKcIrgyidzXIVmOKr 0jJDlL+m/2wZnQal1z3iPG692Ej+kuPPrhXiJr+YKUQ9xmAOsVD5s1NMj1Gd5Wn6A+/e QEVQ== X-Forwarded-Encrypted: i=1; AJvYcCVZL4MYLaVi5ith1z16P1ElUf0t3Nc2Hy+rubN6DA7C8VoS2Xy7IP9cGpykt1DolhbOiWmDhmv04A==@kvack.org X-Gm-Message-State: AOJu0YwRMNZw3F1wSXjFjf692EaiMifMSBc9YpRp0vZkn1B5btn6Xm0Y OHPF7xpeQ9q+58/c7zemfH75P9Bkh2Fb8X9WX1qcaY5a/OusJwJl4atMt6voKK76qFWQjUR/gO5 aZ0T5qG0DPQSfv857LY0z+lO21MXIvJPS2N93 X-Gm-Gg: ASbGncsFJKnAruBQJmCm/jAQ2mFqVpOwQ2pSd93C3jmH/peWTd8BWRWYQpKr7fuPjnU rziRxleKNqtoaMjVVBUpEWXxTd9B1OVWz8Zy12kv1HjgqE0/R3MnBlKK0IVjiVVbwfg== X-Google-Smtp-Source: AGHT+IFjQo4KC9h7NGQWpZsz+wX91ojbtVzJNLh/Gx5/XJoSdHqiXBTUou5pUOay2i7eIEa/AcUl3YeWwuinPAOkdQM= X-Received: by 2002:a50:934a:0:b0:5d0:8752:cecd with SMTP id 4fb4d7f45d1cf-5d9a0cca0a0mr215696a12.3.1736783447180; Mon, 13 Jan 2025 07:50:47 -0800 (PST) MIME-Version: 1.0 References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-5-riel@surriel.com> In-Reply-To: <20250112155453.1104139-5-riel@surriel.com> From: Jann Horn Date: Mon, 13 Jan 2025 16:50:11 +0100 X-Gm-Features: AbW1kvZJXVvvQOa1YQjY5eVMsUNXhH3lBrYWeWQe0ZlGPcYXSRYQIZI2qtYzEB0 Message-ID: Subject: Re: [PATCH v4 04/12] x86/mm: get INVLPGB count max from CPUID To: Rik van Riel , thomas.lendacky@amd.com Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: d4wcbgykqnqnu6bteta7o896igftd3k1 X-Rspam-User: X-Rspamd-Queue-Id: 5637780009 X-Rspamd-Server: rspam08 X-HE-Tag: 1736783449-814084 X-HE-Meta: U2FsdGVkX18CEEtj6OGAAPWnFccLmDPnXfyLB/n7jp8A2LKgAncrOXihWpiyeB0KGvNWyD1fTP4ybMBfoWjRTd+353E+rS8hJQqH5Gj/RCDsguweBvfr2KGC39YOjARKqq8tnQqMYpCWB+Io19rB8r4w+kl/dBoD8MTgkWVlpgrnmlhERf4EkXWT3lzjO9xuKIsUKbws4NVdqhZBSZJtwh9hSiHt1qo+5D4yolcnVSGKDhNjlLlQz7f9Vf5BUpoZoi/I47TzCl1MDgQrRZQSbMHp3ukNA1FRCjngHP9zbK0O9jwRiFzuF0vu2Guthjl+1K0BylhwvRga0FpaWea7l7IzlTd65XcpaFB8D1T5pM6vo1XCwLVCPFOpejHjvECFqFhmjePoABih8ZcV7bNJWnqLw79FU6bNDMTHj3iDOo5QkFD/3T54/yOZr/XMQkSXWT0bKQKGrxQJJ9PaufMtmhKzdGTL6dF5lHmvLCFQUkMUkthI6gfmZs4fTnMcU2s8D2G9xqypv0eSNBgpdb6Qexgf85ewXHnN7eIa5a9vgZRoNORS8ubeg8swFpXtFRmy+e8azV9xNlvCdxqjGyp4gjBTRD7mycIUhy4Nce5j0Q22VRYlsVBj3LMnaOxGDiNriupjoMu90QziqBOJmc6y3NSU0xdCCh5jAXnCal3ebcDHu7n25doDv6IpgncXFLvBmTl9k40zyykZYm5wLSZZNCC6tKe2f1YezTUdwJpQ6vSzQg/CsQeL733ZnNAGzBhLcA2Cs90dhufYGpYg/6wZCf/em7Vw9tWZ59tgxzNGJ1Ooj2UlXGzaSJ4mQW7XjmodxS1p1lIRzrBJGClxzbvbw8B8FJBEQCal5evHqoleE77AjStIWWFfk/+vRFdKbeqB1z9rNFlLdUbHoO6S9KwTYQ++jNk2wZR4IHyZH2PC33sFiuiha7W1hUEqY1n/+Gmc3HpSmKfd6jzpLKwM0Df EC7DzTOL fclxtgppoop/LfnEjL6qOphjmI1ayUulgGTnG+A75doHFsN5yjgQqwO76LR8S6wqnHwQzCTcA5nIRNF6ZyZ9CTNJKq6sM/sY8TShUgg/jPA7sIbaRTlGI4CTOxKQDlNilX4QWEMqHdWfws3yvfyPdhWjxxU23pj//oUKKvxyE4esmxEaqmBsEFmWcz2VEueJTgf9PpUtsHHJDrnkQsJGszfQlDfGsR83IuK1Oy43FMZfwOKtTFszLdgilyejgU35blQVN14+4qEQQBVcFvBaBBbUz9Pe+rLcbuqG+/MxxTv4g+lP+oIlDbZDNU3PXkMesJqs4Cpo0CnK1v9ZWU0/5A2bOqAfbItjfC0DN X-Bogosity: Ham, tests=bogofilter, spamicity=0.411465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 4:55=E2=80=AFPM Rik van Riel wro= te: > + /* Max number of pages INVLPGB can invalidate in one shot */ > + if (boot_cpu_has(X86_FEATURE_INVLPGB)) { > + cpuid(0x80000008, &eax, &ebx, &ecx, &edx); > + invlpgb_count_max =3D (edx & 0xffff) + 1; I assume the +1 is just a weird undocumented (or weirdly documented) encodi= ng? https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/progra= mmer-references/24594.pdf says that field InvlpgbCountMax contains the "Maximum page count for INVLPGB instruction" and doesn't mention having to add 1 from what I can tell.