From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADC7C433DF for ; Wed, 14 Oct 2020 22:30:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 924052223F for ; Wed, 14 Oct 2020 22:30:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AoTo3+pY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 924052223F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7AB6E900002; Wed, 14 Oct 2020 18:30:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 759A46B0062; Wed, 14 Oct 2020 18:30:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64871900002; Wed, 14 Oct 2020 18:30:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 37E626B005D for ; Wed, 14 Oct 2020 18:30:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BE9978249980 for ; Wed, 14 Oct 2020 22:30:11 +0000 (UTC) X-FDA: 77371975422.27.arch61_0914fb52720f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id A2B4D3D668 for ; Wed, 14 Oct 2020 22:30:11 +0000 (UTC) X-HE-Tag: arch61_0914fb52720f X-Filterd-Recvd-Size: 3852 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 14 Oct 2020 22:30:10 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id m16so1088993ljo.6 for ; Wed, 14 Oct 2020 15:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jjl4waKkIn07fAHZxpQYfL1cJey++l2ULCvo+NpmtTI=; b=AoTo3+pYyDr0w6VWhfEzWtgMAa6u5EqUtIbZQ2wdSG8KrCn9aVrqk/7yhPB35QnD2m JalK+SeaQ3hXLo+S8bYDoNpWfnWxpQB/o00c26w91a14/A6mI5fG/jqus5sDeNFJLDuf BsNxJpUzCDXQHeObfZmnVJDuNlP1hv7yxDec4f6BOhh0CaTaty/5CVDrrONvhaHafpy3 WWTj3p+df5fee81/4WgRdKVsueCgR7C+1tyNM57ZEFJuZcNf1kD37XwCnPAbjSh/vXPz 6/Tp/AIlfr9HFwxC0w941Ocrco7hY/ksvJfhYETS8inE9HqwSVgikBfXguqBqfsPqKay 3D5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jjl4waKkIn07fAHZxpQYfL1cJey++l2ULCvo+NpmtTI=; b=Y5duqh4SiBsrL/g3maZfsRwcGmhG+e/39sSFxGA1zcQb61gYxkRtVtiP29kgZs3qLH F/yGBMR55dk1ktboxkTukv78yp1uvQntCWE3uW2YmQZM4TWB+QYte8HD8NkR2lh3t1eP ozKCmdUxuo01nc2kGIJE6FKb0fSMJT5Ofqlg0fs5jlqBbcZ+bcwhmYClzbfvnxGEbFf7 cI1IWgksN7RtJAX+wFzgE4mlI2G+LSANwPz2LBS+urwt5GQKOsrcYCHGQEXO4i4KceKM a6Ai3dUk/thgZZASedyq9Km3r0jHbNFW3+uZbfa9qZjumjNW1vD+1b7Y3aGrobju3ZY2 V66Q== X-Gm-Message-State: AOAM533lEp3idaVfYLu831ko+6jCd1owemc3cZpKw5y8Lh5D2d9L3q6Y 7t2ZHquhWgyHGZvvXnLSrq6Pz8o1ilyBm1WhYizFQg== X-Google-Smtp-Source: ABdhPJzccfdlAK+SRaf7zIcMIaXsyDc7g+LulQbCIaLDti9pJSokw7/xfAWa5vfRRrUMlssMAS3ed5P4pPE1EvYM4fA= X-Received: by 2002:a2e:9f13:: with SMTP id u19mr119925ljk.160.1602714609293; Wed, 14 Oct 2020 15:30:09 -0700 (PDT) MIME-Version: 1.0 References: <20201007073932.865218-1-jannh@google.com> <20201010110949.GA32545@gaia> <20201012172218.GE6493@gaia> <20c85633-b559-c299-3e57-ae136b201526@oracle.com> <20201013091638.GA10778@gaia> In-Reply-To: From: Jann Horn Date: Thu, 15 Oct 2020 00:29:42 +0200 Message-ID: Subject: Re: [PATCH 1/2] mm/mprotect: Call arch_validate_prot under mmap_lock and with length To: Khalid Aziz Cc: Catalin Marinas , "David S. Miller" , sparclinux@vger.kernel.org, Andrew Morton , Linux-MM , kernel list , Christoph Hellwig , Anthony Yznaga , Will Deacon , Linux ARM , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 14, 2020 at 11:24 PM Khalid Aziz wrote: [...] > current code? What FreeBSD does seems like a reasonable thing to do. Any > way first thing to do is to update sparc to use arch_validate_flags() > and update sparc_validate_prot() to not peek into vma without lock. I > can do that unless Jann wants to rework this 2 patch series with these > changes. Ah, if you're willing to take care of that, that'd be nice, please do. :)