From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9986CC54EBE for ; Mon, 16 Jan 2023 20:47:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A99076B0071; Mon, 16 Jan 2023 15:47:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48BC6B0073; Mon, 16 Jan 2023 15:47:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910986B0074; Mon, 16 Jan 2023 15:47:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 812136B0071 for ; Mon, 16 Jan 2023 15:47:17 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 52C551408CD for ; Mon, 16 Jan 2023 20:47:17 +0000 (UTC) X-FDA: 80361847314.09.80738F9 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf22.hostedemail.com (Postfix) with ESMTP id BD038C0005 for ; Mon, 16 Jan 2023 20:47:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aDz7ZJO9; spf=pass (imf22.hostedemail.com: domain of jannh@google.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673902034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iC+oOTJgto8VDtuk5xPA5HP7pWMeJabRRCEJJKrELSQ=; b=P2oeSgOa0xAuUM882IDOJII/FGdP4rQSEgc7s6m3DAP8XV+0GN7UZOoWgrQUb8rKU+5if7 RmaP+JVcbp8XEP06UXJtpXDVQEyTJ0YPYzf8mwJO6rI0/OSdDpEYlEYMmP5pKTs8RC3IEC QyoIjUP51oKDevU0Q2Lk28ijzHM8F8U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aDz7ZJO9; spf=pass (imf22.hostedemail.com: domain of jannh@google.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673902034; a=rsa-sha256; cv=none; b=hrZhmHhXNAJpYVoHvy2DSNd5xV6MNl23/rh+JQRyEi/xrgcw1SzUCD4L5xEW0tYAHApRcO T3bpySyRlLtHknN3bGGm7inuuz/gJ0Oh6OYZ19hqvxhWrO6f+XELZcDmSNXKKmyZKfuaiV s4I0uNMW+lXZy6g2mWhh0wCtOpUEg68= Received: by mail-io1-f46.google.com with SMTP id z194so2235387iof.10 for ; Mon, 16 Jan 2023 12:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iC+oOTJgto8VDtuk5xPA5HP7pWMeJabRRCEJJKrELSQ=; b=aDz7ZJO9m418+GwGL0HiNp1x++f0x45vkBMs4mHss64uYt10pryVzFQ9OQNBejhG96 1iELx/+OW4A/oPxA3WPfURAp3NJFNSnUPNYb0u+E7p82d6E5acpm+Y+Isrbz9G/6OhI5 KXiGIq1qO7Iwei44ssy4doUpPlmggCjZQk/dI7gCvmJpt4Kw0IwA9R3/5I8N8FT+kOeR lrirY2DKDRZAiMs5ELa1/1qOYGFvzOfN9lbcZVxEEgy2VExl1VgxI0EtLhLJ4VxnLhbU yE2nr4Qr+QM7+vn11jZTtDxay9dxwIdJlKJRkePs2yqV5yZEjnRiZxtE+82nkvn/2bbx nYPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iC+oOTJgto8VDtuk5xPA5HP7pWMeJabRRCEJJKrELSQ=; b=vxL0fHiNAcMz2WDNUFEu2ZnzzIpVWOf1s+Ml7s+mlWir5MpaSaTA8Ag5ETmSNQjxZW UlsZ2zpCxg5WlBE0ULjzF2IzUIod01yPGgJDOe+QCtqR4HMTfAe0/75K/PYz/0Ds3C3c 6k0j14uaj0RHuf2E+GFzCRV0+Vt/Z11GlgfoRmaTSaGu879bbz4oTI88eqYuRAc7waHS ayQktqyXbJ6cqOiZ9q6/JbCXFa7gT27fHtOniZ2O+r9nJd4skkVI39bZ2E8FhAv9CXpg rQIK+cHfPNqKLwFbZJzvDRtaTPiy8zG4nV7+lsOCmtRhUfSA0nyDtFgpO8f+U9s1S/LQ EC5Q== X-Gm-Message-State: AFqh2koHzwY2VzkWtqaZA/ezmSema1PNrVKajQUfQ1LeGi3yymg0lwsD IYrtyeE9WpO7GCGzzX/BhvYuUk4AB8LDU3Q3+6J4Zg== X-Google-Smtp-Source: AMrXdXtIenOHKGALstnNyTTVSZWahRV/Av5bE6uzHxah75ffnBwJid1mFHkItGWCVEWwtzut5lEKaSIAPMTQyU8O0lw= X-Received: by 2002:a02:2a4b:0:b0:38c:886a:219a with SMTP id w72-20020a022a4b000000b0038c886a219amr16110jaw.133.1673902033675; Mon, 16 Jan 2023 12:47:13 -0800 (PST) MIME-Version: 1.0 References: <000000000000baa88c05eaa934bb@google.com> In-Reply-To: From: Jann Horn Date: Mon, 16 Jan 2023 21:46:37 +0100 Message-ID: Subject: Re: [syzbot] stack segment fault in truncate_inode_pages_final To: Dmitry Vyukov Cc: syzbot , almaz.alexandrovich@paragon-software.com, ntfs3@lists.linux.dev, akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, willy@infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1jjoa6z177abhuif7g4xdcdnq4d39hrh X-Rspamd-Queue-Id: BD038C0005 X-HE-Tag: 1673902034-426529 X-HE-Meta: U2FsdGVkX18b0Y3n7Que1MZSzCCFoBWpmTZYOEhrWJooP7dq+fVMCgHDUq5RUNiDunIwrJB+/e4KDig+DJPTvvXaa9zwrdoYxstIJS8DHMQOBThLN5mD9qUc9LpwujmRiioj6QONeCbqcVyRxGy4WAmyiBljhZ7BeYo4nHauaxuJFMk5KR+ZB9a7v/mLeNd8fPk5IZ4nGce4mj2G3TbC7cVEb9kRICtsr3bS/6fNjd0RDDbjgzyLzucQ0mO0u6BsaLnG7pH2lgCsmXk9+g5ddIDDao9EesL6/qjHR4yrwtjBptiCUMYF8nfosUL9elO57i5gLJkY2sJMbuVUFQ2sEc1sjkcmTjsDnG6bern80bFIQGth8IA//QqT/TUUPYSzeMtppGQlYxKV2OIgs66VzGBJZxTFerInaANbpbHaWwDWmPaR5OSHNFBI/6Uq8GRRu8Yvc9AozwZzOo2pVJM6c9vUxH22e2Y/KWtGQYkFXGGN9sO6+iSDFulIlE7QhFWrSgqilYnkCdOHPWH8T5/IlQVPipw4/WtX3yuvfPWgcmE2DnfrSJXrodFkjN7+SIFW9Ak8t+1enEOc8lxOuQrO8Df3EdareNlyy6q87+GMxSDYkzXlz0JWAe0WujkQ3MQJA7U9b+pT8kC0v2gGj5ZMm9nEbQr6iGF3wzfbxNZby0DaVQXdnxXcGQWnWQKdEAa+GBJwsY4eq5sjn1q5g/XgW0W490VWz+ccrRHGFBELXD3HxigOPEcXgN8NR2GjL4FequHe9a5awVgFjHmlybbyODJSCETvriB+3pXA2V7dtBP1FUfPSy60Y5orSC4lUQaKAQoCYNAVkfeRIte8XdfEM46hMNpTWd08OM925ggxGQpD7CdKqSEEwy5nWFCRq68wHwg+ewUg1wI0c5Ja2KcV2KWrz5jdkcQ6Bo/zzuLocII4X1pBz7rRNFmwHsH+ia/+mDKhNrEdoKQXaWe/CbY OdXY6pZ5 nSWd6LxNQFSXtNx8vnFo82GCp8qz8ND2v8r99HAqbK1fWl7JzSaqFEArrrD8Qsy3aF15QI+jTvGmAYTxc2M/M3BuVWUTuB6Fmqkn9EaXoFzyA9YxOJzhXXzQw5gkt4Lt5bd5T+iWAbMdLmarS/ioX1oeQ9LIyv5QlKtQBWhSgdukEDh58ufj7Wd6oTcZHiR0H9oUNAFLpOQnDLA+CJljiqDXnaQuAwxfCdBQnoKZhTIdJIhbMmIKr4RIrFNULpGazxQAY/kInqozJT4TD0prb0PnXgnZn6V/ehvKLHEjSjOMJJIWyIS7H3MPEKm15l/RQC6Y9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 10, 2022 at 9:42 AM Dmitry Vyukov wrote: > On Mon, 10 Oct 2022 at 09:35, syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 833477fce7a1 Merge tag 'sound-6.1-rc1' of git://git.kernel.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=17cae158880000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=676645938ad4c02f > > dashboard link: https://syzkaller.appspot.com/bug?extid=0f7dd5852be940800ca4 > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/f66757bbae28/disk-833477fc.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/50ec5a2788dd/vmlinux-833477fc.xz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+0f7dd5852be940800ca4@syzkaller.appspotmail.com > > +ntfs3 maintainers There's something deeply wrong with this one; it looks like we're trying to execute from an RIP that is not aligned to a full instruction. RIP points to the last byte of a CALL instruction. It looks like, somehow, while we were somewhere inside _raw_spin_unlock_irq, something stomped over RIP. Note how the "Code starting with the faulting instruction" section shows an instruction that's not visible in the "All code" dump above. Code: 48 c7 c0 40 e8 ca 8d 48 ba 00 00 00 00 00 fc ff df 48 c1 e8 03 80 3c 10 00 0f 85 e0 01 00 00 48 8b 05 65 42 6d 0c e8 80 2e 06 <00> 85 c0 74 17 65 ff 0d 55 c9 a4 7e 0f 85 3e fb ff ff e8 ec ce a2 All code ======== 0: 48 c7 c0 40 e8 ca 8d mov $0xffffffff8dcae840,%rax 7: 48 ba 00 00 00 00 00 movabs $0xdffffc0000000000,%rdx e: fc ff df 11: 48 c1 e8 03 shr $0x3,%rax 15: 80 3c 10 00 cmpb $0x0,(%rax,%rdx,1) 19: 0f 85 e0 01 00 00 jne 0x1ff 1f: 48 8b 05 65 42 6d 0c mov 0xc6d4265(%rip),%rax # 0xc6d428b 26:* e8 80 2e 06 00 call 0x62eab <-- trapping instruction 2b: 85 c0 test %eax,%eax 2d: 74 17 je 0x46 2f: 65 ff 0d 55 c9 a4 7e decl %gs:0x7ea4c955(%rip) # 0x7ea4c98b 36: 0f 85 3e fb ff ff jne 0xfffffffffffffb7a 3c: e8 .byte 0xe8 3d: ec in (%dx),%al 3e: ce (bad) 3f: a2 .byte 0xa2 Code starting with the faulting instruction =========================================== 0: 00 85 c0 74 17 65 add %al,0x651774c0(%rbp) 6: ff 0d 55 c9 a4 7e decl 0x7ea4c955(%rip) # 0x7ea4c961 c: 0f 85 3e fb ff ff jne 0xfffffffffffffb50 12: e8 .byte 0xe8 13: ec in (%dx),%al 14: ce (bad) 15: a2 .byte 0xa2 We're interpreting unaligned instruction bytes as "add %al,0x651774c0(%rbp)", and RBP is non-canonical (1ffff92000a6cf44), so we get a Stack Segment fault. Unless this is some kind of asynchronous stack UAF decrement, I think this might not be NTFS's fault. > > stack segment: 0000 [#1] PREEMPT SMP KASAN > > CPU: 1 PID: 22407 Comm: syz-executor.5 Not tainted 6.0.0-syzkaller-05118-g833477fce7a1 #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022 > > RIP: 0010:trace_lock_release include/trace/events/lock.h:69 [inline] > > RIP: 0010:lock_release+0x55f/0x780 kernel/locking/lockdep.c:5677 > > Code: 48 c7 c0 40 e8 ca 8d 48 ba 00 00 00 00 00 fc ff df 48 c1 e8 03 80 3c 10 00 0f 85 e0 01 00 00 48 8b 05 65 42 6d 0c e8 80 2e 06 <00> 85 c0 74 17 65 ff 0d 55 c9 a4 7e 0f 85 3e fb ff ff e8 ec ce a2 > > RSP: 0018:ffffc90005367a10 EFLAGS: 00010002 > > RAX: 0000000000000001 RBX: 0000000000000001 RCX: 0000000000000001 > > RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000000 > > RBP: 1ffff92000a6cf44 R08: 0000000000000000 R09: ffffffff8ddf9957 > > R10: fffffbfff1bbf32a R11: 0000000000000000 R12: ffff888093973498 > > R13: ffff888093973278 R14: ffffffff8a22b140 R15: ffff8880478d8a00 > > FS: 00007f9ae3bb2700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000001b2e927000 CR3: 000000003f6b9000 CR4: 00000000003506e0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > > > __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:157 [inline] > > _raw_spin_unlock_irq+0x12/0x40 kernel/locking/spinlock.c:202 > > spin_unlock_irq include/linux/spinlock.h:399 [inline] > > truncate_inode_pages_final+0x5f/0x80 mm/truncate.c:484 > > ntfs_evict_inode+0x16/0xa0 fs/ntfs3/inode.c:1741 > > evict+0x2ed/0x6b0 fs/inode.c:665 > > iput_final fs/inode.c:1748 [inline] > > iput.part.0+0x55d/0x810 fs/inode.c:1774 > > iput+0x58/0x70 fs/inode.c:1764 > > ntfs_fill_super+0x2e89/0x37f0 fs/ntfs3/super.c:1190 > > get_tree_bdev+0x440/0x760 fs/super.c:1323 > > vfs_get_tree+0x89/0x2f0 fs/super.c:1530 > > do_new_mount fs/namespace.c:3040 [inline] > > path_mount+0x1326/0x1e20 fs/namespace.c:3370 > > do_mount fs/namespace.c:3383 [inline] > > __do_sys_mount fs/namespace.c:3591 [inline] > > __se_sys_mount fs/namespace.c:3568 [inline] > > __x64_sys_mount+0x27f/0x300 fs/namespace.c:3568 > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > RIP: 0033:0x7f9ae2a8bada > > Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > RSP: 002b:00007f9ae3bb1f88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 > > RAX: ffffffffffffffda RBX: 0000000020000200 RCX: 00007f9ae2a8bada > > RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007f9ae3bb1fe0 > > RBP: 00007f9ae3bb2020 R08: 00007f9ae3bb2020 R09: 0000000020000000 > > R10: 0000000000000000 R11: 0000000000000202 R12: 0000000020000000 > > R13: 0000000020000100 R14: 00007f9ae3bb1fe0 R15: 0000000020000140 > > > > Modules linked in: > > ---[ end trace 0000000000000000 ]--- > > RIP: 0010:trace_lock_release include/trace/events/lock.h:69 [inline] > > RIP: 0010:lock_release+0x55f/0x780 kernel/locking/lockdep.c:5677 > > Code: 48 c7 c0 40 e8 ca 8d 48 ba 00 00 00 00 00 fc ff df 48 c1 e8 03 80 3c 10 00 0f 85 e0 01 00 00 48 8b 05 65 42 6d 0c e8 80 2e 06 <00> 85 c0 74 17 65 ff 0d 55 c9 a4 7e 0f 85 3e fb ff ff e8 ec ce a2 > > RSP: 0018:ffffc90005367a10 EFLAGS: 00010002 > > RAX: 0000000000000001 RBX: 0000000000000001 RCX: 0000000000000001 > > RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000000 > > RBP: 1ffff92000a6cf44 R08: 0000000000000000 R09: ffffffff8ddf9957 > > R10: fffffbfff1bbf32a R11: 0000000000000000 R12: ffff888093973498 > > R13: ffff888093973278 R14: ffffffff8a22b140 R15: ffff8880478d8a00 > > FS: 00007f9ae3bb2700(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000001b2e927000 CR3: 000000003f6b9000 CR4: 00000000003506e0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > > > > --- > > This report is generated by a bot. It may contain errors. > > See https://goo.gl/tpsmEJ for more information about syzbot. > > syzbot engineers can be reached at syzkaller@googlegroups.com. > > > > syzbot will keep track of this issue. See: > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > > > -- > > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/000000000000baa88c05eaa934bb%40google.com. >