From: Jann Horn <jannh@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Rik van Riel <riel@surriel.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Harry Yoo <harry.yoo@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/rmap: Add anon_vma lifetime debug check
Date: Fri, 25 Jul 2025 17:05:19 +0200 [thread overview]
Message-ID: <CAG48ez0fG1vG_MHnX_GXJG7qZc9XwMxhTqyu9YJpCeKEUuuZBQ@mail.gmail.com> (raw)
In-Reply-To: <c3f04c75-a73b-48bb-b56e-7b18e57c2382@lucifer.local>
On Fri, Jul 25, 2025 at 1:32 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
> On Thu, Jul 24, 2025 at 09:13:50PM +0200, Jann Horn wrote:
> > There have been syzkaller reports a few months ago[1][2] of UAF in rmap
>
> Will try to take a look when I get a chance.
>
> > walks that seems to indicate that there can be pages with elevated mapcount
> > whose anon_vma has already been freed, but I think we never figured out
> > what the cause is; and syzkaller only hit these UAFs when memory pressure
> > randomly caused reclaim to rmap-walk the affected pages, so it of course
> > didn't manage to create a reproducer.
>
> Fun.
>
> Please hook me in (I mean you're going to anyway right :P) on this stuff,
> as I'm looking to rework the anon_vma stuff so am naturally interested in
> any and all rmap anon stuff.
>
> For my sins ;)
>
> Maybe I"ll dig into these syzkallers.
For what it's worth, the point of this change is that hopefully we
won't have to dig more into them manually, because hopefully a few
days after this patch hits linux-next, syzkaller will present us with
a beautiful reproducer that shows exactly what went wrong... or maybe
it won't, I'm being very optimistic here.
prev parent reply other threads:[~2025-07-25 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 19:13 Jann Horn
2025-07-24 21:52 ` Andrew Morton
2025-07-25 10:59 ` Jann Horn
2025-07-24 21:56 ` David Hildenbrand
2025-07-25 11:08 ` Jann Horn
2025-07-25 11:12 ` David Hildenbrand
2025-07-25 11:24 ` Jann Horn
2025-07-25 11:31 ` David Hildenbrand
2025-07-25 11:32 ` Lorenzo Stoakes
2025-07-25 12:00 ` Jann Horn
2025-07-25 13:48 ` Lorenzo Stoakes
2025-07-25 14:10 ` Lorenzo Stoakes
2025-07-25 14:50 ` Jann Horn
2025-07-25 14:48 ` Jann Horn
2025-07-25 15:07 ` Lorenzo Stoakes
2025-07-25 15:15 ` Jann Horn
2025-07-25 15:22 ` Lorenzo Stoakes
2025-07-25 15:27 ` Jann Horn
2025-07-25 15:58 ` Lorenzo Stoakes
2025-07-25 15:05 ` Jann Horn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG48ez0fG1vG_MHnX_GXJG7qZc9XwMxhTqyu9YJpCeKEUuuZBQ@mail.gmail.com \
--to=jannh@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox