From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D5BC27C79 for ; Fri, 14 Jun 2024 18:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4E1F6B01A6; Fri, 14 Jun 2024 14:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F8B66B01A4; Fri, 14 Jun 2024 14:46:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40CBC6B019C; Fri, 14 Jun 2024 14:46:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 17A026B0143 for ; Fri, 14 Jun 2024 14:43:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8AF001A08FE for ; Fri, 14 Jun 2024 18:43:10 +0000 (UTC) X-FDA: 82230366540.05.E3CA5B1 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf01.hostedemail.com (Postfix) with ESMTP id B3AFF4000A for ; Fri, 14 Jun 2024 18:43:08 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SP+idai1; spf=pass (imf01.hostedemail.com: domain of jannh@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718390587; a=rsa-sha256; cv=none; b=vvFFOTsqMPpM+HELgFbbm7761UkTekSF2BZF7GK36/zuV3yWD0fMAgVGEeytWq5ijwSLN5 7vzrn1npbUVr0GMAXEBGkdjGm95AmbP5yAJJgjZ/xSNXC0Uc3IM16triau/noFebnrEq0g nhvB1yTLGJoIE5qsSf92BzhuShuVvU4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SP+idai1; spf=pass (imf01.hostedemail.com: domain of jannh@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718390587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aayMcImIiHCchvGs8x1OjnqmxjPWkU2rmtvtJadc+I4=; b=P6jvg0Dh1DUSeS3gwCBBodCVnzrMbYT4YxWio451sAXqXX3D8iPQjYrPoQWKsfA3wlAtxD Jb4OCkmSBMMmOsagzmB8/IxOILDnrzAjU7avL1e8WvpKY2HdCbufV3sNigN4xQhvv5klYC mRVECW8WynuPM92+hvg11MjIccEjypQ= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-57c5ec83886so1947a12.1 for ; Fri, 14 Jun 2024 11:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718390587; x=1718995387; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aayMcImIiHCchvGs8x1OjnqmxjPWkU2rmtvtJadc+I4=; b=SP+idai1BF022xOgWvYy9uyw4CBlOdRET8KxlqQgfgZLQV/8uPexAg9MRJX+Gge1xD st5jhHq30afKkUc7ubS4ac/lv2z0z9N8Aw5Yw5uLdJbSj5jRtyHRSjnEwuCa6hNx5Rsz luUFB0JpdvT14agMvsa2yszY1Vt08GfylsJ3rVqsV0/uwyR75Eq9zm9yNYVHt7/tNnDQ Lv7oTtkeCYI9uH0eZJAYEcpmHTAT95H3fFrWHeef6aS+n54SlGiAcZjhPy+5B3HmKPCR 86hafrccBaRg+6BngRa+R0JvSMQDwq/3Ota4uix5RgWvIDar9wZcwRWqtvKpi8pwOmft Cgew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718390587; x=1718995387; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aayMcImIiHCchvGs8x1OjnqmxjPWkU2rmtvtJadc+I4=; b=SQVVpdGbb3eSh1ttSDOzEBbEQ0aWDAzmzKeoD8whODB6254pO2hzpLZ+ckGQ1QRIJQ WWgZue4EJKDf24zbgboqQ6EwQAEpv6kyCutUj9Iulx9xst+CvMjX0ZZgYgBrDPAN7RLu 69VNsUCP2n/pmMgeogzJhTQJ1WmBjSLl6UKuhh3iQiuaNdZiHLLjhGnuj9sj77pKDtyM Gewd06VXbDFeH+gqwqbm2JkZ07g9zq8h6M055k1gEE28id/AD39l+30z+nSxR3ytrJYj nseuC3XQbacuYIppDBBOo3BcOq5IVMV2XlAn9B7ppQtXrUy8jdsuuafOoEREGBI+fy9G Xv4w== X-Forwarded-Encrypted: i=1; AJvYcCUhUSwAauNySt7N4D4ZnSgRdQDj38OStFVid17WU4puh9IzL274N/8KDuw5Gf3FIN4Tsr85b8TL8HuqgjQbqmiwZmQ= X-Gm-Message-State: AOJu0Yzr8iVyjyr+swWnvIu8dwIr/+JRZiGI0ko0taC4u34rl5JG2O0K 0HHDz3VBvTVEJODEt2kYx3DsRrHxHIIhQ4TaBUyKUdxfR8pFXVYyN3EBAqaZ0xd/+HyB4kye2YA 6C0F0Txr+Nnf3ihZWZmBxZ69L7HJYgpXxqn80 X-Google-Smtp-Source: AGHT+IHiLnsao6D4I0PlY5y01zGqUfsNOxwQfXlNIU0uLC/MCNKZUC5n20ybAQIu2EUPjg2n4pMs3QULLfqieAd5xKI= X-Received: by 2002:a05:6402:35c1:b0:57c:bc56:811f with SMTP id 4fb4d7f45d1cf-57cca54e76dmr25657a12.0.1718390586382; Fri, 14 Jun 2024 11:43:06 -0700 (PDT) MIME-Version: 1.0 References: <20240614182327.752156-1-jeffxu@google.com> <20240614182327.752156-2-jeffxu@google.com> In-Reply-To: <20240614182327.752156-2-jeffxu@google.com> From: Jann Horn Date: Fri, 14 Jun 2024 20:42:28 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] /proc/pid/smaps: add mseal info for vma To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, sroettger@google.com, rdunlap@infradead.org, david@redhat.com, adhemerval.zanella@linaro.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: dx8g1mfqq64rr5pgfrjti95c4wsqt43q X-Rspamd-Queue-Id: B3AFF4000A X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718390588-152439 X-HE-Meta: U2FsdGVkX194PEeI4oERRp4FTCaLhBRGkocG/NJUS6Z1uPiI9ow4hJ9sYWte4tgDez+msT2P8lefbSLMqfhgIv4sbsRRmPlPUOg14sdvAHlT7CRwwV2SSroyI4t3KKEkUC5NJrmx6lNmU5EMulRvYPK9YhHwN+KGXM4tf3pGDqMOdPc1M8SAUTTt/NTc5xM16hPJnHMYTU9LAg9SiahEr22dw2ZXVD59R8TpwTTaVW8y4Ni1eTRLNYNRNVSuoAgy4kfpLrdqxRJL23PqI2F72VmxqpCCVYFhNQ4ikADLAiOQL6PFfw+JTJt9g59G183A1Woz+S17nn2dslOhqDiOU3a7Q/HLyjYokjzN72WcxMGn38wkMkmpdIgn8GSqU7Dkwe76cMnWnN8og+7BUQFMaLJR/7PVPoribdMqWvIMOwNUJsIhs65y2SWsAqCarGtGovhz58uFJwyvSChj01WAi+hduOY5qhI5dJrXzt+G0WJfLBHFihp7xkRWDmY2/tLnAUVWn9EI3Qd42eJXF8G7IHGidXufEgNhf6we6xx4ygehIaUdbKhyWXICQYkyCELLh09t09+bPh/R2KoTPT/38HBvSEz/r3rX1loH1e2o72aubm3T+fnsCWa296xqVq5wypI4v3usqnpjH0ckWURMy5twwdD3Z9X+FXYPvWA89C393sKJuM0eXTpCHk/sJ/4ID1zGKBRAvHGaCHeaMPusWDNm5xxbW93LUIx1RPlKxUskcVzW//AQXvu+klyd8bLLy7kPABVkesFlGv/bbwKzeNaLyqRfTVv+F8l4is1D/3tcWDHcNP4BVkylquIslXnBpORp/y9swBQolQeOx1TZxiDb+D+8gHpd5jgRWXblGo2uYR+GIkWvgoXUOcc+SbAcj5crpiBCcjUuyqLZSYno6evsmO3IxgTvO8L/CgdvfnC/x8e/LgWPz7DdQ2PeJRCdImqWAm5WEUrsUv/Gp+y 66dBU7Zj H2qrg4v+5sRrAhQh6RgSDAmcSwGiZJDfgy/XZUBgB/WsXgFic74y06+dxJgDbnbk2l79Hm6U8YpSvYtY3HQKJIv0qafD9H8TaYlbZ98fuDIRoeT11Mgwo6RmUD7gVNKWYhaxEdlIuwJpaWgb08A9S6Cy+Fnz+yjQ2jPGTNAliG0jtBm/CAoLDURSSlq2zbs8Lc0JKRj5TtJXTiDq9C/4mB3CHDAsDegjpsbXuSA82jZSiwwc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! On Fri, Jun 14, 2024 at 8:24=E2=80=AFPM wrote: > Add sp in /proc/pid/smaps to indicate vma is sealed > > Signed-off-by: Jeff Xu > --- > Documentation/filesystems/proc.rst | 1 + > fs/proc/task_mmu.c | 3 +++ > include/linux/mm.h | 5 +++++ > mm/internal.h | 5 ----- > 4 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesyste= ms/proc.rst > index 7c3a565ffbef..400217a1589c 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -571,6 +571,7 @@ encoded manner. The codes are the following: > um userfaultfd missing tracking > uw userfaultfd wr-protect tracking > ss shadow stack page > + sp sealed page Nit: Why "page"? The sealing is a property of the VMA, not of the pages mapped into it. Maybe "sealed area" and an abbreviation like "sl" would make sense? > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 587d34879865..8600564898fa 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -314,6 +314,11 @@ extern unsigned int kobjsize(const void *objp); > #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vm= a */ > #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages = */ > > +#ifdef CONFIG_64BIT > +/* VM is sealed, in vm_flags */ > +#define VM_SEALED _BITUL(63) > +#endif > + > #ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS > #define VM_HIGH_ARCH_BIT_0 32 /* bit only usable on 64-bit arch= itectures */ > #define VM_HIGH_ARCH_BIT_1 33 /* bit only usable on 64-bit arch= itectures */ Other 64-bit flags are defined further down; maybe it would make sense to move this definition below the definition of VM_ALLOW_ANY_UNCACHED, so that the definitions are sorted by the number of the bit?