From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD142C02180 for ; Mon, 13 Jan 2025 17:25:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 500C16B0083; Mon, 13 Jan 2025 12:25:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 489F16B0085; Mon, 13 Jan 2025 12:25:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32A0C6B0088; Mon, 13 Jan 2025 12:25:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0476B6B0083 for ; Mon, 13 Jan 2025 12:25:34 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9A8F91C607F for ; Mon, 13 Jan 2025 17:25:34 +0000 (UTC) X-FDA: 83003105388.06.A9AE7E7 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf08.hostedemail.com (Postfix) with ESMTP id B5F4F16000F for ; Mon, 13 Jan 2025 17:25:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jG5g44iZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jannh@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736789132; a=rsa-sha256; cv=none; b=7xs/chEiA9UbOAFK/0+UHOlAKy6oCIhprr1Lz1QWGKX6MHt2NUKbqswbPXs0VR4LtwgK+i t2TEOZP+BART7kpqqinM0xHt+zgGK+cnygftcP5WtEPe264Um8JjkkF+LZQm6iAnba3+i/ 4hdq01bYDvXaHIaPflmQ+yuoCkqwPjU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=jG5g44iZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jannh@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736789132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1qfv4tSt68v2OjlivyRQ+MocYt9gBxYVRMLbaNwiKiU=; b=gw4hulRYEZttAFzVdZVStCXJsLU04P4stKbOOZqAfjw6d3zp5t/eGK9SPNpQMYygp2Pr/x IqxY3HXuI35xs8KoslTa+DiD677zo4e8TfNdo+8sScweRcXdamv4OH9p1Xq8WuA126jDiP WAm3cTm9ebo/aO58VFs/2IGIYgKUkVk= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d0c939ab78so12252a12.0 for ; Mon, 13 Jan 2025 09:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736789131; x=1737393931; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1qfv4tSt68v2OjlivyRQ+MocYt9gBxYVRMLbaNwiKiU=; b=jG5g44iZkGKHldomsqS6sZuQpWhuLHHbdgBgpQd0yr4LgmCWp+FsT9mUxNUqSeZsEm c+GJ591Z20qK9mhK/UBkO8HkYp8SJXCDJMl7zBwSm8SqEIiOEMeHRIrEyeZYgKBiDycO yDUyrKCO/caYoS2jtNfY8IQvu7t2c33kLJODHE9WNhzGxBjkZeMsPxKYImTLcfxxSI06 3q4u3ovpg7fBSXP+N0WykAD7vTUrEjTA/44JGFAPlkZg/LDXghKQ3BcJqgTX2Uagd74r wB49A94R9zxz8fNp52Oh/GJho82ffAwGV2pSlmZKbaLal5oVekga4i1gppXPH4fNlrNY tSqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736789131; x=1737393931; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qfv4tSt68v2OjlivyRQ+MocYt9gBxYVRMLbaNwiKiU=; b=cwDRgk/vqC7dmdj6xJzahxcFtBeZc/UvDwddTp4fWdhM59s0UhvCdXA3RnatTI0Y5G BMNdoyAh0MbD9/fCRqJNvZupWDNacb+FH7S1hVvAGoOieXmQonUdnRWTWJL8gY0SOM3z 7wNSaup8heLI766vpfS8a3OQFgsM8LXuWcdhHcctu36flb3jFt6xeB7XOl8W8nXQ4rlP 7r2y5ra61yJeg40KFIrE75mwU5cdHi2+jxROdixWaoZknmL7qCyIm/D1CgvooP8Ay7Gi cUXSsJTlH7mIYYAg/87oMVxhnD+Og2D4yhIsQf2rzq74XlwmxCq3G4y4o9JPvsIanGVp g8mQ== X-Forwarded-Encrypted: i=1; AJvYcCVEBZVEKcbN+hrAjTDTXrsK0MykxF9wY5D0hTLbSf8FMtWllPoSdNlmPn3mN7NQGFkqKlJYUYYwtQ==@kvack.org X-Gm-Message-State: AOJu0YyY/hWSU8qFju1MjqRztVtHc7u7+gqCZ61eyBL4nmf+WagZcHQe VybWTsOpXXBYJz/dgObRnvFUOZUZuojG6eSSJZ5Q3lTAt7MaIuhs9L/iL0R3uWKYUTct14cVzwq SzI0JqaAzFbd/DWrULKkRqVwDkebcgR/oh1UE X-Gm-Gg: ASbGncse/tiqDKq/bNq0Z1jxMjCQ35NHVu4szahTIftQ3hIGz4I4QhidDEdCKEGV454 F+LCnp/AkwnFEbqgXnQUXsxgmVHgzS1jgkD4PPsP17wjEwyr2XB9Yfc1FqfyS2CUjmg== X-Google-Smtp-Source: AGHT+IF5IklE9/KPlmAY7nB0Yh3AewBcg5TtP9qRlH4gktezO+oAIzkIcfy8QYZmMWbvksdSwXwHplfsYMN3U386Qws= X-Received: by 2002:a05:6402:1d84:b0:5d0:84a6:f1a1 with SMTP id 4fb4d7f45d1cf-5d99fbd7c37mr275511a12.6.1736789130729; Mon, 13 Jan 2025 09:25:30 -0800 (PST) MIME-Version: 1.0 References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-6-riel@surriel.com> In-Reply-To: <20250112155453.1104139-6-riel@surriel.com> From: Jann Horn Date: Mon, 13 Jan 2025 18:24:54 +0100 X-Gm-Features: AbW1kvZ0J3l5YeisM7wSBI7HTA8kNyQ-kF6DQyQR0uEK5SEuEbKbsLDQeRRF_JA Message-ID: Subject: Re: [PATCH v4 05/12] x86/mm: add INVLPGB support code To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B5F4F16000F X-Stat-Signature: zred89wttgcfmyg46xbgskwhmxdb8fsi X-Rspam-User: X-HE-Tag: 1736789132-956459 X-HE-Meta: U2FsdGVkX19PhpLqCEjbFqUh//lEiMoj4l1Lo+LsRP8BEO4zx9/dgsj008w7iCPX4Ceb6+nMIAZGG6Ioxl0/6Z+i5GxP1Z6YB2j5kcB668iUQaKvHXMWzfCI/eUGqIAz/9tMlj0atbiKzVnlWid72eXfu8AvqMTP3djNQ4tMbLce54IUBobBP367mO4QmLkFEOB2HD6Vx7TqyiwWN+4J/ibUZhbG7Ba+II0PUHvYn3TriY9JcHE7Ijc+R8NTBknvbB3dyvxz5zSvitK1CMwhtcy16MkKJADemQBvnjoJSgT6ffyd5/uShYzgij7SlKyE903ST4gLInqKlJrDBE648HRqgTBosbE/4HE+LP7TuWElsGguPDZUI/qSToNXqR5JuivHcJZ4LXNhRzlbk27hPwOpG6K7vedI7IWK7NAChxQqzMgcvMQudZzpt18Rapb4ZixziknoAhd7dRfbdzSYH9bWvqfNnlPH9EEGu8MZm0hzqoQoaQDkeuQmUHbEsI4Fpyhe8wW7+enlbJnMW5tHNcgxJF2G0f8uOI9+hMhmwaYNY+p5+chLoT3DZ/5U5qMFlyeoI6SS7SeVmxKRr9qT8v9I4QVvwbzN5E+2HHf8cCE7qz2p8x3tclMEUpGobqENk25fORain1w9zPZBnfuiyxaMF9qnx6x6R6+IV3kT8jgOjDxewdvfOvB0WdwgHYlpkqFZ7+Lw3R6kWToHXeR5ZoF8/qrFJ/i57koyQhdDrQY87FkMTf1ZOwoZAabcD8t0K2aDGYYlGzDx0L27WYmHOnuFaNbNxhLX9GWXyjhqi7u0qrSvJBJ8NUIMcNJNSesK6/7VXtKalS2F10CbRoekOVNqUGovbsvhD3y1vCF0Bagore1giyzei4HyS47mftkx4b1WXQFwBsIvyEIKWoRX4y4XBk6yNStYIXQ5Mjv/bcxGa5cMtTAQu5GDmHW/wpf3KhzBB0bjpu/ydnpTndl XJWB22Ck whYbyddQU9U5Lnw9waMKadj5QWJqfL7S30YUtvIfWbZltE7Ex3s7hISoydoqDaPDr/bAVYapi13Ty2OQ9i6WYUjzUWdufVH/Fg1GzutKky8FUGmll9UaPDaDbYOrglthKPDRmi6wU3DvSjXP77Q4oNMao/4oozjOJRqouqXr/geAMXGOQvyQFxd5GjDE4z19LDgeBmMSN9V+fvC0x1I14DOS4rtCXzNuE/R8QQI0eSnZcUe23DGRwgtCh/EGPt+vpO9LcL8a7Pe0fA7ZM6/oG4bb5eyHTb6TpSm3Skc55luw03T6LjBc+/083sz93MaRVUx8w6sR8wDTmN8I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.415131, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 4:55=E2=80=AFPM Rik van Riel wro= te: > +/* Wait for INVLPGB originated by this CPU to complete. */ > +static inline void tlbsync(void) > +{ > + asm volatile("tlbsync"); > +} If possible, it might be a good idea to add a cant_migrate() assertion in here, though I'm not sure if that works in terms of include hierarchy.