From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD13C3DA49 for ; Fri, 2 Aug 2024 08:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798326B0083; Fri, 2 Aug 2024 04:16:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76EF46B0085; Fri, 2 Aug 2024 04:16:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60EE66B0088; Fri, 2 Aug 2024 04:16:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3F9606B0085 for ; Fri, 2 Aug 2024 04:16:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D29D2C1197 for ; Fri, 2 Aug 2024 08:16:41 +0000 (UTC) X-FDA: 82406599002.04.175E378 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf28.hostedemail.com (Postfix) with ESMTP id 0371CC0008 for ; Fri, 2 Aug 2024 08:16:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yMplaSli; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722586594; a=rsa-sha256; cv=none; b=x6YxglFh1AJFLl15+iGGVThzy9CnTIjsJqSC9ZO2IZUSGlHoVxIIw4YsizXxXOB9ysOOjf gDu2YtLy5ktkHOcI2Rauiy0ZGxCt3D6NZ1miIi+yDFJRBnXiHZhLqvhk2wJhbGXc8etmxm aPFkIwYgQaPy0ciXI7pRB2Z5nRuyx0w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=yMplaSli; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722586594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dPqWS3uBC8uRjVmox5tLMIJZ6S7fBW9xV6DFvr9D4DE=; b=Qkmlvj1otnjNY3tkMcc+JU1W/u59PjgmSMqHXND28r74QhJVDPR7VZq9p2PNTBXdhH3kff /aShOGDvV5/ohJBMM6V93cQgV76JSYFDKZI7m5TVTBo88bGDJ5VngoLpnwNNa2RcnpDx8f s9cvPfrH7YSIZB2BKJNCPVGKnRzB6C4= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5a869e3e9dfso48499a12.0 for ; Fri, 02 Aug 2024 01:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722586598; x=1723191398; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dPqWS3uBC8uRjVmox5tLMIJZ6S7fBW9xV6DFvr9D4DE=; b=yMplaSliqeiiAa3VosfzDqlt/XGde5ufo14bgEMUzarO3QSGgnJAJ9uSLjfX8UQbDt ruxAo7l7a4oe6i5C7XZeDvGHZfthd5vTt7x17miAUdRKelud8c98jEd69dVTE3NInSDV vv0Pmk+KD5WyNdWFrzTElSuVcS9V3v/qRBVKnKGCt7L+DwZS4KPwU2pum2z9MR8xCgPT anKExgr1tjpvBUFz4C4xb0L65Ub5Sxxkp1N8PR4jm+w07MrfocseJhnEycRJw7Oq/a8E UNEVK29/8lFr3A7K7U3gNOZblOmnQeKvYj1kWqL9cpA5ljP9WR56GBvzwYTR3dqXauzF vysQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722586598; x=1723191398; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dPqWS3uBC8uRjVmox5tLMIJZ6S7fBW9xV6DFvr9D4DE=; b=CPGF9JNZctlQzIoRiQKdjDxjA0Ipl44OOGE/n7a+rICOXV2nSptHc7ntFJfpkKs85u Ml3RgSdl6/FVv+He86mcjxA367AyFEFKQWcV+a7soJti9a23WXSIAeWpp9JUJgMnZU1i YW5/Yvrpp42Op5ToIvhT14Z/cB1La7ZjLyD3TD21YSHGFGU7hIqFAIZ9wevkevgDuNfV H39bI5UI9259ZAz0LgAnfvmb5OtCM1OBxRJms9CYigXq3OtlRMqPr3SYPYufXy2dgAeg ViciuQdG0mUim38thA07DQTPaHH98qu7DU0941iMm1M74mymdcQo1xy5ZJ2XCMJY/kby FHWQ== X-Forwarded-Encrypted: i=1; AJvYcCWKjRCo2wheUMjEO1R4OxLhz7OmCJtgcUVNQqBnPZfu7+NAsLqrHF3aXl/ALfYhCLck7yPOswSk72rIQLstTQDrT4E= X-Gm-Message-State: AOJu0Yy2LabjrHzkFChQUJzNDH0s/l9h+eLlA7NgEvWPEF4fHxXJtkP+ TsX8HN+RzDpMDrUuAUOCM9ebFLVzeeHtx4gLCg6JKYRr2CovUDDll0gZ7q/YBe5GIH4fHiiPGQz JR4mZLiuCsLDR1pRbcw5i4DAXxr8zu5lXzFbg X-Google-Smtp-Source: AGHT+IGXxgaegB3n2CiisLyoBXg5cvPfq2G/dAMHQw/MYv37SPK5m5w+7bTowp3Vu8qC2pz1JRcwS5RGWPZzMwkTE8k= X-Received: by 2002:a05:6402:5206:b0:58b:90c6:c59e with SMTP id 4fb4d7f45d1cf-5b8713605e3mr87660a12.7.1722586597734; Fri, 02 Aug 2024 01:16:37 -0700 (PDT) MIME-Version: 1.0 References: <20240730-kasan-tsbrcu-v5-0-48d3cbdfccc5@google.com> <20240730-kasan-tsbrcu-v5-2-48d3cbdfccc5@google.com> In-Reply-To: From: Jann Horn Date: Fri, 2 Aug 2024 10:16:01 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] slub: Introduce CONFIG_SLUB_RCU_DEBUG To: Marco Elver Cc: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 0371CC0008 X-Rspamd-Server: rspam01 X-Stat-Signature: rbpxqw6nqz9j1gogn9yo4mkyb5nk5991 X-HE-Tag: 1722586599-640572 X-HE-Meta: U2FsdGVkX18DlHFsyfFmOAT+qBts81eLr7MPxnR6yL+3+zh0Nxjjsd5tKmdmWG9AAzRlAd3GofeDZmgwdqrPF8w5mrxkaizScD5kGXxblgFqAvP2+SYO2EKMd18g2oU8ANS22cKuxIQksY95tRn5moiG4YunvZauXkqG0N30Zz5yiTv6BmtsquNZqmY7PqtsF6bBtdYxk1Nk5QYKj5HdXmK+gz7y/FB+ajZH6YsRWET7HCJxofyUylyVkBAVeuNzhGkq8djhDfD/o1vI/SiFwlMpeVALPfbTQCh/5Xkvtx5AeUPFypaB7pb2iiO9wGtd2CeoC1KwosQqcgB3RXsGEblBoezvGlbQnhOudrzbTELtBmwo+PeQi6fOtopXkSxJ4EL/xO6IQCJ48VQ9WJUj1cQQ9bO6uWUs4tsvX3Xrma0vCQIcNF4RoyWBC+IPpjxY6Y2RfDzLqI0JhdKPZWvNVjswn0cuinkqciQQRzML9OubrplKmCzwa4qlHk5+uWuH6K3AX2cA1MU179Eofz3Ic4VzRzlorAD12uSDrqwsNYFpCNSxNea7ejUCmB72V0Kao5UMTcatbOMgATdTvRktHKc6f+78qbr5vVPFzWl96eMrRUQ105anqdG038CIO2PXDYoUnYWMIM2H80hPXmFyDAZlsw9hFFm6otGfMuP2nR8W5CpXLZhqfE3FfURCV9xK/sSNBS6L12b9/FMWVvoqO4T1OfDL7XCQJYw3WFhcPTlRdnrAtucCan8TI46RVDfO8TzxWXdPjD/3yMjKhHtB8FB8OgSsue8/x+87Zb8kzMxJy4R6KEdcl0ddXQQihzLAPqos4cHrzGkauvXZ/eLPKqqYYbHmbOcc7znafeKBX+V2CPbCP9T+phLkRixaZ8AL+9a7jM8JtPuuQTOW+8YBjO5SvNMe5i3Ix/Q5QWDVJJcSk0sjNYw9NFW1Y5iucSzA3Ch30GrAOPO72rJr4x1 iE88aeGB x5GgMVwL/RRT+YrjI/fO4l1rspUAWpBjog3Iyr1mpuSjAPk16Qriq3hxZnZQyLIdZttyQjKGx+vJ/pZ/ycq6BTv5D5tyqXtlbbCUGeaoO+GYQrTm57RvnDDdyH8jznbCKEUnwka67Gfs2g6O8GgytuBU/beNxnLVLXyo2xsHYLKO2/G2FDJSsgCp+paS7G0hgrtvvFV8nufuiajKAM4PpEoRV/NHukQr34zdwxLrd/EozfMVu74ERtsHgaj+GUM7gtMkSlQyhsioe4C+R6Lef1btW3HvsNzF43TW78LxmUIjd/hoFe75tyevYGJqsSZm/ORGdhOrmWEQDebM3sKVPYt6TTYr2N+GeEjbqBNtLbYkXbFLpbzNch13M/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 2, 2024 at 10:06=E2=80=AFAM Marco Elver wrot= e: > > On Tue, Jul 30, 2024 at 01:06PM +0200, Jann Horn wrote: > [...] > > +#ifdef CONFIG_SLUB_RCU_DEBUG > > + if ((s->flags & SLAB_TYPESAFE_BY_RCU) && !after_rcu_delay) { > > + struct rcu_delayed_free *delayed_free; > > + > > + delayed_free =3D kmalloc(sizeof(*delayed_free), GFP_NOWAI= T); > > This may well be allocated by KFENCE. > > [...] > > +#ifdef CONFIG_SLUB_RCU_DEBUG > > +static void slab_free_after_rcu_debug(struct rcu_head *rcu_head) > > +{ > > + struct rcu_delayed_free *delayed_free =3D > > + container_of(rcu_head, struct rcu_delayed_free, h= ead); > > + void *object =3D delayed_free->object; > > + struct slab *slab =3D virt_to_slab(object); > > + struct kmem_cache *s; > > + > > + if (WARN_ON(is_kfence_address(rcu_head))) > > + return; > > syzbot found this warning to trigger (because see above comment): > https://lore.kernel.org/all/00000000000052aa15061eaeb1fd@google.com/ > > Should this have been `is_kfence_address(object)`? Whoops, indeed... thanks, will fix in v6.