From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48185C74A5B for ; Wed, 29 Mar 2023 15:55:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B08D6B007B; Wed, 29 Mar 2023 11:55:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9606A6B007D; Wed, 29 Mar 2023 11:55:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84F52900002; Wed, 29 Mar 2023 11:55:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 773506B007B for ; Wed, 29 Mar 2023 11:55:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1BC0A40C55 for ; Wed, 29 Mar 2023 15:55:52 +0000 (UTC) X-FDA: 80622386544.13.0D06CCB Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf22.hostedemail.com (Postfix) with ESMTP id 4B899C0003 for ; Wed, 29 Mar 2023 15:55:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fedoraproject.org (policy=none); spf=pass (imf22.hostedemail.com: domain of jmforbes@linuxtx.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=jmforbes@linuxtx.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680105350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62ZIWkSy5tZoUHv/2BRxXjvjKExsY1hv+Zfd9ZYJQ4E=; b=VCW05ooREZDiXbCwtgBWQ5OHChkC64qxA/rZesuIYP7hdOsch7SPWV1eLXNcS0bcV3bDqQ bVvGLtioiiyuPgcTwv3kY2R24fwyfgTQzosuS3l6X1a/Djags4LLMK0qE3+/s0x2ytAINF cp0EJz4+Wrxlq1O27dXoezLkWhvIZyU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=fedoraproject.org (policy=none); spf=pass (imf22.hostedemail.com: domain of jmforbes@linuxtx.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=jmforbes@linuxtx.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680105350; a=rsa-sha256; cv=none; b=RVXfaBzHUx9RngVA26bXMhLj8w3Q6rMKDeskeLKYqBfGM+CQgkjaim8rkYPLmkHv/pONsI GtI99vTfD7tH+HU5fIxBB/3BmeJ3Vxv23RxfiPV/2EoZi/xuRkuW37iGJgRXUGgd0fWkqV mUvl4WIvyePegEL1/XDfyFYJ8MKEN8o= Received: by mail-pl1-f182.google.com with SMTP id o11so15387158ple.1 for ; Wed, 29 Mar 2023 08:55:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680105349; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=62ZIWkSy5tZoUHv/2BRxXjvjKExsY1hv+Zfd9ZYJQ4E=; b=4svPuRV9dXrsLzSmPffh6Xgtabbv9Ei8LhqnBTJsOfUEghTqSb6thlz35wVtITUp02 13Vvifv5hKq3asNOY7LP9akCPSxuWbj/rPMpnksvdE0ipkHwrAe6Na2ohAr7J9zRku7E WokxMlXCO/uORFAVs56DGDgpc4UU3izCL1jeSS5Pe+tcA4UFf8dS8hKkHi2ZfDoowDYJ 3GlQEUAa1/HnSFvwZUEaMi/V6Pw12mA5dZy3M4tYiUN5bzFPzfaHXSp5V3cQ8jsiMEzS kUdGbc7q0WSxdqwndDLkXiVxIIJyuj++IXR+CUMbga3Tod9kK8jyO4wdVEgV+fzFn69B GG4Q== X-Gm-Message-State: AAQBX9c4vdVpOv/YfXP9CAT93rTR5BqsB/J75eQIjcJpcu+Sagx4yckG 5pUJJanzjwAHh61fNFEMvq0cqJiEDCh7GG2xF/Ufkw== X-Google-Smtp-Source: AKy350aLDH5YR9t419L5OiinTR+6vLBCDmWiJH85fFWabTVqFHlXOqvkdPLNLHEa0183i9K3F9W0CuWctZ/RgFAniww= X-Received: by 2002:a17:902:c3c6:b0:1a1:b318:2776 with SMTP id j6-20020a170902c3c600b001a1b3182776mr7729184plj.0.1680105349103; Wed, 29 Mar 2023 08:55:49 -0700 (PDT) MIME-Version: 1.0 References: <20230325060828.2662773-1-rppt@kernel.org> <20230325060828.2662773-3-rppt@kernel.org> In-Reply-To: <20230325060828.2662773-3-rppt@kernel.org> From: Justin Forbes Date: Wed, 29 Mar 2023 10:55:37 -0500 Message-ID: Subject: Re: [PATCH v3 02/14] arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , John Paul Adrian Glaubitz , "Kirill A. Shutemov" , Max Filippov , Michael Ellerman , Rich Felker , Russell King , Will Deacon , Yoshinori Sato , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4B899C0003 X-Stat-Signature: 69jjo5sh8j116yy9w47h8x445uu8ojb3 X-HE-Tag: 1680105350-183435 X-HE-Meta: U2FsdGVkX1+ase8Vk2sRInn/vlktYoyjDgeGdZ64rednO9ru+8DKV2n033y/va2ckx8jpuV709m3HmFOZ4UY/5hHrreAYGvugkiw4xKt6K06khLCpQw+2+Xed3Z26kHTf1N05w1RadPeGrgIkN1bXf7E3v5qlkZLWB5uog5mNLOsTSTehiE8HmAUqPMsf/k0t0g8rOnpPhQefgU4aQ3lpqfLEfLzrfw0qM0dvTmQrr9tr0jwD1+P3YQ6KLX7BpMo31RslGC8u0//S0domrpeHh9w3lS4AZeSrLKHTjBYgm0uvg/92YBMnJjk1lQ5oN3z2wbS1h6zCqL+qZqmMZiL+34h8pwek9Mchsqj197zZ6Nw0/i1VgM82u3wou1VujkpiXQkAKKyKvZ9yfdGt/yVDwf1W3xeL1vqqX9I2AviaoilVW2Sj2N+CxXvgJJW6/kYenoSCcrrHi4xfLUh4ycfa5vGt5cMscO2JD7fer+k9Qwhng/CPKzL7SpxZDod6MjCD5UsUys2Ziq1+XQLsPpbCLwPxS/XDCb48SzgW+/p/HeBWEmfBWW8qc67AYCQTTui+IRaG2aEcGhPXpbl6ejCEYhC94to2xVGxNTm4LTI0ZE54wb8fOph9bBNbBTZ8qRdtrJPl+n02sjgBNfuAMs7Gelc7FFcvS2Ly31zXbgsM0UkfCXw1ZwiXFzf0DzhlBc5c2apMKxGhIVQbPhsKAeWdyRn2IvO8TVG00F3K1mZH68YuzMSHbBA7tLm2smxVS0BbYPQ8ckYEDrGW2oUSQYv/MI1MxNn+RzW7rOiirHQMwUvKcsRbAg2n6+Mkb4lz9QnFc06t+CrLE+WsAKmENACA+LSjCTTb39Q4KRgWOcP8TVlEo0Ai9749yPDCmOfUPBHIBCq8BABGQXOyw74M9lKYxvqUWT/o7KovXx5lBbMLH0uiwzZikX4FFJhdAVYvvSLexrLXEekRxkrZvROUhM CJ6Tuu9e kmWPHLYSNPpqJPGH4g/NAjDCPPqmgiF28Wk9hZ6wRWGf8N4hQdvYrJnKxQciT1dMgAXfI86G7RVgb9BtGb886CMmVIEkA6z0Xl2hOX5UX1pI9bGAbvI0moMG43zzCzh/2eMUzG8/ci4FTaZok15cjGvKKbEzsiigYHBBUs5A7vHy8RTxXcKmZxTFy4a6L4B1tIRrpecAXCIqp5BO/x8pnA2ajV7AIllYgTWbJZu5k0Pj5ihgRjd/fyZNnKG7qPF0y3N7KGxsH95Z0b+pgZ0hVWaMt5dwZED6JIJJemyms66+33WLE+P1uuvl+zxpaGVh2uKMCLjJQENiRwubNd3VUR9Jyk2qzC6+NmNo9bQ55VozUQ90oWuO+ScCu+8uSJ5/vnuvIE2xqBd2yisClBhrLUmU/RHucoBoaPA45Ey7NEewbOavwtwuo1pk6cHmja5yuGlamPkT1cqx9YISq6uwesywKgzUe6zdAdhgz7MEPZRGO31a8YrFE+vUk7ohdUvFab7zWvVvetnuGOWs4ZOheCbva3EfSYCnBoqcTSkY8NZpN1ZPT0yyR+NzlzST/nw48dVh0tmxH+t7hDBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 25, 2023 at 1:09=E2=80=AFAM Mike Rapoport wro= te: > > From: "Mike Rapoport (IBM)" > > It is not a good idea to change fundamental parameters of core memory > management. Having predefined ranges suggests that the values within > those ranges are sensible, but one has to *really* understand > implications of changing MAX_ORDER before actually amending it and > ranges don't help here. > > Drop ranges in definition of ARCH_FORCE_MAX_ORDER and make its prompt > visible only if EXPERT=3Dy I do not like suddenly hiding this behind EXPERT for a couple of reasons. Most importantly, it will silently change the config for users building with an old kernel config. If a user has for instance "13" set and building with 4K pages, as is the current configuration for Fedora and RHEL aarch64 builds, an oldconfig build will now set it to 10 with no indication that it is doing so. And while I think that 10 is a fine default for many aarch64 users, there are valid reasons for choosing other values. Putting this behind expert makes it much less obvious that this is an option. Justin > Acked-by: Kirill A. Shutemov > Reviewed-by: Zi Yan > Signed-off-by: Mike Rapoport (IBM) > --- > arch/arm64/Kconfig | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index e60baf7859d1..7324032af859 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1487,11 +1487,9 @@ config XEN > # 16K | 27 | 14 | 13 | 11 = | > # 64K | 29 | 16 | 13 | 13 = | > config ARCH_FORCE_MAX_ORDER > - int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES > + int "Maximum zone order" if EXPERT && (ARM64_4K_PAGES || ARM64_16= K_PAGES) > default "13" if ARM64_64K_PAGES > - range 11 13 if ARM64_16K_PAGES > default "11" if ARM64_16K_PAGES > - range 10 15 if ARM64_4K_PAGES > default "10" > help > The kernel memory allocator divides physically contiguous memor= y > -- > 2.35.1 > >