From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBD6C433FE for ; Mon, 7 Dec 2020 18:36:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F4149238EE for ; Mon, 7 Dec 2020 18:36:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F4149238EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxtx.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2ED8C8D0008; Mon, 7 Dec 2020 13:36:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 276ED8D0001; Mon, 7 Dec 2020 13:36:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13E4F8D0008; Mon, 7 Dec 2020 13:36:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id EA74E8D0001 for ; Mon, 7 Dec 2020 13:36:02 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A112B180AD811 for ; Mon, 7 Dec 2020 18:36:02 +0000 (UTC) X-FDA: 77567340564.28.crack86_10029c0273e0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 67A746C33 for ; Mon, 7 Dec 2020 18:36:02 +0000 (UTC) X-HE-Tag: crack86_10029c0273e0 X-Filterd-Recvd-Size: 5872 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Dec 2020 18:36:01 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id q75so173800wme.2 for ; Mon, 07 Dec 2020 10:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxtx.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=sZOgv3xcokPLhDzvLVyYWi3ueTGnJMpnjn9OpxMl6jw=; b=VwH5wxITOs/+VSsv82jxPZFxmVGt/GU6UgzwDBxuQ57FHPWVknF0zp0wsnDqNrBmjs pjWaHzit3H1/xLWj3PSy/nnuJZW5aC1ThTJDOQxWZr4KlGcfu55U6kQZMB57Weg8b0Nn NnVBYe4cr2v3xBo9uG+zc13dmk9egbuXkXVGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=sZOgv3xcokPLhDzvLVyYWi3ueTGnJMpnjn9OpxMl6jw=; b=Yq4t1lGaU2ZIiG8aY4WvP0ZF9TQi2wYSo5cnrsfKOi3eTgU7HOjGgNIKNT6DN/9/Dr dRmQTJOXNQKyAu4NRfwAw13ixVz4yoW03R/JfwmKWdQ3Tn7QotbsFQFhSXbhf+EOg4Bd c+A3EtFVvGCugvUsHynLeNE/Cgi31+Ots9yI/e5g/wHXFNIAqzuN6SrKRfgJYv/8qlBL UDDt8LhALRkfoMA0+Rq1bX54fxVNMx5iS32FCtpZhyBJobqmJ8BvXeTeLeNR/tRA6Jdm rJjQByH+MyBkPspYp3aW1WYk8YRlq5TtmAIEANbq/9WsVL2uQ/TU42EHNOgV/Cdd3nis NMMQ== X-Gm-Message-State: AOAM533OZbO4h5RXLe62BCv8X1HNVxrByGTGE1E04stYpEAZrjwWuAMd DuaKue1HCO7x+65mrX9uJ/FtwV6myFiw79Ed8K7Uyw== X-Google-Smtp-Source: ABdhPJyoZZ2d/7ynUl6DmcUOF/oTR6F9qO1UGyXqmo1PnkijUw4Nsp0Je5eso5tLVDQHITsoCI8kk/lppieNU/t/xCU= X-Received: by 2002:a1c:35c2:: with SMTP id c185mr186976wma.74.1607366160227; Mon, 07 Dec 2020 10:36:00 -0800 (PST) MIME-Version: 1.0 References: <1604661895-5495-1-git-send-email-alex.shi@linux.alibaba.com> <20201110115037.f6a53faec8d65782ab65d8b4@linux-foundation.org> <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> In-Reply-To: <20201207081556.pwxmhgdxayzbofpi@lion.mk-sys.cz> From: Justin Forbes Date: Mon, 7 Dec 2020 12:35:49 -0600 Message-ID: Subject: Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked To: Michal Kubecek Cc: Alex Shi , Andrew Morton , Souptick Joarder , Linux-MM , LKML , Alexei Starovoitov , Daniel Borkmann , Josef Bacik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 7, 2020 at 2:16 AM Michal Kubecek wrote: > > On Thu, Nov 12, 2020 at 08:18:57AM +0800, Alex Shi wrote: > > > > > > =E5=9C=A8 2020/11/11 =E4=B8=8A=E5=8D=883:50, Andrew Morton =E5=86=99=E9= =81=93: > > > On Tue, 10 Nov 2020 08:39:24 +0530 Souptick Joarder wrote: > > > > > >> On Fri, Nov 6, 2020 at 4:55 PM Alex Shi = wrote: > > >>> > > >>> Otherwise it cause gcc warning: > > >>> ^~~~~~~~~~~~~~~ > > >>> ../mm/filemap.c:830:14: warning: no previous prototype for > > >>> =E2=80=98__add_to_page_cache_locked=E2=80=99 [-Wmissing-prototypes] > > >>> noinline int __add_to_page_cache_locked(struct page *page, > > >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > >> > > >> Is CONFIG_DEBUG_INFO_BTF enabled in your .config ? > > > > > > hm, yes. > > > > When the config enabled, compiling looks good untill pahole tool > > used to get BTF info, but I still failed on a right version pahole > > > 1.16. Sorry. > > > > > > > >>> > > >>> Signed-off-by: Alex Shi > > >>> Cc: Andrew Morton > > >>> Cc: linux-mm@kvack.org > > >>> Cc: linux-kernel@vger.kernel.org > > >>> --- > > >>> mm/filemap.c | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/mm/filemap.c b/mm/filemap.c > > >>> index d90614f501da..249cf489f5df 100644 > > >>> --- a/mm/filemap.c > > >>> +++ b/mm/filemap.c > > >>> @@ -827,7 +827,7 @@ int replace_page_cache_page(struct page *old, s= truct page *new, gfp_t gfp_mask) > > >>> } > > >>> EXPORT_SYMBOL_GPL(replace_page_cache_page); > > >>> > > >>> -noinline int __add_to_page_cache_locked(struct page *page, > > >>> +static noinline int __add_to_page_cache_locked(struct page *page, > > >>> struct address_space *mappi= ng, > > >>> pgoff_t offset, gfp_t gfp, > > >>> void **shadowp) > > > > > > It's unclear to me whether BTF_ID() requires that the target symbol b= e > > > non-static. It doesn't actually reference the symbol: > > > > > > #define BTF_ID(prefix, name) \ > > > __BTF_ID(__ID(__BTF_ID__##prefix##__##name##__)) > > > > > > > The above usage make me thought BTF don't require the symbol, though > > the symbol still exist in vmlinux with 'static'. > > > > So any comments of this, Alexei? > > It's probably more complicated: our v5.10-rc7 builds with > CONFIG_DEBUG_INFO_BTF=3Dy fail on ppc64 and ppc64le with > > BTFIDS vmlinux > FAILED unresolved symbol __add_to_page_cache_locked > > > but succeed on x86_64, i586, aarch64 and s390x. So far I don't see why > this should depend on architecture. > Fedora is failing with rc7 on the same issue on PPC only. Justin