linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Lourenco <klourencodev@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@kernel.org
Subject: Re: [PATCH] mm: fix minor spelling mistakes in comments
Date: Sat, 20 Dec 2025 04:49:27 +0100	[thread overview]
Message-ID: <CAFveykMG1Qg=kG27y82PfH_prC5Jp=CTa_6Wttxu1cPkfzv9=A@mail.gmail.com> (raw)
In-Reply-To: <20251220022712.43244-1-sj@kernel.org>

Hi SJ,

I think you’re right — the wording there is probably not correct. If
anything, I would be more inclined to use “the next step is”
(singular), since there is only one alignment step following the start
gap adjustment.

That said, I intentionally limited this patch to clear typos. While
going through mm/, I did notice a number of grammatical issues in
comments, but I chose to ignore them to keep the scope focused cause
some typos actually made me wonder whether they were kernel-specific
terminology or just misspellings (e.g. “sinze boot”).

So I’d prefer to keep this patch dedicated to obvious typos only, and
leave grammar cleanups for future patches.

Thanks a lot for the review!

Best regards,
Kevin


Le sam. 20 déc. 2025 à 03:27, SeongJae Park <sj@kernel.org> a écrit :
>
> On Thu, 18 Dec 2025 16:09:06 +0100 klourencodev@gmail.com wrote:
>
> > From: Kevin Lourenco <klourencodev@gmail.com>
> >
> > Correct several typos in comments across files in mm/
> >
> > Signed-off-by: Kevin Lourenco <klourencodev@gmail.com>
> > ---
> [...]
> > diff --git a/mm/vma.c b/mm/vma.c
> > index fc90befd162f..bf62ac1c52ad 100644
> > --- a/mm/vma.c
> > +++ b/mm/vma.c
> > @@ -2909,8 +2909,8 @@ unsigned long unmapped_area(struct vm_unmapped_area_info *info)
> >       /*
> >        * Adjust for the gap first so it doesn't interfere with the
> >        * later alignment. The first step is the minimum needed to
> > -      * fulill the start gap, the next steps is the minimum to align
> > -      * that. It is the minimum needed to fulill both.
> > +      * fulfill the start gap, the next steps is the minimum to align
> > +      * that. It is the minimum needed to fulfill both.
>
> Nit.  s/next steps is/next steps are/ ?
>
> I'm not sure if that is really grammartically correct.  I'm just asking.  Even
> if I'm correct, I wouldn't argue you have to fix it right now.  So please feel
> free to ignore my comment.
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
>
>
> Thanks,
> SJ
>
> [...]


  reply	other threads:[~2025-12-20  3:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 15:09 klourencodev
2025-12-20  2:27 ` SeongJae Park
2025-12-20  3:49   ` Kevin Lourenco [this message]
2025-12-20  3:56     ` SeongJae Park
2025-12-21 11:17 ` David Hildenbrand (Red Hat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFveykMG1Qg=kG27y82PfH_prC5Jp=CTa_6Wttxu1cPkfzv9=A@mail.gmail.com' \
    --to=klourencodev@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox