From: Souptick Joarder <jrdr.linux@gmail.com>
To: Luben Tuikov <luben.tuikov@amd.com>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/1] drm/amdgpu: Fix missing prototype warning
Date: Tue, 10 Nov 2020 08:08:03 +0530 [thread overview]
Message-ID: <CAFqt6zbrw2Y_NFH_3LwMQn=M87hR_HaoeoX8jJ7S4w_BzU6Vbg@mail.gmail.com> (raw)
In-Reply-To: <20201109183541.665412-2-luben.tuikov@amd.com>
On Tue, Nov 10, 2020 at 12:06 AM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Fix a missing prototype warning for function
> amdgpu_info_ioctl().
Adding the original warning to commit logs might be helpful.
>
> Signed-off-by: Luben Tuikov <luben.tuikov@amd.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index ba65d4f2ab67..d27620fa8b0b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1279,6 +1279,8 @@ int amdgpu_enable_vblank_kms(struct drm_crtc *crtc);
> void amdgpu_disable_vblank_kms(struct drm_crtc *crtc);
> long amdgpu_kms_compat_ioctl(struct file *filp, unsigned int cmd,
> unsigned long arg);
> +int amdgpu_info_ioctl(struct drm_device *dev, void *data,
> + struct drm_file *filp);
>
> /*
> * functions used by amdgpu_encoder.c
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index be304df7a8c2..70a30440f84c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1529,8 +1529,6 @@ int amdgpu_file_to_fpriv(struct file *filp, struct amdgpu_fpriv **fpriv)
> return 0;
> }
>
> -int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp);
> -
> const struct drm_ioctl_desc amdgpu_ioctls_kms[] = {
> DRM_IOCTL_DEF_DRV(AMDGPU_GEM_CREATE, amdgpu_gem_create_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
> DRM_IOCTL_DEF_DRV(AMDGPU_CTX, amdgpu_ctx_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
> --
> 2.29.2.154.g7f7ebe054a
>
>
next prev parent reply other threads:[~2020-11-10 2:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 12:07 [linux-next:master 3872/4770] drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:482:5: warning: no previous prototype for 'amdgpu_info_ioctl' kernel test robot
2020-11-09 18:35 ` [PATCH 0/1] Fix missing prototype warning in amdgpu Luben Tuikov
2020-11-09 18:35 ` [PATCH 1/1] drm/amdgpu: Fix missing prototype warning Luben Tuikov
2020-11-09 19:16 ` Luben Tuikov
2020-11-09 19:18 ` Deucher, Alexander
2020-11-10 2:38 ` Souptick Joarder [this message]
2020-11-10 5:15 ` Luben Tuikov
2020-11-11 3:07 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFqt6zbrw2Y_NFH_3LwMQn=M87hR_HaoeoX8jJ7S4w_BzU6Vbg@mail.gmail.com' \
--to=jrdr.linux@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=luben.tuikov@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox