From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA9AC433F5 for ; Sat, 19 Feb 2022 20:37:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 179E96B0071; Sat, 19 Feb 2022 15:37:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 129B26B0073; Sat, 19 Feb 2022 15:37:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0C0D6B0074; Sat, 19 Feb 2022 15:37:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id E2B0E6B0071 for ; Sat, 19 Feb 2022 15:37:15 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 88B498249980 for ; Sat, 19 Feb 2022 20:37:15 +0000 (UTC) X-FDA: 79160689230.31.54BD839 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf12.hostedemail.com (Postfix) with ESMTP id 28C0140002 for ; Sat, 19 Feb 2022 20:37:14 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id q9so8158157vsg.2 for ; Sat, 19 Feb 2022 12:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vm51P2LO4NJ6NzvoomB2MjD9fMCciErum40stRnmssY=; b=VWNCVf2JUq8KTUz7fGHgv62SbfCeI1b76AqzJYHnmaRUbSfvPZtAUOpavKPAfIxdEn VKPjR5DvW8LjlotY4JOtmb8yem233KG5fNZSAoMHjZLj5vUvi4E3yOQPfO3/asep2FQe PXNHKxF8WtW5ipZR0w+3f8AIWE9Np24+QOjCOiXRtcVGGsMqfh3Bf1pJTXCrazzmD5Jo 6m4RpowMLTh20p5R+tzll/PYqzffqXjXZwe/9cc8tIB2Oyn3JAto6H0Dd2+TnQUcj2mu 0bsXrICYiGcfO8xD9/dnliG0LTnLogy8cRFGh3W0N+WranXkxfwQivBTII0jrGZdXT+y LDHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vm51P2LO4NJ6NzvoomB2MjD9fMCciErum40stRnmssY=; b=1VA7scFa95QjvUnmLYnJ1UFI/EeTWCMd+pEI4mFsRw3NaqcfRa/mfJWo/4DH69Q92J NG1Yq8zYchOT4U7IpWg6FrME61T18mQ3dho017VxNEstPhmBDFHJbdEc5y2BOP/ST/i5 IaRbRP1cqrkbahtrGJy++E4Py66I8P6xhXZ4J0BqWE2wtkYgu5Yr3hde3MLX6x29CX2z jsAfrMzXqY9kGeOj89igr58wYuI+s6UmkaOzDl7a7OjvQ0FUEl3yoj3nZltI/JZPHCDv fEGIi8CTFY2Zv+tL4iKwV56PI6l4GkJAq2IWew85OwB86+rYvnP/COQ8uvY75cqIVENk PqkQ== X-Gm-Message-State: AOAM531fB31WmofwVEl0tHNo0bgFsb1y1AohVx6ynyt0usY5zEIlXhwt SjI5I+9l0HS06Wl9BFAQi/JopVg9Rw4ESydRBkk= X-Google-Smtp-Source: ABdhPJz67l72/4r6Gi97prQaRTiRllJqT5eNhtLmtDAa3+QElwqWGqW4KC60YEQInj4r7ezcHLXcOyP3LPINQ4RJi7E= X-Received: by 2002:a67:d38f:0:b0:31a:808b:7f1 with SMTP id b15-20020a67d38f000000b0031a808b07f1mr5439421vsj.56.1645303033914; Sat, 19 Feb 2022 12:37:13 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-10-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-10-linmiaohe@huawei.com> From: Souptick Joarder Date: Sun, 20 Feb 2022 02:07:01 +0530 Message-ID: Subject: Re: [PATCH 9/9] mm/z3fold: remove unneeded return value of z3fold_compact_page() To: Miaohe Lin Cc: Andrew Morton , vitaly.wool@konsulko.com, Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 28C0140002 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VWNCVf2J; spf=pass (imf12.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: riope79ecdauhurpf5cdjrdhdruosj49 X-HE-Tag: 1645303034-534544 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 2:56 PM Miaohe Lin wrote: > > Remove the unneeded return value of z3fold_compact_page() as it's > never checked. > > Signed-off-by: Miaohe Lin Acked-by: Souptick Joarder > --- > mm/z3fold.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index 83b5a3514427..db41b4227ec7 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -746,18 +746,18 @@ static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr) > > #define BIG_CHUNK_GAP 3 > /* Has to be called with lock held */ > -static int z3fold_compact_page(struct z3fold_header *zhdr) > +static void z3fold_compact_page(struct z3fold_header *zhdr) > { > struct page *page = virt_to_page(zhdr); > > if (test_bit(MIDDLE_CHUNK_MAPPED, &page->private)) > - return 0; /* can't move middle chunk, it's used */ > + return; /* can't move middle chunk, it's used */ > > if (unlikely(PageIsolated(page))) > - return 0; > + return; > > if (zhdr->middle_chunks == 0) > - return 0; /* nothing to compact */ > + return; /* nothing to compact */ > > if (zhdr->first_chunks == 0 && zhdr->last_chunks == 0) { > /* move to the beginning */ > @@ -766,7 +766,7 @@ static int z3fold_compact_page(struct z3fold_header *zhdr) > zhdr->middle_chunks = 0; > zhdr->start_middle = 0; > zhdr->first_num++; > - return 1; > + return; > } > > /* > @@ -778,7 +778,6 @@ static int z3fold_compact_page(struct z3fold_header *zhdr) > BIG_CHUNK_GAP) { > mchunk_memmove(zhdr, zhdr->first_chunks + ZHDR_CHUNKS); > zhdr->start_middle = zhdr->first_chunks + ZHDR_CHUNKS; > - return 1; > } else if (zhdr->last_chunks != 0 && zhdr->first_chunks == 0 && > TOTAL_CHUNKS - (zhdr->last_chunks + zhdr->start_middle > + zhdr->middle_chunks) >= > @@ -787,10 +786,7 @@ static int z3fold_compact_page(struct z3fold_header *zhdr) > zhdr->middle_chunks; > mchunk_memmove(zhdr, new_start); > zhdr->start_middle = new_start; > - return 1; > } > - > - return 0; > } > > static void do_compact_page(struct z3fold_header *zhdr, bool locked) > -- > 2.23.0 > >