From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4913DC433E0 for ; Mon, 21 Dec 2020 19:36:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D1F9E22BE9 for ; Mon, 21 Dec 2020 19:36:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F9E22BE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C6FD6B005C; Mon, 21 Dec 2020 14:36:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 175E26B005D; Mon, 21 Dec 2020 14:36:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03FE86B0068; Mon, 21 Dec 2020 14:36:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id D9C306B005C for ; Mon, 21 Dec 2020 14:36:22 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A5C541F1B for ; Mon, 21 Dec 2020 19:36:22 +0000 (UTC) X-FDA: 77618295804.19.night90_460655227459 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 82DC41AD1B9 for ; Mon, 21 Dec 2020 19:36:22 +0000 (UTC) X-HE-Tag: night90_460655227459 X-Filterd-Recvd-Size: 3981 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 19:36:22 +0000 (UTC) Received: by mail-vk1-f173.google.com with SMTP id e27so1525887vkn.2 for ; Mon, 21 Dec 2020 11:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZZyncXwiQja2UVR2OiYE7gDJBGuNncgyLsAmPzZ+/c=; b=narslOk3Hvt1RGe1zhxswCbmFdemKIq+FjDkobRs9/VXBSyC/AGRgfWNpjsxSkR5r1 oR4AJeSoxTEmamC0ao9bd5IZvgbscauG+A/E1+kCVgrbVBM3Jbw9/mk8A0rlgmZt32ur PjCYHGOXuQ0I667rjRyoz5PhqsLI9sq3LcXLJO9hmN6OpUS4X6MQBJXgHFJT0+DIiCpQ Vq7yVMVNH+75Zua8fVt6YyWqQDANSF7XBhSn1AF+EOwQL+TpGVYJMm8DBlBEvqyroy4E XV2AbfJGDXx1VGpECcBLSF8XE4k0eT9/JdZs8DfB7FFDvjdTqPLGSrSFBx2veWzvPqM5 dWAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZZyncXwiQja2UVR2OiYE7gDJBGuNncgyLsAmPzZ+/c=; b=ozHYX2uXc5NSdwWDL9x3TBuB/pOp9Ed7iXJzUSHeU87gqAx4J5y6rPKay1leXdku4C 45bFXU8cBsjK+GRr9pjtUitrc7eRXa6dExnp1s4HMepgMQ7AsV9FcEhuCFx9KdJdZGLq JRjt6V+olWN2oplHpLJEXmRt22/+pbUdyPE4rM2Swa89X1vwjqkWTG7VDyyFVdTd5Sgh n7HSpvUAo2iJzchJdXinh96jRMEuG/cE2Q3vzyYm9DYVN85F/I0rnYBRFpL6j4zAlu9K djEUEdGsGIPCzlCLFhf52yqEBCBSIrWagaFUHYM1rBiezHluMaRDuy4+aotWmQO5bqDh n/Qw== X-Gm-Message-State: AOAM530iEN7dEm+aXjFvngstQmpDxBsWJ5zxX2yhTED+HbVzrBIRs/r4 A3itwcbrvYZo34ot2tubhEpompNgdtEeSkocGg0= X-Google-Smtp-Source: ABdhPJyrBEPum1+Ha9e9MR1wjXKQOrZ3ZlZ+t43OuSExGikpJ4e9J5AL9z/TcGa4LoqHca85LwSbFzl0qcZ3/g7+1hQ= X-Received: by 2002:a1f:5cc2:: with SMTP id q185mr14390621vkb.23.1608579381365; Mon, 21 Dec 2020 11:36:21 -0800 (PST) MIME-Version: 1.0 References: <20201217020311.491799-1-yuxiangyang4@huawei.com> <20201217022306.GB15600@casper.infradead.org> <20201218095756.18d259ea243e434a8a90403a@linux-foundation.org> In-Reply-To: <20201218095756.18d259ea243e434a8a90403a@linux-foundation.org> From: Souptick Joarder Date: Tue, 22 Dec 2020 01:06:14 +0530 Message-ID: Subject: Re: [PATCH] mm/filemap: Fix warning: no previous prototype To: Andrew Morton Cc: Matthew Wilcox , Xiangyang Yu , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 18, 2020 at 11:27 PM Andrew Morton wrote: > > On Fri, 18 Dec 2020 09:39:30 +0530 Souptick Joarder wrote: > > > On Thu, Dec 17, 2020 at 7:53 AM Matthew Wilcox wrote: > > > > > > On Thu, Dec 17, 2020 at 10:03:11AM +0800, Xiangyang Yu wrote: > > > > Fixed the warning when building with warnings enabled (W=1), > > > > This function is only used in filemap.c, so mark this function > > > > with 'static'. > > > > > > Good grief, no. Look at the git history before proposing a patch. > > > > revert "mm/filemap: add static for function __add_to_page_cache_locked" > > Revert commit 3351b16af494 ("mm/filemap: add static for function > > __add_to_page_cache_locked") due to incompatibility with > > ALLOW_ERROR_INJECTION which result in build errors. > > > > How about we add a prototype for __add_to_page_cache_locked() to squash > the warning, along with a comment explaining what's going on? > I think adding a prototype will silence some kernel test robot warning and future efforts to make it static. I will post a patch.