From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0E0C433F5 for ; Tue, 25 Jan 2022 03:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 375476B0088; Mon, 24 Jan 2022 22:09:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 325086B0089; Mon, 24 Jan 2022 22:09:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ED326B008A; Mon, 24 Jan 2022 22:09:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 0FD0F6B0088 for ; Mon, 24 Jan 2022 22:09:24 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C813795288 for ; Tue, 25 Jan 2022 03:09:23 +0000 (UTC) X-FDA: 79067328606.18.93EF597 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 789B84001E for ; Tue, 25 Jan 2022 03:09:23 +0000 (UTC) Received: by mail-ua1-f54.google.com with SMTP id b16so34911292uaq.4 for ; Mon, 24 Jan 2022 19:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7THWnDwu6SHLsgQWF0gnHbecnS5BR6fB6kU5rm9DZ+Q=; b=a1v6fl3Zt3097PKf35FiEm1Gjm8t4SKgKunYAfwggN+XTff2PLnMoQU/XFEJ9bUrgc 6Ksp5ckz46OOqVDPbbkWqQjbmPPDCVmAleyp11F0CU3ilj2fiRn4VQX3e/AtPUhJt3N7 KyhLjObNOx0JY3aAxW+2kQbK/Yf9sdjAinSH9pNv8wxwlGkV0rzc0DrlvXfzWdIpZemT NEuyKn1k9981+6RzV9QhV8EzLwNAyCxuLsoLvbhVt5Iayyfd+lVAt8NjLYZDxOlKBgr3 z3lDuCJJNKl0JK987e05DUpbBE5x7K40A8Dyopv0ugcTQwEGEe5LGvXFl3QH3DtT+tHr vruA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7THWnDwu6SHLsgQWF0gnHbecnS5BR6fB6kU5rm9DZ+Q=; b=S7bC4r29cFKSJ1Yl1ELzizP3s7e8Swpqf/EtT1eN/TOg68d++zeIqF7XNS0kgyNm1t g9FAHBK/W3kXgrep+ZRAw0vR1AlcKg76lTQ8awAbObFMucjap+Tyi2ByYpHHcgvWjOWD gZ501axvK0IY6QEGK0ZfkoylxVuu4idB1Ya91+fIPUoH342p9OTWXgTJB9HCW/CHWehj tdZnZd1VYX75rxF70gALKkvKPZOENoz65FI0cyG9RiRD+bPsmbAqYpAy9mlvEA6F1EzV LXoAMwNeLEhUWn60SBi2BrxshLIkKfF3vDfbQ+ZOFVTq8mq4GWpbAhBgyJq56uRG34DK 730w== X-Gm-Message-State: AOAM533W95x4v8IlBzNhWDviHbzXld3KQdeLZLWWtsz2AhMPC3MvWeWV lXgLmsls/cXkoDxfGVyKkNLp0z+wO5KB8960qKs= X-Google-Smtp-Source: ABdhPJzv+lWmRqD+06XtnDKVKFRx0Ezva/u1eh6A4bO/RLSfGP55YG0ch4ngCGCy8BFO+/xxydYv8V0bN5U9gyN0kEI= X-Received: by 2002:a67:d315:: with SMTP id a21mr6785670vsj.51.1643080162787; Mon, 24 Jan 2022 19:09:22 -0800 (PST) MIME-Version: 1.0 References: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com> In-Reply-To: From: Souptick Joarder Date: Tue, 25 Jan 2022 08:39:10 +0530 Message-ID: Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation To: David Rientjes Cc: Baolin Wang , sj@kernel.org, Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: scajo36wgntpikbyziwthyurs5kiyph7 X-Rspam-User: nil Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=a1v6fl3Z; spf=pass (imf11.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 789B84001E X-HE-Tag: 1643080163-570602 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 11:50 PM David Rientjes wrote: > > On Mon, 17 Jan 2022, Baolin Wang wrote: > > > It will never get a NULL page by pte_page() as discussed in thread [1], > > thus remove the redundant page validation to fix below Smatch static > > checker warning. > > > > mm/damon/vaddr.c:405 damon_hugetlb_mkold() > > warn: 'page' can't be NULL. > > > > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/ > > > > Reported-by: Dan Carpenter > > Signed-off-by: Baolin Wang > > Reviewed-by: SeongJae Park > > Acked-by: David Rientjes Acked-by: Souptick Joarder >