From: Souptick Joarder <jrdr.linux@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
sj@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Linux-MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation
Date: Tue, 25 Jan 2022 08:39:10 +0530 [thread overview]
Message-ID: <CAFqt6zbN9M5wFUzLAkH3k3Wrk1Byyyh-JTDqhb5AKca0jS5vBg@mail.gmail.com> (raw)
In-Reply-To: <bdc7a556-b826-8d82-91b-8664f8a655e@google.com>
On Mon, Jan 24, 2022 at 11:50 PM David Rientjes <rientjes@google.com> wrote:
>
> On Mon, 17 Jan 2022, Baolin Wang wrote:
>
> > It will never get a NULL page by pte_page() as discussed in thread [1],
> > thus remove the redundant page validation to fix below Smatch static
> > checker warning.
> >
> > mm/damon/vaddr.c:405 damon_hugetlb_mkold()
> > warn: 'page' can't be NULL.
> >
> > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> > Reviewed-by: SeongJae Park <sj@kernel.org>
>
> Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
>
next prev parent reply other threads:[~2022-01-25 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 2:34 Baolin Wang
2022-01-24 18:20 ` David Rientjes
2022-01-25 3:09 ` Souptick Joarder [this message]
2022-01-25 3:43 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqt6zbN9M5wFUzLAkH3k3Wrk1Byyyh-JTDqhb5AKca0jS5vBg@mail.gmail.com \
--to=jrdr.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox