From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CF3C433E0 for ; Thu, 28 Jan 2021 04:09:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8628664D92 for ; Thu, 28 Jan 2021 04:09:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8628664D92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E06FD6B006C; Wed, 27 Jan 2021 23:09:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7FF6B0070; Wed, 27 Jan 2021 23:09:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF5B06B0071; Wed, 27 Jan 2021 23:09:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id BB3766B006C for ; Wed, 27 Jan 2021 23:09:24 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 88DD88249980 for ; Thu, 28 Jan 2021 04:09:24 +0000 (UTC) X-FDA: 77753854248.01.dime74_4d075802759c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 6CBF11004C78D for ; Thu, 28 Jan 2021 04:09:24 +0000 (UTC) X-HE-Tag: dime74_4d075802759c X-Filterd-Recvd-Size: 3641 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 04:09:23 +0000 (UTC) Received: by mail-vs1-f42.google.com with SMTP id m13so2357997vsr.2 for ; Wed, 27 Jan 2021 20:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H9MUD5ruToPJqcaQT9i3J5EUNJUwJYyNBf08RkrLGzQ=; b=LtrEJkyZ2bH7sOg90RwDLsEkdUsWXJ7GpwTJXXMKjoo3iK449aasTa3iQpMb8z0UCi ppSNwK52U9ozCwQ0bqHfDIcSrpQhbrb1DdFZkskQoJagoTTjTpfQ3aJ6dslTpemXkeiO XNGxZhNTbY6nY/OOh5VuSGbso1ea7R346Eprny1MU0nxDn9uctlJmoHfMdnW60VS7E2x QJZaroOC6ghvcvYXcF8sQsWadG7SUqkTXnUO8jix4lYIBAxI+LMWAjFBpX+gRq4Ydpfz bCygHLH3/Fc2+eoPnwBXwfAtXFMlHZ07v02+BhUovhbZ/uzZBzeKiwaHo01Sl90CEjNG xiBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H9MUD5ruToPJqcaQT9i3J5EUNJUwJYyNBf08RkrLGzQ=; b=egHF389AYwTuIdMQMYzI9+Kqvzc0JPq9VouaXHHFM7r69W+Nf8hvLi37/lT+o7I+O/ 2sCjrfg5xVxNjJ98O7xKtGPNMr1F7boPznRSgnnb4+NzMwE9yfk156ifRGTKYw2xDFRh 3QJTXjx3N8vluBsanJZxtkfqpz9MyMVbOzeWaWcFmDiAir3woTta6H2CUdwZ2pF/HCE/ zUw2LyZ3JQGa0dbwXgqOJMJAAm+d7NNiTqalcsqYYeZdPGM/VDKVsig6F/Idw65ti+UC g8GYYutyWVyNI3rcb+HqfokMiV054LlBV4tNJ8507Wt7XsmsHCFe7ZNPjdpRsTlE+IEb xsIg== X-Gm-Message-State: AOAM530/lEJ65/vI0G750/KbJeRATfI1dvWvy+RqDiwvs3rZ9NEbebm4 0FU2fWt7I76wtXTEE3o9S9QCC6v9VUj4QYHa4os= X-Google-Smtp-Source: ABdhPJybr1xrM+DRAyBdKSleCwSUs7C4+49p9pQ9JLgpjrMUp51DIVflLKAFz8H++F7zOmrhFrNPmIOnfV3m083klnc= X-Received: by 2002:a67:99c6:: with SMTP id b189mr10414169vse.58.1611806963507; Wed, 27 Jan 2021 20:09:23 -0800 (PST) MIME-Version: 1.0 References: <1611223030-58346-1-git-send-email-tiantao6@hisilicon.com> In-Reply-To: <1611223030-58346-1-git-send-email-tiantao6@hisilicon.com> From: Souptick Joarder Date: Thu, 28 Jan 2021 09:39:11 +0530 Message-ID: Subject: Re: [PATCH] mm/zswap: fix variable 'entry' is uninitialized when used To: Tian Tao Cc: vitaly.wool@konsulko.com, Seth Jennings , Barry Song , Dan Streetman , Andrew Morton , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 21, 2021 at 3:27 PM Tian Tao wrote: > > the entry has not been initialized when it is used, so allocate PAGE_SIZE Can you please add the original error msg in change logs ? > > Signed-off-by: Tian Tao > Reported-by: kernel test robot > --- > mm/zswap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 6e0bb61..4b7b6ad 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -944,7 +944,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle) > > if (!zpool_can_sleep_mapped(pool)) { > > - tmp = kmalloc(entry->length, GFP_ATOMIC); > + tmp = kmalloc(PAGE_SIZE, GFP_ATOMIC); > if (!tmp) > return -ENOMEM; > } > -- > 2.7.4 > >