From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC00EC433E0 for ; Sat, 16 Jan 2021 09:39:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6089C222B3 for ; Sat, 16 Jan 2021 09:39:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6089C222B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBF288D0206; Sat, 16 Jan 2021 04:39:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D6F558D0200; Sat, 16 Jan 2021 04:39:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85568D0206; Sat, 16 Jan 2021 04:39:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id B4F8E8D0200 for ; Sat, 16 Jan 2021 04:39:52 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 787BD1730853 for ; Sat, 16 Jan 2021 09:39:52 +0000 (UTC) X-FDA: 77711141424.02.spy65_0810ae127536 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 54B8110097AA1 for ; Sat, 16 Jan 2021 09:39:52 +0000 (UTC) X-HE-Tag: spy65_0810ae127536 X-Filterd-Recvd-Size: 4087 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Jan 2021 09:39:51 +0000 (UTC) Received: by mail-ua1-f49.google.com with SMTP id d3so1267951uap.4 for ; Sat, 16 Jan 2021 01:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7FhgwJtmgN313McuIkkUvMe9rIKF3WqHs+98mKu1M60=; b=BCip+nt0PZQdqiTwQgUWU8yAnfYeCrnfctn2e2b8qBuuakOxgQsiVlSyPKS3jEpO1R yvwWZ+41My/TvkfH7HzpFXOVCqNOxfC7blN+MTjW1bG/OITJb2lxL9rSJuRkl3ZimDEk ubT+P4zy6GeXgMIu9/Wh8F2v5fWlLtNNepMwXlYoZhNVCliU8BkKeXNAqWdHZCHlrM5X jFGehWaEHOfw4V6FnBR0Xth7iZ18rsAUqSmNfF/jIScJmtAA/ZDyhRnw4Qqpl2mJ7+e3 JFMqGsSXPKVBxlQoIO1L+Krq9Zh8SghboW7P5jNoZmRl1TvDljKGRFrt6XYsTrEYhIW5 rYiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7FhgwJtmgN313McuIkkUvMe9rIKF3WqHs+98mKu1M60=; b=g77BodwFv/jFiY2590zzYq4an+CfiUvn1I/loPZLC/HuP0GMspog563+3W38j6WWlG pQFu9Rvk/2ZpT0+loFwZXpeD1XjjqBN9gps7RjlmdR5IUPtYphQtStxin1CByV5xbdzs dYT/HQoapDAmgeiwctt8oguX7mwpZjFfRh6ZlCtzj2gKGp5XHaNtH35zTrONO9jc/AeX TQ0ckP/Ib8vCMUFj6a5yiIk3j+DTjlLPBEcm15+SJRhremYnwYy8ywXWR5vedQ/xPGnA nrv38uNdD2qUSr0B91B9ISpvms1IqrG3hQbraf+3TjSqLK/ULdfiFs+aNbtjW1doLKBJ N1Hg== X-Gm-Message-State: AOAM533P5zt2V6XFdqYyMWypV4KRtbRiyZZzWxlsUohDGBS6XgNMjcSn b0w+T0co+4ls4a2eBuYdlsMfANyQUXsLvCKDxKQ= X-Google-Smtp-Source: ABdhPJyPgu7/crtRCyOE8M7c7XAIyE0W0AkwTszmGQeeeqgi0JmPfHR7F7jFyj8PriBUBe3FmRIy0OrvxZT7CZ/2Rks= X-Received: by 2002:ab0:127:: with SMTP id 36mr12484134uak.118.1610789991317; Sat, 16 Jan 2021 01:39:51 -0800 (PST) MIME-Version: 1.0 References: <20210116092644.42697-1-linmiaohe@huawei.com> In-Reply-To: <20210116092644.42697-1-linmiaohe@huawei.com> From: Souptick Joarder Date: Sat, 16 Jan 2021 15:09:41 +0530 Message-ID: Subject: Re: [PATCH] hugetlbfs: remove meaningless variable avoid_reserve To: Miaohe Lin Cc: Mike Kravetz , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 16, 2021 at 2:57 PM Miaohe Lin wrote: > > The variable avoid_reserve is meaningless because we never changed its > value and just passed it to alloc_huge_page(). So remove it to make code > more clear that in hugetlbfs_fallocate, we never avoid reserve when alloc > hugepage yet. > > Signed-off-by: Miaohe Lin Acked-by: Souptick Joarder > --- > fs/hugetlbfs/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 88751e35e69d..23ad6ed8b75f 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -680,7 +680,6 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > */ > struct page *page; > unsigned long addr; > - int avoid_reserve = 0; > > cond_resched(); > > @@ -717,7 +716,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > } > > /* Allocate page and add to page cache */ > - page = alloc_huge_page(&pseudo_vma, addr, avoid_reserve); > + page = alloc_huge_page(&pseudo_vma, addr, 0); > hugetlb_drop_vma_policy(&pseudo_vma); > if (IS_ERR(page)) { > mutex_unlock(&hugetlb_fault_mutex_table[hash]); > -- > 2.19.1 > >