From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23369C433E0 for ; Wed, 23 Dec 2020 07:43:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7893822482 for ; Wed, 23 Dec 2020 07:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7893822482 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7D1A66B0074; Wed, 23 Dec 2020 02:43:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 759748D0015; Wed, 23 Dec 2020 02:43:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 621B86B0083; Wed, 23 Dec 2020 02:43:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id 494CB6B0074 for ; Wed, 23 Dec 2020 02:43:55 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 03265181AEF1D for ; Wed, 23 Dec 2020 07:43:55 +0000 (UTC) X-FDA: 77623758030.12.stew39_5a16ceb27466 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id D378C1802B145 for ; Wed, 23 Dec 2020 07:43:54 +0000 (UTC) X-HE-Tag: stew39_5a16ceb27466 X-Filterd-Recvd-Size: 4206 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 07:43:54 +0000 (UTC) Received: by mail-vs1-f46.google.com with SMTP id u7so8358644vsg.11 for ; Tue, 22 Dec 2020 23:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gy1WZCYgCHRTW1fplBU5lLZ8CwoK6whBcRI9AclXwGg=; b=Es79/tDv+/TXelmjBAajJR/epXTztnkcTnqgZ16xi5nuVeJ7E9oIyvWy9MDL9sv2Gb vD8r8OL9aMXCDnNrWxFuBdQQjzJpvo/mYz/q1JImYRmYfIPx/i8m75ystudLY4c7Zb2N M6Qm5jmfq2RGgMzcPvEeo4UNVwdmGC96mSIkHXAXZxOgvhSrj+gXzSG0NuG5b5f28D3u iw5SZ/1GHuq9svSP6VELtZZDyHfN7/Kp8nda7PMctM19Mi+SN8gxkIS24o6PcrDnB7PX DJAX/jRH8xbQcU17hsJRj3gcb0zeOFW71vwgytcio29SkNUJoWwmsIYhNYHEukmjmTmn hqbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gy1WZCYgCHRTW1fplBU5lLZ8CwoK6whBcRI9AclXwGg=; b=YoNwXyYDhDvFxDwbN6x0N5GhSs2vFBRI3vrphUpv0Q3unHjjkFz5J99OhuKD4qd33o U+g285XTaL1xbkPyDsT6Mg/r9wmaXqC4bqq7CvLJSnoNkYrGHaPfC5yw4omJ+4eqFe7l O5xRQbg3HQ4NpHaTaoTmNBIIMPTqF1vIKav+Tcjez6JOIAehy6QfDWK36x7ubrZNKCBd cT0n0P67Z9sVIomu5uBGJn7dDA0VIjygbske5TYtEhDiB7N40Syo2DOztAzNuXmMitvO eDzpHqDtR0Dqya3/k1nNit/jECsOmaMF7J6V2bwO69p3l0HyMIEBU0PdAccksNnoVuWL uz2g== X-Gm-Message-State: AOAM5300ofaMqxYXszAQCu9X4SHUI0yJKtYN7dkTe4k3HMznJApUOCUF OQpsplfM3GbU0+dP+CFUAPzM88H2idHGhAYZUr4PpbTJ6+k= X-Google-Smtp-Source: ABdhPJxo2XBgdrws6k+9wEFV2ipGQCTSUSIjVBoX+mmwHTNGRr3WJMUOyKTLP6Q4iCfH0A4vWHOkM5kqjh/lH9WpedE= X-Received: by 2002:a05:6102:a07:: with SMTP id t7mr17677167vsa.30.1608709433615; Tue, 22 Dec 2020 23:43:53 -0800 (PST) MIME-Version: 1.0 References: <1608707589-6067-1-git-send-email-yanghui.def@gmail.com> In-Reply-To: <1608707589-6067-1-git-send-email-yanghui.def@gmail.com> From: Souptick Joarder Date: Wed, 23 Dec 2020 13:13:41 +0530 Message-ID: Subject: Re: [PATCH] mm:remove useless code To: hui yang Cc: Andrew Morton , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 12:43 PM hui yang wrote: > > From: YangHui > > remove useless code Change logs need to be more descriptive. > > Signed-off-by: YangHui > --- > mm/vmscan.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 257cba7..af1d176 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1234,8 +1234,8 @@ static unsigned int shrink_page_list(struct list_head *page_list, > * Try to allocate it some swap space here. > * Lazyfree page could be freed directly > */ > - if (PageAnon(page) && PageSwapBacked(page)) { > - if (!PageSwapCache(page)) { > + if (PageAnon(page) && PageSwapBacked(page) && > + !PageSwapCache(page)) { This will change the original behaviour of the code. > if (!(sc->gfp_mask & __GFP_IO)) > goto keep_locked; > if (PageTransHuge(page)) { > @@ -1270,7 +1270,6 @@ static unsigned int shrink_page_list(struct list_head *page_list, > > /* Adding to swap updated mapping */ > mapping = page_mapping(page); > - } > } else if (unlikely(PageTransHuge(page))) { > /* Split file THP */ > if (split_huge_page_to_list(page, page_list)) > -- > 2.7.4 > >