From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E408AC433DF for ; Tue, 26 May 2020 10:29:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F30F207CB for ; Tue, 26 May 2020 10:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n7zciMlS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F30F207CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F28B8009C; Tue, 26 May 2020 06:29:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A2C080061; Tue, 26 May 2020 06:29:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0918F8009C; Tue, 26 May 2020 06:29:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id E309980061 for ; Tue, 26 May 2020 06:29:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A24972C1E for ; Tue, 26 May 2020 10:29:52 +0000 (UTC) X-FDA: 76858499424.28.drink18_9065af43d6258 X-HE-Tag: drink18_9065af43d6258 X-Filterd-Recvd-Size: 7637 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 10:29:52 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id z13so14153688ljn.7 for ; Tue, 26 May 2020 03:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C17FM7zfHQ0g98Gec6oNVi7D+Q2Y1g6U9re2DPGSx3A=; b=n7zciMlS+Shx8E1gyRxUwYdyLy9yDiMH6342nQRAW0saRLV/8rnaupFSs0Lg8PnVtT e4yfRTfbT23/AiYuipQhzvt2jWzBUplDWivYuDKVfzgLFyywT8ygHaHJ1xyIRgE/uDvf DHNaF4PlkSNMnGSRcOofYWyhKZl3GaG+4QQH2o1lDi5CrpwVHq9yGbser3BA9lNKZnQt ATbwExoRp8TnVsag9j0eAVDW8KHLVN3fy+kuMO8XqrZlZUT83FSt2/OAUj3/RnJQMBFb RXjZGfyGO+PpW4OfraEeZ5Ue6HkH/eM3964Lj1l8knMLedS94K/+CGlWtE0TwPKJ2zQE CZBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C17FM7zfHQ0g98Gec6oNVi7D+Q2Y1g6U9re2DPGSx3A=; b=Y33jo7R/2V7SuZiSjsDv40P1SMd36Czw3R4JaN9RRA2qaqXbgiz4Fjd7vWZcbglxt4 DVgwkAfAJgyqPjAgORBgpsKQYhjA23jp61qCKlN/H51NvjvE2XQKLVdJBNa+KsdFzd3Y tQ4tnaUqCzZhP3J17sTxsrENySTtMSvwZ0hxoQhbSozg+NxfQ7rpBYHr6cxmm0PkfO09 zk9qoCOw4BsvppiJCnO7v1vGsECyTO3oYR1nD3Yke9MxR2HFeU1OBRc7IQq59pka6Nfd 8+Y7MqXbAtgZCV9oLPfYaMfcySF088JEL10j+YpHaQRgztf0HbrvFUZIDh/Eiv9Aq3P+ tQTQ== X-Gm-Message-State: AOAM530QZqnNU1jqyZUgeDovPGBmzzS2Ealo9B3modvx9iOgB+iK7vWX H2XLa0x9nnCp5Wtk9EFMvEScWPhOYhMvTgUzufc= X-Google-Smtp-Source: ABdhPJzB8WZp+opke9KXwEhpl7yy8WsS+MMNRScSuw8OaKmfYc2e7dRbUp0Xo5ZMGMORZIcqz4TVIMcfSF/6Z9YTdlM= X-Received: by 2002:a2e:8191:: with SMTP id e17mr308580ljg.68.1590488990512; Tue, 26 May 2020 03:29:50 -0700 (PDT) MIME-Version: 1.0 References: <20200526081338.179532-1-vkuznets@redhat.com> <16496017-14a9-146a-c257-35f9d3c2d3cb@nvidia.com> In-Reply-To: <16496017-14a9-146a-c257-35f9d3c2d3cb@nvidia.com> From: Souptick Joarder Date: Tue, 26 May 2020 15:59:37 +0530 Message-ID: Subject: Re: [PATCH] mm/gup: correct pin_user_pages.rst location To: John Hubbard Cc: Vitaly Kuznetsov , Linux-MM , linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Claudio Imbrenda Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 26, 2020 at 1:49 PM John Hubbard wrote: > > On 2020-05-26 01:13, Vitaly Kuznetsov wrote: > > pin_user_pages.rst lives in Documentation/core-api/, not Documentation/vm/, > > adjust all links accordingly. > > > > Fixes: 3faa52c03f44 ("mm/gup: track FOLL_PIN pages") > > Fixes: eddb1c228f79 ("mm/gup: introduce pin_user_pages*() and FOLL_PIN") > > Signed-off-by: Vitaly Kuznetsov > > --- > > include/linux/mm.h | 4 ++-- > > mm/gup.c | 18 +++++++++--------- > > 2 files changed, 11 insertions(+), 11 deletions(-) > > Hi Vitaly, > > Thanks for the fix, > > Reviewed-by: John Hubbard > > (+CC Souptick, who fixed a similar set of links, maybe in a different > file, as I recall.) Changes related to mm/gup.c are merged in linux-next which means we need to take care of only *mm.h* part. rebase on top of linux-next should work fine. With that, Acked-by: Souptick Joarder > NVIDIA > > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 5a323422d783..1f2850465f59 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -1219,7 +1219,7 @@ void unpin_user_pages(struct page **pages, unsigned long npages); > > * used to track the pincount (instead using of the GUP_PIN_COUNTING_BIAS > > * scheme). > > * > > - * For more information, please see Documentation/vm/pin_user_pages.rst. > > + * For more information, please see Documentation/core-api/pin_user_pages.rst. > > * > > * @page: pointer to page to be queried. > > * @Return: True, if it is likely that the page has been "dma-pinned". > > @@ -2834,7 +2834,7 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address, > > * releasing pages: get_user_pages*() pages must be released via put_page(), > > * while pin_user_pages*() pages must be released via unpin_user_page(). > > * > > - * Please see Documentation/vm/pin_user_pages.rst for more information. > > + * Please see Documentation/core-api/pin_user_pages.rst for more information. > > */ > > > > static inline int vm_fault_to_errno(vm_fault_t vm_fault, int foll_flags) > > diff --git a/mm/gup.c b/mm/gup.c > > index 87a6a59fe667..87a3a4b400f9 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -2845,10 +2845,10 @@ EXPORT_SYMBOL_GPL(get_user_pages_fast); > > * the arguments here are identical. > > * > > * FOLL_PIN means that the pages must be released via unpin_user_page(). Please > > - * see Documentation/vm/pin_user_pages.rst for further details. > > + * see Documentation/core-api/pin_user_pages.rst for further details. > > * > > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It > > - * is NOT intended for Case 2 (RDMA: long-term pins). > > + * This is intended for Case 1 in Documentation/core-api/pin_user_pages.rst > > + * (DIO). It is NOT intended for Case 2 (RDMA: long-term pins). > > */ > > int pin_user_pages_fast(unsigned long start, int nr_pages, > > unsigned int gup_flags, struct page **pages) > > @@ -2885,10 +2885,10 @@ EXPORT_SYMBOL_GPL(pin_user_pages_fast); > > * the arguments here are identical. > > * > > * FOLL_PIN means that the pages must be released via unpin_user_page(). Please > > - * see Documentation/vm/pin_user_pages.rst for details. > > + * see Documentation/core-api/pin_user_pages.rst for details. > > * > > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It > > - * is NOT intended for Case 2 (RDMA: long-term pins). > > + * This is intended for Case 1 in Documentation/core-api/pin_user_pages.rst > > + * (DIO). It is NOT intended for Case 2 (RDMA: long-term pins). > > */ > > long pin_user_pages_remote(struct task_struct *tsk, struct mm_struct *mm, > > unsigned long start, unsigned long nr_pages, > > @@ -2921,10 +2921,10 @@ EXPORT_SYMBOL(pin_user_pages_remote); > > * FOLL_PIN is set. > > * > > * FOLL_PIN means that the pages must be released via unpin_user_page(). Please > > - * see Documentation/vm/pin_user_pages.rst for details. > > + * see Documentation/core-api/pin_user_pages.rst for details. > > * > > - * This is intended for Case 1 (DIO) in Documentation/vm/pin_user_pages.rst. It > > - * is NOT intended for Case 2 (RDMA: long-term pins). > > + * This is intended for Case 1 in Documentation/core-api/pin_user_pages.rst > > + * (DIO). It is NOT intended for Case 2 (RDMA: long-term pins). > > */ > > long pin_user_pages(unsigned long start, unsigned long nr_pages, > > unsigned int gup_flags, struct page **pages, > > >