From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0855C433E0 for ; Tue, 22 Dec 2020 15:18:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5845B22B2B for ; Tue, 22 Dec 2020 15:18:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5845B22B2B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5C418D0012; Tue, 22 Dec 2020 10:18:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0C8B6B00A6; Tue, 22 Dec 2020 10:18:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 921E28D0012; Tue, 22 Dec 2020 10:18:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7A5E46B00A5 for ; Tue, 22 Dec 2020 10:18:09 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 438CA181AF5C3 for ; Tue, 22 Dec 2020 15:18:09 +0000 (UTC) X-FDA: 77621273898.03.wave46_0f10c7527461 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 20AA028A4E8 for ; Tue, 22 Dec 2020 15:18:09 +0000 (UTC) X-HE-Tag: wave46_0f10c7527461 X-Filterd-Recvd-Size: 4018 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 22 Dec 2020 15:18:08 +0000 (UTC) Received: by mail-ua1-f49.google.com with SMTP id f16so4448844uav.12 for ; Tue, 22 Dec 2020 07:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WNvEywE4N7FwZmVI1O0uZ1CSue5bVfV4HsVUoFw6O1k=; b=tU997nhp1DAk8WDgVSQidbAlIcd81As9uEyx6upqk/DIAlddNALgnswvNtu7bvf+Er GK4+nxPgtY1/UJIFKfsHLhCEFZqM8htZ/nlGdPIKMI3PGI6j4o8dZzTqET5t+DdLSip+ oB5jVwM5+cWFyOwbDCyXCtNedqJ+Ol3y+57yL9TJGu9cxNtmWtIyy44MiCanfrkDtueS pvsSgfh1SwRoAOvijK/0qa45jY0dOznTCXMItKSpLoRzOI5G8JH7pNnL34TdflIswph5 m7ytV2G6ijG3XjuCcA/w4/D5XbU0Udp2QhiM9Jx9BW2OGlWPJl5DDR9bQf+pTrTAG139 EYHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WNvEywE4N7FwZmVI1O0uZ1CSue5bVfV4HsVUoFw6O1k=; b=hP07Nhkl4KyMdt1l2jUqdt5ZOcgAB+Fhg2DeYslmn40mL3BV0q9fhBxameHQWTQiPs P15wXnfasUghaj5k/ZrfIJMpkRch5z38twtRfamR+bfei/TASoa0B7k0uAEULT/3WcBc NIR5aidk2I/WZ9oYxgSVcUJPr7bEd69O6ivAEX52TRWgMXSXksIvBz5bUY+kGdrOm4Be Lf9IXx4bgIK32MC4idEK4r92Yp34n+xtPhgHMMBDZy8Z/Pf6kkfZAk2ILOS6CxVpzvEb 8ESOpiFA9huHPFDDJStp1wIi1IbSLf5Xq0BoMv10yWBD/ZzltbiLoWl4Fmk64GNIjTVZ 8gTw== X-Gm-Message-State: AOAM533eLeDgb4NE6PR7euveMl+ZUd6ZL1dpvSnFzgBVYDSniokvWhJ/ Xh4Ehc+ge1dJ0DcV4yMjtopVSDXRDRcLD4RjP6Q= X-Google-Smtp-Source: ABdhPJxvdka2CI7hyYHWtvX8AN1FAHBX2wMt8FNrpRzIDAVUo3DNtaC5VrWaErbMv03D8ZDL9yFFr8zY7fapvCgz4NA= X-Received: by 2002:ab0:2e8e:: with SMTP id f14mr15643141uaa.22.1608650287878; Tue, 22 Dec 2020 07:18:07 -0800 (PST) MIME-Version: 1.0 References: <20201222103249.30683-1-adrianhuang0701@gmail.com> In-Reply-To: <20201222103249.30683-1-adrianhuang0701@gmail.com> From: Souptick Joarder Date: Tue, 22 Dec 2020 20:47:56 +0530 Message-ID: Subject: Re: [PATCH 1/1] mm: mmap: Remove unnecessary local variable To: Adrian Huang Cc: Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org, Adrian Huang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 22, 2020 at 4:03 PM Adrian Huang wrote: > > From: Adrian Huang > > The local variable 'retval' is assigned just for once in __do_sys_brk(), > and the function returns the value of the local variable right after > the assignment. Remove unnecessary assignment and local variable > declaration. > > Signed-off-by: Adrian Huang Acked-by: Souptick Joarder > --- > mm/mmap.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index dc7206032387..482c0c0bbe06 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long > struct list_head *uf); > SYSCALL_DEFINE1(brk, unsigned long, brk) > { > - unsigned long retval; > unsigned long newbrk, oldbrk, origbrk; > struct mm_struct *mm = current->mm; > struct vm_area_struct *next; > @@ -281,9 +280,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk) > return brk; > > out: > - retval = origbrk; > mmap_write_unlock(mm); > - return retval; > + return origbrk; > } > > static inline unsigned long vma_compute_gap(struct vm_area_struct *vma) > -- > 2.17.1 > >