From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E4D5C00144 for ; Sat, 30 Jul 2022 02:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C1306B0071; Fri, 29 Jul 2022 22:29:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649BF6B0072; Fri, 29 Jul 2022 22:29:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C38D8E0001; Fri, 29 Jul 2022 22:29:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 37C196B0071 for ; Fri, 29 Jul 2022 22:29:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C7E9C020F for ; Sat, 30 Jul 2022 02:29:04 +0000 (UTC) X-FDA: 79742183808.15.1AD7CE1 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf17.hostedemail.com (Postfix) with ESMTP id AA41E40013 for ; Sat, 30 Jul 2022 02:29:03 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id r186so5300254pgr.2 for ; Fri, 29 Jul 2022 19:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=D8nh9rddTt6L51ZbXbpeHlTuyQZ7jqEF8HhjNBeFMSo=; b=J43v+iWR0ZHURNM5y3qQ9FP2G7QJNDpPf+aTs6ZD5S9y8mHMgOypQMzYFc0Q60UcBv ZMC8qtqJU5OzrBazvtEopY1MQn7M8ObvQ7OmnhUn0CIuxKqWG0gn3VOXjuf/lDi6xY2q VA1iZ9+pH7x4TgO3Seb5dJOnScqq3q4TPvz5q/auQuaPgUn/IlUImL9SalBfeVeF8O1C J2V7W1eWFdtMuLCEq5K7Th3qvr1Blq3uEMolkTtRzAHA51xgkm6GEBJGSAcg6qOwzP1A Cis90QOF/yXt918e3Vjgv+EEZ9UVn9jZzx3aQnmpOcYhPoS0OYFQYldqefXf6JGqQsCR MxXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=D8nh9rddTt6L51ZbXbpeHlTuyQZ7jqEF8HhjNBeFMSo=; b=aRPgbT8W0EcUdTziaAurcGXDk7A1bvDhRfzHSbYAKOvRTFlAjRzjMIAR8+hEqSSJw1 GB2wQ5wH4xXDuWZ8pXSTIIGrB6oDxWdbxZ3nSuN5fThAqnDv0g1p/7wqAz/91DcNgjxh 8HU64P2S6HT5uq58FiQn6AXlAovmRI6IE4yYSDmKqxkX4fKLFWHmA2x422b9rJ93Md4r p2WIM9DkAs3vIDFpeqN+q2gob5UGekhd9m2HWEB9ffTrvidMQxhcG0+aYIPAYYMcwUSn jJvkth58/+YSc8rY7bjDZJuTUxaq3K7bIi4ND5rQqekQuo891IgcL754E8EloqUmPHr1 OeDA== X-Gm-Message-State: AJIora+Jgro/1n3qODL0XofJrPxS8syayzH2ZUA1+en0D5h95AdrtgAk Ag4XWw8vU0j18/lBnxFY/mptWmEajO2+aHN1BSE= X-Google-Smtp-Source: AGRyM1tzLXxBW/OHVmYkOjGUsDptBkCU4EJjbbLqSOXbjCorpcuSYRiTQJ0HQMksd5CP+xzgTdzj4nQVog9zCTCTaqE= X-Received: by 2002:a65:49c8:0:b0:41a:eb36:d1a7 with SMTP id t8-20020a6549c8000000b0041aeb36d1a7mr5103118pgs.66.1659148142504; Fri, 29 Jul 2022 19:29:02 -0700 (PDT) MIME-Version: 1.0 References: <20220729004920.8544-1-quic_yingangl@quicinc.com> In-Reply-To: <20220729004920.8544-1-quic_yingangl@quicinc.com> From: Souptick Joarder Date: Sat, 30 Jul 2022 07:58:49 +0530 Message-ID: Subject: Re: [PATCH v3] mm/page_owner.c: add llseek for page_owner To: Kassey Li Cc: Andrew Morton , vbabka@kernel.org, Minchan Kim , Joonsoo Kim , linux-kernel@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659148143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D8nh9rddTt6L51ZbXbpeHlTuyQZ7jqEF8HhjNBeFMSo=; b=ZTXkeWfeXk60dkMfdBbBuXyntD2GfIVP644LjW3A6LH6jNW/DyyIf8gd25pOrborCTLXD1 aVd5nFKLTEkZxzwCdqSiTDYgHL8X6rIGRSqVjnZQUOZoqt2+dMyxqCCAItgoozEwPhyc5r K4wfWrnzPKB/ZLhqWrrwnGY38uniemU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J43v+iWR; spf=pass (imf17.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659148143; a=rsa-sha256; cv=none; b=0AtDndsT5nbhl9V0LoGHEVS+8B2QShZtlQL3NNw23fCcAaHbzT9uSrAKUq4v8upE1h0DdS jtBxhmmDB9UrJCQelJezKH4r7pzX4WdIlsjKnAANtncdeasQuT+2TLHimHKMk562h2Gh9y wRM1u8K76R0wZVtncJVdrZSekAwhB70= X-Stat-Signature: kwa3jxiurc5pi484e1s63s5ozppouc51 X-Rspamd-Queue-Id: AA41E40013 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J43v+iWR; spf=pass (imf17.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-HE-Tag: 1659148143-664430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 29, 2022 at 6:19 AM Kassey Li wrote: > > There is usage to dump a given cma region page_owner > instead of all page's. > > This change allows to specify a ppos as start_pfn > by fseek. > > Any invalid ppos will be skipped, so it did not > broken the origin dump feature. > I think a Suggested-by tag needs to be added. > Signed-off-by: Kassey Li > --- > mm/page_owner.c | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index e4c6f3f1695b..231b1877af99 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -497,8 +497,8 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) > return -EINVAL; > > page = NULL; > - pfn = min_low_pfn + *ppos; > > + pfn = *ppos; > /* Find a valid PFN or the start of a MAX_ORDER_NR_PAGES area */ > while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0) > pfn++; > @@ -561,7 +561,7 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) > continue; > > /* Record the next PFN to read in the file offset */ > - *ppos = (pfn - min_low_pfn) + 1; > + *ppos = pfn + 1; > > return print_page_owner(buf, count, pfn, page, > page_owner, handle); > @@ -570,6 +570,21 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) > return 0; > } > > +static loff_t llseek_page_owner(struct file *file, loff_t offset, int whence) > +{ > + loff_t retval = 0; > + switch (whence) { > + case SEEK_CUR: > + case SEEK_SET: > + file->f_pos = offset; > + break; > + default: > + retval = -ENXIO; > + } > + > + return retval; > +} > + > static void init_pages_in_zone(pg_data_t *pgdat, struct zone *zone) > { > unsigned long pfn = zone->zone_start_pfn; > @@ -660,6 +675,7 @@ static void init_early_allocated_pages(void) > > static const struct file_operations proc_page_owner_operations = { > .read = read_page_owner, > + .llseek = llseek_page_owner, > }; > > static int __init pageowner_init(void) > -- > 2.17.1 > >