From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4DFC433E6 for ; Fri, 12 Mar 2021 22:14:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 850C864E57 for ; Fri, 12 Mar 2021 22:14:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 850C864E57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B1A86B006C; Fri, 12 Mar 2021 17:14:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A296B006E; Fri, 12 Mar 2021 17:14:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF5B46B0070; Fri, 12 Mar 2021 17:14:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id BF64A6B006C for ; Fri, 12 Mar 2021 17:14:30 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5124A1838E516 for ; Fri, 12 Mar 2021 22:14:30 +0000 (UTC) X-FDA: 77912627100.20.3A8B3C3 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by imf21.hostedemail.com (Postfix) with ESMTP id CC9EDE1D717C for ; Fri, 12 Mar 2021 21:38:58 +0000 (UTC) Received: by mail-vk1-f176.google.com with SMTP id p8so1562690vki.7 for ; Fri, 12 Mar 2021 13:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GnGHO2xe4p5gPjThaffOlin7Ck/22ngkIviZ9J9hyAs=; b=HkuNkBmw6ocbrtzCFkblBlyKOA63iVidiydknt0e7/qSkW04sVpT1IjcJX1MOjbY73 3U9PoinMy+8kC9nWTkHlPyDhOdb4KhQR/oHbpcvfBPZOnxO3NuhX8AhSva5GdIzQ9yD2 zJG4VYORZ1BwyWs8rekegHnRwcYXwZ8r5HZbHO7DCIrYHzBqepZ9lF7s2RagijgVeACt bZQFZpwVcYO0CJzfNh6pbUYB51FoCVRm6n0kN7TlrY2TcxXf5omR0mcnLYBK5vikkuk3 QkwGSCppPP53j9Fq/veBfuZgl14Y0CXHV66vy4CF6h8NlMj9q3pUw9wZE/e7W1KLU6Vg UryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GnGHO2xe4p5gPjThaffOlin7Ck/22ngkIviZ9J9hyAs=; b=l7ucEvqEdnqueu+09qTrwrcmyC+fJOQIw6XQarNOwXHF8EPwi4xgU7cPH9RZ8V2Nj4 ESzWG0PnFPwmvIxKCOWWTfIDuJV9XtHzYWStri7A7E8W1JLvNqCytBLixo4ZVHwh6ESk Em9QEGRfvVk8c4BLLgjb9n5qDm4dTpnCM9LmQoriKxL3nLVQgVuTn6LeJxnmYwy3Hkmk +d1flLyMXA0EyFLNnQNLG63LuV4D/Dw7kqnKMM1l2FBa3HqKKHitjsas08YnpTeG09o4 QGRwnPywDqJ3Yd4Ed36qObotsY9IAyI2sGUGuZx3KYP4B6jzCrizbDoeSEl6SS8+QVu3 Fe/Q== X-Gm-Message-State: AOAM532ShY3rKYYh8FV/YGiTtjuWU1UT7WsDzQTbZUk+SrhQr0nr6Ugs 3Ikil1P2FQdKGvM9ekoFQk1fQAGoFuJnU4eG+DQ= X-Google-Smtp-Source: ABdhPJxOtLh6ASe/7mtNbPaBDzp0QXBXLnyX/zQLC8PPMsqOt0pbCQ1Yk2Yf8+pzKxwySU48Ot26J51iTzQDMuBHjlQ= X-Received: by 2002:a1f:a68d:: with SMTP id p135mr291283vke.6.1615585139943; Fri, 12 Mar 2021 13:38:59 -0800 (PST) MIME-Version: 1.0 References: <202103101520.lf0gwiFM-lkp@intel.com> In-Reply-To: <202103101520.lf0gwiFM-lkp@intel.com> From: Souptick Joarder Date: Sat, 13 Mar 2021 03:08:47 +0530 Message-ID: Subject: Re: [linux-next:master 2778/3213] arch/x86/mm/init_64.c:1583:6: error: implicit declaration of function 'vmemmap_use_new_sub_pmd' To: kernel test robot Cc: Oscar Salvador , kbuild-all@lists.01.org, Linux Memory Management List , David Hildenbrand , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: c38aypg6tqinctynzzgsbd8hbbtworbw X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CC9EDE1D717C Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-vk1-f176.google.com; client-ip=209.85.221.176 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615585138-470151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 1:02 PM kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b01d57bfdc41c8f635b08b8a5af8a31217d46936 > commit: 3c583493688a0a1276f6a8c0bbc5ece84e77f086 [2778/3213] x86/vmemmap: handle unpopulated sub-pmd ranges > config: x86_64-randconfig-s022-20210309 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-262-g5e674421-dirty > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3c583493688a0a1276f6a8c0bbc5ece84e77f086 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 3c583493688a0a1276f6a8c0bbc5ece84e77f086 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > arch/x86/mm/init_64.c: In function 'vmemmap_populate_hugepages': > >> arch/x86/mm/init_64.c:1583:6: error: implicit declaration of function 'vmemmap_use_new_sub_pmd' [-Werror=implicit-function-declaration] > 1583 | vmemmap_use_new_sub_pmd(addr, next); > | ^~~~~~~~~~~~~~~~~~~~~~~ > >> arch/x86/mm/init_64.c:1589:4: error: implicit declaration of function 'vmemmap_use_sub_pmd' [-Werror=implicit-function-declaration] > 1589 | vmemmap_use_sub_pmd(addr, next); > | ^~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > But both the functions are defined in arch/x86/mm/init_64.c. > vim +/vmemmap_use_new_sub_pmd +1583 arch/x86/mm/init_64.c > > 1530 > 1531 static int __meminit vmemmap_populate_hugepages(unsigned long start, > 1532 unsigned long end, int node, struct vmem_altmap *altmap) > 1533 { > 1534 unsigned long addr; > 1535 unsigned long next; > 1536 pgd_t *pgd; > 1537 p4d_t *p4d; > 1538 pud_t *pud; > 1539 pmd_t *pmd; > 1540 > 1541 for (addr = start; addr < end; addr = next) { > 1542 next = pmd_addr_end(addr, end); > 1543 > 1544 pgd = vmemmap_pgd_populate(addr, node); > 1545 if (!pgd) > 1546 return -ENOMEM; > 1547 > 1548 p4d = vmemmap_p4d_populate(pgd, addr, node); > 1549 if (!p4d) > 1550 return -ENOMEM; > 1551 > 1552 pud = vmemmap_pud_populate(p4d, addr, node); > 1553 if (!pud) > 1554 return -ENOMEM; > 1555 > 1556 pmd = pmd_offset(pud, addr); > 1557 if (pmd_none(*pmd)) { > 1558 void *p; > 1559 > 1560 p = vmemmap_alloc_block_buf(PMD_SIZE, node, altmap); > 1561 if (p) { > 1562 pte_t entry; > 1563 > 1564 entry = pfn_pte(__pa(p) >> PAGE_SHIFT, > 1565 PAGE_KERNEL_LARGE); > 1566 set_pmd(pmd, __pmd(pte_val(entry))); > 1567 > 1568 /* check to see if we have contiguous blocks */ > 1569 if (p_end != p || node_start != node) { > 1570 if (p_start) > 1571 pr_debug(" [%lx-%lx] PMD -> [%p-%p] on node %d\n", > 1572 addr_start, addr_end-1, p_start, p_end-1, node_start); > 1573 addr_start = addr; > 1574 node_start = node; > 1575 p_start = p; > 1576 } > 1577 > 1578 addr_end = addr + PMD_SIZE; > 1579 p_end = p + PMD_SIZE; > 1580 > 1581 if (!IS_ALIGNED(addr, PMD_SIZE) || > 1582 !IS_ALIGNED(next, PMD_SIZE)) > > 1583 vmemmap_use_new_sub_pmd(addr, next); > 1584 continue; > 1585 } else if (altmap) > 1586 return -ENOMEM; /* no fallback */ > 1587 } else if (pmd_large(*pmd)) { > 1588 vmemmap_verify((pte_t *)pmd, node, addr, next); > > 1589 vmemmap_use_sub_pmd(addr, next); > 1590 continue; > 1591 } > 1592 if (vmemmap_populate_basepages(addr, next, node, NULL)) > 1593 return -ENOMEM; > 1594 } > 1595 return 0; > 1596 } > 1597 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org