From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by kanga.kvack.org (Postfix) with ESMTP id 29DDE6B000D for ; Tue, 23 Oct 2018 08:33:57 -0400 (EDT) Received: by mail-lj1-f197.google.com with SMTP id z16-v6so489341ljh.5 for ; Tue, 23 Oct 2018 05:33:57 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id q22-v6sor388137lfa.49.2018.10.23.05.33.55 for (Google Transport Security); Tue, 23 Oct 2018 05:33:55 -0700 (PDT) MIME-Version: 1.0 References: <20181023122435.GB20085@bombadil.infradead.org> In-Reply-To: <20181023122435.GB20085@bombadil.infradead.org> From: Souptick Joarder Date: Tue, 23 Oct 2018 18:03:42 +0530 Message-ID: Subject: Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Miguel Ojeda , Russell King - ARM Linux , robin@protonic.nl, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, Heiko Stuebner , airlied@linux.ie, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, Andrew Morton , Marek Szyprowski , Kees Cook , treding@nvidia.com, Michal Hocko , Dan Williams , "Kirill A. Shutemov" , Mark Rutland , aryabinin@virtuozzo.com, Dmitry Vyukov , Kate Stewart , tchibo@google.com, riel@redhat.com, Minchan Kim , Peter Zijlstra , "Huang, Ying" , ak@linux.intel.com, rppt@linux.vnet.ibm.com, linux@dominikbrodowski.net, Arnd Bergmann , cpandya@codeaurora.org, hannes@cmpxchg.org, Joe Perches , mcgrof@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Linux-MM On Tue, Oct 23, 2018 at 5:54 PM Matthew Wilcox wrote: > > On Tue, Oct 23, 2018 at 05:44:32PM +0530, Souptick Joarder wrote: > > On Sat, Oct 6, 2018 at 4:19 PM Miguel Ojeda > > wrote: > > > > > > On Sat, Oct 6, 2018 at 7:11 AM Souptick Joarder wrote: > > > > > > > > On Fri, Oct 5, 2018 at 11:39 PM Miguel Ojeda > > > > wrote: > > > > > They are not supposed to be "steps". You did it with 70+ commits (!!) > > > > > over the course of several months. Why a tree wasn't created, stuff > > > > > developed there, and when done, submitted it for review? > > > > > > > > Because we already have a plan for entire vm_fault_t migration and > > > > the * instruction * was to send one patch per driver. > > > > > > The instruction? > > > > Sorry for the delayed response. > > Instruction from Matthew Wilcox who is supervising the entire vm_fault_t > > migration work :-) > > Hang on. That was for the initial vm_fault_t conversion in which each > step was clearly an improvement. What you're looking at now is far > from that. Ok. But my understanding was, the approach of vm_insert_range comes into discussion as part of converting vm_insert_page into vmf_insert_page which is still part of original vm_fault_t conversion discussion. No ?