From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f69.google.com (mail-lf0-f69.google.com [209.85.215.69]) by kanga.kvack.org (Postfix) with ESMTP id 6825D6B0003 for ; Sat, 21 Apr 2018 17:54:40 -0400 (EDT) Received: by mail-lf0-f69.google.com with SMTP id s204-v6so2211662lfs.4 for ; Sat, 21 Apr 2018 14:54:40 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id s143-v6sor2202195lfs.79.2018.04.21.14.54.38 for (Google Transport Security); Sat, 21 Apr 2018 14:54:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180421213401.GF14610@bombadil.infradead.org> References: <20180421210529.GA27238@jordon-HP-15-Notebook-PC> <20180421213401.GF14610@bombadil.infradead.org> From: Souptick Joarder Date: Sun, 22 Apr 2018 03:24:37 +0530 Message-ID: Subject: Re: [PATCH v3] fs: dax: Adding new return type vm_fault_t Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Al Viro , mawilcox@microsoft.com, Ross Zwisler , Andrew Morton , Dan Williams , Michal Hocko , jack@suse.cz, kirill.shutemov@linux.intel.com, linux-fsdevel , Linux-MM , linux-kernel@vger.kernel.org On Sun, Apr 22, 2018 at 3:04 AM, Matthew Wilcox wrote: > On Sun, Apr 22, 2018 at 02:35:29AM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an errno. Once all instances >> are converted, vm_fault_t will become a distinct type. >> >> commit 1c8f422059ae ("mm: change return type to vm_fault_t") >> >> There was an existing bug inside dax_load_hole() >> if vm_insert_mixed had failed to allocate a page table, >> we'd return VM_FAULT_NOPAGE instead of VM_FAULT_OOM. >> With new vmf_insert_mixed() this issue is addressed. >> >> vm_insert_mixed_mkwrite has inefficiency when it returns >> an error value, driver has to convert it to vm_fault_t >> type. With new vmf_insert_mixed_mkwrite() this limitation >> will be addressed. >> >> As new function vmf_insert_mixed_mkwrite() only called >> from fs/dax.c, so keeping both the changes in a single >> patch. >> >> Signed-off-by: Souptick Joarder > > Reviewed-by: Matthew Wilcox > > There's a couple of minor things which could be tidied up, but not worth > doing them as a revision to this patch. Which tree this patch will go through ? mm or fsdevel ?