From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92127C64E7A for ; Tue, 1 Dec 2020 15:33:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0B9B2080A for ; Tue, 1 Dec 2020 15:33:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CtjoYBA0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B9B2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C58B66B0036; Tue, 1 Dec 2020 10:33:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C0C178D0002; Tue, 1 Dec 2020 10:33:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF96C8D0001; Tue, 1 Dec 2020 10:33:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 966976B0036 for ; Tue, 1 Dec 2020 10:33:51 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 567EE181AC9C6 for ; Tue, 1 Dec 2020 15:33:51 +0000 (UTC) X-FDA: 77545108662.08.beds22_0001534273ab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 261631819E623 for ; Tue, 1 Dec 2020 15:33:51 +0000 (UTC) X-HE-Tag: beds22_0001534273ab X-Filterd-Recvd-Size: 6147 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Dec 2020 15:33:50 +0000 (UTC) Received: by mail-vk1-f174.google.com with SMTP id s6so527287vka.3 for ; Tue, 01 Dec 2020 07:33:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1WdbUv0lYoTasZTXqN2gzfeJOoYPDA/D6fgmsqfBgoM=; b=CtjoYBA0/+96LbIcs9GlQLeU1AR8FA63+fK5u11hlNPMAdQv1OTc1LRyif23AHtdIc YbiZBPohYZ6v4aCIeIZmh5QDSntg829s9endGY7gRJ5GpB2JUtSAS5jLb+/nuxlYdlWr rBx3wM/Q4ofmKkNvIt5wAoaQfXudaB9hCPI76S0T1uq8kqHCeXQ3jk6rWg39A0WSYK49 iAIGnsRTYEz5Apy8tqCg7PBgJeEfoyZKgq8aD6KYjg0bkx8+Pol7rsOVvpVqnQokw06J klODfmBWNrQRtQD1gYM4UKY1qD/o4FvBiT7eNH0JLnw9iMKfa/NaNBAQSEsWIhDW6zNN wcmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1WdbUv0lYoTasZTXqN2gzfeJOoYPDA/D6fgmsqfBgoM=; b=pUSba/60L4eINL32F+sIopJNDjV0qqZJDXexDLM1OO9VGMqYz5foaQEftRpkLOcU91 WwOuo8dNP/CebgozeLzf/zsRnl+zWALUKpbGSrTcOgFCDcJbhtkDIpBBC8+ThNwUwyax lxvePozVJzJY7XkbkSJL9FrpHA4xanoNGbJjepr98tSWV5SWVg9Lr9VL6RCj0K3x8DVl Iz2DLVKZZi+kidH8BxoeNexKmX7gU1L+NaI8i4VJnFq1Ido2QalJjr0+g+yKToYyUhV6 iNBNWlZ4S1+TOhnOb4a96cRu5oBvVce/vhnJWfG2C7546pMZuIBNLEpjhP+WUsiFgSWP Ycaw== X-Gm-Message-State: AOAM532/teoy5k17vNDxdfkxeXzmlhUhaoX2AFLaOUKIMnb9gvxdmf9x zynvowiLEKop3GM3F3zJrqqejMJxjiAxsp5r3uA= X-Google-Smtp-Source: ABdhPJwxwOIJHvCx+ETTY9SiZLMHzMV+YU8H/mWJ9hLb3IN9UzqWqN7J/+tOd0vVmn19eW5xi1aslX/P0xf6OvXhYtQ= X-Received: by 2002:a1f:9a81:: with SMTP id c123mr2812692vke.23.1606836829966; Tue, 01 Dec 2020 07:33:49 -0800 (PST) MIME-Version: 1.0 References: <202012011752.GjKoR8tI-lkp@intel.com> In-Reply-To: <202012011752.GjKoR8tI-lkp@intel.com> From: Souptick Joarder Date: Tue, 1 Dec 2020 21:03:38 +0530 Message-ID: Subject: Re: [linux-next:master 1048/9613] drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:115:37: warning: unused variable 'amdgpu_fw_attestation_debugfs_ops' To: kernel test robot Cc: John Clements , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Alex Deucher , Hawking Zhang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 1, 2020 at 2:36 PM kernel test robot wrote: > > Hi John, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: c6b11acc5f85b6e11d128fad8e0b7b223aa7e33f > commit: 19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e [1048/9613] drm/amdgpu: added support for psp fw attestation > config: arm64-randconfig-r006-20201201 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:6: warning: no previous prototype for function 'amdgpu_fw_attestation_debugfs_init' [-Wmissing-prototypes] > void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev) > ^ > drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev) > ^ > static A prototype needs to be added. I think, entire amdgpu_fw_attestation_debugfs_init() and future callers can be written under CONFIG_DEBUG_FS. > >> drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:115:37: warning: unused variable 'amdgpu_fw_attestation_debugfs_ops' [-Wunused-const-variable] > static const struct file_operations amdgpu_fw_attestation_debugfs_ops = { > ^ > drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:122:12: warning: unused function 'amdgpu_is_fw_attestation_supported' [-Wunused-function] > static int amdgpu_is_fw_attestation_supported(struct amdgpu_device *adev) > ^ > 3 warnings generated. CONFIG_DEBUG_FS is not enabled which triggers these warnings. > > vim +/amdgpu_fw_attestation_debugfs_ops +115 drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c > > 114 > > 115 static const struct file_operations amdgpu_fw_attestation_debugfs_ops = { > 116 .owner = THIS_MODULE, > 117 .read = amdgpu_fw_attestation_debugfs_read, > 118 .write = NULL, > 119 .llseek = default_llseek > 120 }; > 121 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org