Re: [linux-next:master 1048/9613] drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:115:37: warning: unused variable 'amdgpu_fw_attestation_debugfs_ops'

[Souptick Joarder <jrdr.linux@gmail.com>]

On Tue, Dec 1, 2020 at 2:36 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi John,
>
> FYI, the error/warning still remains.
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   c6b11acc5f85b6e11d128fad8e0b7b223aa7e33f
> commit: 19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e [1048/9613] drm/amdgpu: added support for psp fw attestation
> config: arm64-randconfig-r006-20201201 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm64 cross compiling tool for clang build
>         # apt-get install binutils-aarch64-linux-gnu
>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e
>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>         git fetch --no-tags linux-next master
>         git checkout 19ae333001b375bbc7d1ff9eaa9cbb0a72fff65e
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>    drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:6: warning: no previous prototype for function 'amdgpu_fw_attestation_debugfs_init' [-Wmissing-prototypes]
>    void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
>         ^
>    drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:130:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
>    ^
>    static

A prototype needs to be added. I think, entire
amdgpu_fw_attestation_debugfs_init() and future callers can be written
under CONFIG_DEBUG_FS.

> >> drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:115:37: warning: unused variable 'amdgpu_fw_attestation_debugfs_ops' [-Wunused-const-variable]
>    static const struct file_operations amdgpu_fw_attestation_debugfs_ops = {
>                                        ^
>    drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:122:12: warning: unused function 'amdgpu_is_fw_attestation_supported' [-Wunused-function]
>    static int amdgpu_is_fw_attestation_supported(struct amdgpu_device *adev)
>               ^
>    3 warnings generated.

CONFIG_DEBUG_FS is not enabled which triggers these warnings.

>
> vim +/amdgpu_fw_attestation_debugfs_ops +115 drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c
>
>    114
>  > 115  static const struct file_operations amdgpu_fw_attestation_debugfs_ops = {
>    116          .owner = THIS_MODULE,
>    117          .read = amdgpu_fw_attestation_debugfs_read,
>    118          .write = NULL,
>    119          .llseek = default_llseek
>    120  };
>    121
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org