From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1172AC11F65 for ; Wed, 30 Jun 2021 07:16:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD90661CC1 for ; Wed, 30 Jun 2021 07:16:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD90661CC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 133CC8D018B; Wed, 30 Jun 2021 03:16:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10C158D017A; Wed, 30 Jun 2021 03:16:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF5E8D018B; Wed, 30 Jun 2021 03:16:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id CD6608D017A for ; Wed, 30 Jun 2021 03:16:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A77B68249980 for ; Wed, 30 Jun 2021 07:16:20 +0000 (UTC) X-FDA: 78309531720.11.CB53BE7 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf19.hostedemail.com (Postfix) with ESMTP id 64C2AB0000A4 for ; Wed, 30 Jun 2021 07:16:20 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id l68so1090065vsc.13 for ; Wed, 30 Jun 2021 00:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TuH+apv+oCsNlAaVg/wm9SSIEaZ31aCvx1H+A/KchsU=; b=IGdEYV6iubpDLMJ5m37PeamgcGglH/0msMCWnvoKR2cBD1N3/JtHZL1wE9KAdHSi3H xTvWfW3VmOzaVAhl7Ii0oVmP0EXSE8BIH6ZM0M+ciyJnXN4JsjWPfSHYIuxLKRzev0nx fV1gE7pl10g/f8CqwzUpUmUoEvnO25cj1vEnbRKmoifogBgMly3lkbQAU/AhBFtI610G GkFjOJhJwnT7+ieWuJK+83HH5LU3Z6NspbkLupjpvsxE5AP/oxfv+wEhtg1A3vLO5Y2z Pg3fKMwDqP6oZ/wVIQ9Kun1+Qy/UL/5dReInoEsbi/58arJ9eK0h1oc36jewINxUW/+D loLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TuH+apv+oCsNlAaVg/wm9SSIEaZ31aCvx1H+A/KchsU=; b=XDxCuM0KrKoURpR4Aor7zxv5p26ieki3ejzLz0njfbFKuy0aK2ooPVSK6+d0q3qtys BHu4nsFLHqi4TbZGVu8XJ8T0yQRuHXfJmSSZtWWQsU72qipEHEpUavW8G1spH6Pp5bF7 jNs9Fgb4En+E64KC4JHRJpPnZ3dsvJiZ1LDdmQHtp9t6FMWB5O0ENk0yZGUYPcfB7IQ1 /JDLk8nOGl4RK/Wdb/pqwSHL+7m/URf7AzddNaY4T2ytx27GSC0T7pp/wofsazB3TySo naepINn2hTKSIYpJWRawCK0rIRi2o051tXNEsLu6addwBw1SWNZuM8yDgJGYcOj4OYkF yEpw== X-Gm-Message-State: AOAM531iypKNmrlHIeoHqR7edbRapohkAK65KXWjHBwHzFRKzIUCT+El BGoNaeePa4V7+YhCj8MNcFMhJZlUFXxo6OIVEck= X-Google-Smtp-Source: ABdhPJw7g8ho6fKOpvf4aTR7903FLbCsjlynaCr0P8Dos7cRRhdQHQRQLYhXXpH90eWmhbXWXbhuUGYOqhbmNPO9n+U= X-Received: by 2002:a67:ed5a:: with SMTP id m26mr28872305vsp.59.1625037379726; Wed, 30 Jun 2021 00:16:19 -0700 (PDT) MIME-Version: 1.0 References: <202106292156.mWNAaVQA-lkp@intel.com> <20210629132909.GA7935@233d919f385f> In-Reply-To: <20210629132909.GA7935@233d919f385f> From: Souptick Joarder Date: Wed, 30 Jun 2021 12:46:07 +0530 Message-ID: Subject: Re: [PATCH] ASoC: codecs: wcd938x: fix returnvar.cocci warnings To: kernel test robot Cc: Srinivas Kandagatla , kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=IGdEYV6i; spf=pass (imf19.hostedemail.com: domain of jrdrlinux@gmail.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=jrdrlinux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 84rt4udmsueo5865t84yh5d933t1ewjx X-Rspamd-Queue-Id: 64C2AB0000A4 X-Rspamd-Server: rspam06 X-HE-Tag: 1625037380-638971 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 29, 2021 at 6:59 PM kernel test robot wrote: > > From: kernel test robot > > sound/soc/codecs/wcd938x.c:1628:5-8: Unneeded variable: "ret". Return "0" on line 1656 > sound/soc/codecs/wcd938x.c:1871:5-8: Unneeded variable: "ret". Return "0" on line 1907 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Fixes: 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig") > CC: Srinivas Kandagatla > Reported-by: kernel test robot > Signed-off-by: kernel test robot Acked-by: Souptick Joarder > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 73748627df83aab934c81332ca83a44ab8c7b3e3 > commit: 04544222886881cb0865040dcdf747fe7e025947 [8525/14055] ASoC: codecs: wcd938x: add audio routing and Kconfig > :::::: branch date: 4 hours ago > :::::: commit date: 2 weeks ago > > wcd938x.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > --- a/sound/soc/codecs/wcd938x.c > +++ b/sound/soc/codecs/wcd938x.c > @@ -1625,7 +1625,6 @@ static int wcd938x_codec_aux_dac_event(s > { > struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); > - int ret = 0; > > switch (event) { > case SND_SOC_DAPM_PRE_PMU: > @@ -1653,7 +1652,7 @@ static int wcd938x_codec_aux_dac_event(s > WCD938X_ANA_RX_DIV4_CLK_EN_MASK, 0); > break; > } > - return ret; > + return 0; > > } > > @@ -1868,7 +1867,6 @@ static int wcd938x_codec_enable_aux_pa(s > struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); > int hph_mode = wcd938x->hph_mode; > - int ret = 0; > > switch (event) { > case SND_SOC_DAPM_PRE_PMU: > @@ -1904,7 +1902,7 @@ static int wcd938x_codec_enable_aux_pa(s > WCD938X_EN_CUR_DET_MASK, 1); > break; > } > - return ret; > + return 0; > } > > static int wcd938x_codec_enable_ear_pa(struct snd_soc_dapm_widget *w, >