From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D5DC10DCE for ; Fri, 13 Mar 2020 03:47:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45BCB2072F for ; Fri, 13 Mar 2020 03:47:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kdmhl+AC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45BCB2072F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFF0E6B0005; Thu, 12 Mar 2020 23:47:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAEEF6B0006; Thu, 12 Mar 2020 23:47:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC5A86B0007; Thu, 12 Mar 2020 23:47:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id A18976B0005 for ; Thu, 12 Mar 2020 23:47:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5C7C1180AC143 for ; Fri, 13 Mar 2020 03:47:43 +0000 (UTC) X-FDA: 76588954806.19.wrist23_264b4e6f8093a X-HE-Tag: wrist23_264b4e6f8093a X-Filterd-Recvd-Size: 3664 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Mar 2020 03:47:43 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id i19so6693099lfl.1 for ; Thu, 12 Mar 2020 20:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zZDSoQx95Ubh+HBfrSp1XYVgSVN4vHwFBPkS+obSa4E=; b=Kdmhl+ACaCBaiNEXRGmux/wGkICP1PetJy1ChTyCtljceocmEmO3tf89WV8uWoKH2d pWZI1u+MjlrMgxgmeDdyXFqfRCQ4OxjTofDEyXIDK7hupYqQDEk4cUhUnAnNN2LAQpuh +gczt4gPC3h6+WrKt/nA8L2HLmlgwaLi+QboL7uc5ERrAk4XVkTxXERJsq6EICHd4f2J TtbH59IfV6VvTqF07HP0ZwpGl69Tuo7DIyFRIQJgVAwv6ortFs6WFiQmePAU7CJm/da7 RndmDsBVODLneg5Z4L24u0pp+/JV+sJdOldEjvio5gsJKPtabUpyiRKx+utbevsTxbkW EmIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zZDSoQx95Ubh+HBfrSp1XYVgSVN4vHwFBPkS+obSa4E=; b=IDZ2dddb1J9EUc3Gtv0rKE9PN2SwJzj1xfOpAg+L/NI3cFd+KFB2Tgo3ePvQz/Nx20 wdg/LG3MpMaJDy3yz11HzNNdgKGoN59dRDMFon///386akiEFy1naw78OrEsWTjZ1SyQ hBZfwIrsXvaS21vRwK5waDfuRMXeooV6ek8EfXMB7CVnK3+sJlCLnS/lVCwEM2fvJX/O 4Mh8IArqM4H5N+9UPRBqdC6TDOqry9AEekysNJA2S+/SqmD2TqM27Nzq8ckrUcMNkJw4 EbHsi4EWSHDkPMiM7QRZHw6ALDeqcS6VYZKuXcXMaqjuMqpGxk687KM1tf7YsUjA8YJU JZew== X-Gm-Message-State: ANhLgQ2a5QpRIUKwIen22LOGByss5cQwZIUP1t1niOMij7MnfNSv3SUo w4OKnEW+R6Bvw+HEuZW1I/Lt6QsjB/WUaYxX7w4= X-Google-Smtp-Source: ADFU+vtaeosP6hJkETgIFM8xGMedLYGzWkquPOyhzA82L8Z2QNLxYdCinWQ9cUB0TEQ/Lqk5kHIjpEpjCNGpUgBgWfI= X-Received: by 2002:ac2:522e:: with SMTP id i14mr3965188lfl.133.1584071261314; Thu, 12 Mar 2020 20:47:41 -0700 (PDT) MIME-Version: 1.0 References: <1584065460-22205-1-git-send-email-jrdr.linux@gmail.com> <20200312195850.29693d4e55ec27ae11443c0f@linux-foundation.org> In-Reply-To: <20200312195850.29693d4e55ec27ae11443c0f@linux-foundation.org> From: Souptick Joarder Date: Fri, 13 Mar 2020 09:17:22 +0530 Message-ID: Subject: Re: [PATCH] mm/hmm.c : Remove additional check for lockdep_assert_held() To: Andrew Morton Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 13, 2020 at 8:28 AM Andrew Morton wrote: > > On Fri, 13 Mar 2020 07:41:00 +0530 Souptick Joarder wrote: > > > walk_page_range() already has a check for lockdep_assert_held(). > > So additional check for lockdep_assert_held() can be removed from > > hmm_range_fault(). > > > > ... > > > > --- a/mm/hmm.c > > +++ b/mm/hmm.c > > @@ -681,7 +681,6 @@ long hmm_range_fault(struct hmm_range *range, unsigned int flags) > > struct mm_struct *mm = range->notifier->mm; > > int ret; > > > > - lockdep_assert_held(&mm->mmap_sem); > > > > do { > > /* If range is no longer valid force retry. */ > > It isn't very obvious that hmm_range_fault() is and will only be called > from walk_page_range() (is it?) > Sorry Andrew, didn't get this part ? * hmm_range_fault() is and will only be called from walk_page_range() (is it?) *