From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6E7C388F7 for ; Wed, 11 Nov 2020 03:08:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B33D206E3 for ; Wed, 11 Nov 2020 03:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RmQosOjy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B33D206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 939AA6B0036; Tue, 10 Nov 2020 22:08:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EA2F6B005D; Tue, 10 Nov 2020 22:08:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D8096B0068; Tue, 10 Nov 2020 22:08:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 4DBDF6B0036 for ; Tue, 10 Nov 2020 22:08:12 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DE7D81EE6 for ; Wed, 11 Nov 2020 03:08:11 +0000 (UTC) X-FDA: 77470653582.17.pain84_1a0c8fb272fa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id C7A49180D0181 for ; Wed, 11 Nov 2020 03:08:11 +0000 (UTC) X-HE-Tag: pain84_1a0c8fb272fa X-Filterd-Recvd-Size: 4918 Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 03:08:11 +0000 (UTC) Received: by mail-vs1-f66.google.com with SMTP id b67so373122vsc.3 for ; Tue, 10 Nov 2020 19:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=442rfwUCE+wUwn+eSCh200GNkA2OkrDEcUOGspb2Njo=; b=RmQosOjyrc0vZGBp2eor2ZxzpK5OIs+vLXfjGmHyQtVJSnxDhwM+7DBgwEbSAvqmPl AXINUBp9OXywNrlYAcVNvqa982mTq7zPAzyC6ZtvckYMUA8sSOVntSLcdkimGvv++uCa tjna6Qz14SnoZYeYu48XocPQR0CPaz+2DeJGOveTY0O7C9wiJ0/1cBZtALUD1wt57Bfe qwtC9IUWEqun9A8uVNbbywgQSFzZJTfhixqbeUQDSH2hq89qNXe8OVGNdtLCIFlOvW/V g2SJKF/G4bWwKb4HvCjXBBylGatmtCi2gPrXne/WtHoZGkCWv4JTL3dEX79+5w3jobPa DMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=442rfwUCE+wUwn+eSCh200GNkA2OkrDEcUOGspb2Njo=; b=c4NJ9AB7AN6n7Qs+kmduzx5AC4DpPiiAuh1pQ6xTg2cmdbrHpxmIKhYWSz6qTnVYSG kPnullH7rVzLlz6d8cSZGPdROEz3mZpIIOrBCNDiMAY1StISrfbcpnZyzF75G76Z5MKB 4cyPsmYyCbwUtjqlPnVHnvwArjsDNP2sRvYz9tq4LFQAM+u2DLI0/EKLBdjeBX+hU8gJ YnCpxz28arb25TgnztB2NAZKIH4PnYMndqwG2ypWbMY/L/0LfTZ0yKGFDxQYZBCL1ZJ9 tHFZSd75cb21pWYdW4DcEeEd1whxGIX6e6nS8QEMg1A0JNCCOA2GdF3z+1yjTDNPPiIb UE1Q== X-Gm-Message-State: AOAM5335KEB8QUO8iSm6T4lEWLJ8JZHxAs3tpVd5bBGS4Hvo1UbJh1FM R6U1WHuQ7Z6Y2gxPPw4m2zSDXCWg5f1GFhD3uSY= X-Google-Smtp-Source: ABdhPJwV/7ssoFLlZPC2OryGVcdMAC4IWMAopKhdbGb8RqfAd803qvrTolFVBVS0zEFONhXtBttpNX1OKzaOIMhpAKA= X-Received: by 2002:a67:f48c:: with SMTP id o12mr13794524vsn.59.1605064090666; Tue, 10 Nov 2020 19:08:10 -0800 (PST) MIME-Version: 1.0 References: <20201110051548.685725-1-luben.tuikov@amd.com> In-Reply-To: <20201110051548.685725-1-luben.tuikov@amd.com> From: Souptick Joarder Date: Wed, 11 Nov 2020 08:37:58 +0530 Message-ID: Subject: Re: [PATCH 1/1] drm/amdgpu: Fix missing prototype warning To: Luben Tuikov Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Daniel Vetter , Alexander Deucher Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:46 AM Luben Tuikov wrote: > > Fix a missing prototype warning for function > amdgpu_info_ioctl(), > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:482:5: warning: no previous prototype for 'amdgpu_info_ioctl' [-Wmissing-prototypes] Few minors but doesn't going to make much difference. Subject line should be PATCH v2 and v1 -> v2 diff change log is missing. With that feel free add Reviewed-by: Souptick Joarder > > Signed-off-by: Luben Tuikov > Reported-by: kernel test robot > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > index ba65d4f2ab67..d27620fa8b0b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > @@ -1279,6 +1279,8 @@ int amdgpu_enable_vblank_kms(struct drm_crtc *crtc); > void amdgpu_disable_vblank_kms(struct drm_crtc *crtc); > long amdgpu_kms_compat_ioctl(struct file *filp, unsigned int cmd, > unsigned long arg); > +int amdgpu_info_ioctl(struct drm_device *dev, void *data, > + struct drm_file *filp); > > /* > * functions used by amdgpu_encoder.c > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index be304df7a8c2..70a30440f84c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -1529,8 +1529,6 @@ int amdgpu_file_to_fpriv(struct file *filp, struct amdgpu_fpriv **fpriv) > return 0; > } > > -int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp); > - > const struct drm_ioctl_desc amdgpu_ioctls_kms[] = { > DRM_IOCTL_DEF_DRV(AMDGPU_GEM_CREATE, amdgpu_gem_create_ioctl, DRM_AUTH|DRM_RENDER_ALLOW), > DRM_IOCTL_DEF_DRV(AMDGPU_CTX, amdgpu_ctx_ioctl, DRM_AUTH|DRM_RENDER_ALLOW), > -- > 2.29.2.154.g7f7ebe054a >