From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABCDAC433E6 for ; Tue, 9 Feb 2021 19:17:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2026064ECB for ; Tue, 9 Feb 2021 19:17:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2026064ECB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 995406B0005; Tue, 9 Feb 2021 14:16:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 944D36B006C; Tue, 9 Feb 2021 14:16:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85AA76B006E; Tue, 9 Feb 2021 14:16:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 6D49F6B0005 for ; Tue, 9 Feb 2021 14:16:59 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 37DCE82499B9 for ; Tue, 9 Feb 2021 19:16:59 +0000 (UTC) X-FDA: 77799686958.14.F8BAAD6 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 0D19980191DF for ; Tue, 9 Feb 2021 19:16:56 +0000 (UTC) Received: by mail-vs1-f42.google.com with SMTP id l192so9999776vsd.5 for ; Tue, 09 Feb 2021 11:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=saOZwDKFkl1+WL4Z+kVhLvaR5zC6QYD8oqangHzyxNE=; b=rVt0ksW9fWLI/9FFpsrS67coz36te3UrUiNuwuAGjgyZgV6pwA8776gXUYrgrAhGXD 0RmVYXug8xEPr5iDULKnnJm1g/fvEjH9AosPm9gvryawOve2nSw6zxAAlm99QojvDUnC z/DBWhskBS5D1ZLn+13u9G0iUeVaq76SamxhGz9eoSm18wTyueIbIEbM+pljq4eSRnOg K9nKYpJjm8F7M3w4VqyvU1Y+m2L09lu9Xe8oWm3jOhHY78udg/BTwNgkkEh4SbsmPElK lqXjaZbuU50slGGDaMbg83wtqljd7Do6/MsLEe7xwY6rrg6Mg9DAGgX280RR/GzOOi7+ k6IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=saOZwDKFkl1+WL4Z+kVhLvaR5zC6QYD8oqangHzyxNE=; b=QbB6ZGrUxDoOD5oAvkrByoFYKTO+d7gGJz2oW+R/X2Pg/QcgjPnOXlKUFtZUNLZ6/p OEdu21eROIOHjKWmosQThZkQLntVC9ywbmiU2lvCVuPDbFas1AqHwjbWyMygfmH8xp1I NL6CiYHWvWT4dNl92f9k5iG9/w4GQXWMSOBV82OIYKb4THAJVzKhzMfzwd4EpPDSNpff VIaYTZSBfnZ6901apCgjY/WdsX7jOr6tvqvb5Jx1nNDd+4Gd3ZbAxrElZOvF6scviTHp X5+yg6W4azPe9LvGbLyVaCn51Log3PcpnYsOoPub/GEFmOR5YX/kXJLyPqQAMyJ6w9ma C7fw== X-Gm-Message-State: AOAM533F44D22/3d8RhSbreMtrlN4hw5eawQDSiNb1a6aq5Fq5rYlP11 9SvnJqxc8Fv6zUTA0+C+ng64h7sK+gDkbY15tBc= X-Google-Smtp-Source: ABdhPJzTFXOzfRT1SHXuV22AHlaIIRNJanjsActjEIjb6EXwJz+nLifATrnR+hhw3kUzKe4vkJA3KsxubpwnmoVLgZo= X-Received: by 2002:a67:8d85:: with SMTP id p127mr15052826vsd.32.1612898218055; Tue, 09 Feb 2021 11:16:58 -0800 (PST) MIME-Version: 1.0 References: <202102070252.HkjUQntk-lkp@intel.com> <20210209172351.ovvf6nhhagbiwzih@skbuf> <4bb90ce3-10cc-407a-2158-f860d535d728@gmail.com> In-Reply-To: <4bb90ce3-10cc-407a-2158-f860d535d728@gmail.com> From: Souptick Joarder Date: Wed, 10 Feb 2021 00:46:46 +0530 Message-ID: Subject: Re: [linux-next:master 3824/6048] drivers/net/dsa/xrs700x/xrs700x_i2c.c:127:34: warning: unused variable 'xrs700x_i2c_dt_ids' To: Florian Fainelli Cc: Vladimir Oltean , George McCollister , kernel test robot , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Jakub Kicinski , Andrew Lunn Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ti77576x75i9wk97hdrqbi8ogm5r5ry3 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0D19980191DF Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-vs1-f42.google.com; client-ip=209.85.217.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1612898216-460175 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 10:55 PM Florian Fainelli wrote: > > On 2/9/21 9:23 AM, Vladimir Oltean wrote: > > On Tue, Feb 09, 2021 at 11:18:12AM -0600, George McCollister wrote: > >> On Tue, Feb 9, 2021 at 10:33 AM Souptick Joarder wrote: > >>> I think, this can defined under #ifdef CONFIG_OF. > >> > >> Was this robot reporting this warning for other DSA drivers? A lot of > >> them appear to use of_device_id in the same manner (unless I'm missing > >> something). Do we need to do something DSA wide to deal with this? > > > > Probably not DSA-wide since we still have drivers that probe on platform > > data and not OF (dsa_loop), but individual drivers should have "depends > > on OF" in Kconfig as far as I can tell. > > Not necessarily, there is a runtime dependency on OF being available for > probing but as far as building goes there are stubs provided for when > CONFIG_OF=n which allow the driver to continue to build. > > Adding either an #ifdef CONFIG_OF or __maybe_unused should silence those > warnings. Agree. Some of the similar warning in other drivers was fixed in the same way. > -- > Florian