From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8E2C433E0 for ; Sat, 16 Jan 2021 09:03:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 40BD223A56 for ; Sat, 16 Jan 2021 09:03:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40BD223A56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6172D8D0202; Sat, 16 Jan 2021 04:03:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C6CC8D0200; Sat, 16 Jan 2021 04:03:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48EDF8D0202; Sat, 16 Jan 2021 04:03:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 2CED28D0200 for ; Sat, 16 Jan 2021 04:03:14 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E968E364B for ; Sat, 16 Jan 2021 09:03:13 +0000 (UTC) X-FDA: 77711049066.19.death10_3d0310427536 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id CF0451ACC35 for ; Sat, 16 Jan 2021 09:03:13 +0000 (UTC) X-HE-Tag: death10_3d0310427536 X-Filterd-Recvd-Size: 8860 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Jan 2021 09:03:13 +0000 (UTC) Received: by mail-ua1-f46.google.com with SMTP id k47so3759392uad.1 for ; Sat, 16 Jan 2021 01:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TGR+e6y4a4ALxxGALLyK0opaFiTH9KlJnPBPSPmQys8=; b=QkfIS1VdwnjDmYGu/GEvGRMoBrpFfc44XzwY6N6bzUFvDysFduUcQG8XgdpGONR6gp p/qROLd4KUwkgYrvd/YNlOugA62zpdG8kU1iqOrNBI1bxeQhBu3rbOj5PAUQtOzkBohY 1z/As6ZmOnRvH8jivMYzUmoDoiGAUNFYiGbPbecCErRfAaYuYtAuAwUKSa12wV7S7Sl2 968fRz6x79bHp1UyrMwUOeY4o4h9SXpqeYbssrwnvpK1lNB8Xsh4CJUiFvHKTFIhdv8B oQ3iGroHm9l/JWYAXozCgT0tasgjPdT0kkxL7CRAS8cZYi3W1sRTPWQE67A2apDRQl8E VOZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TGR+e6y4a4ALxxGALLyK0opaFiTH9KlJnPBPSPmQys8=; b=Xa0YbylF3MCPTshhrPAeRphhwxEKvIfrQuE3xl7K/JzPSjQV3kTnDN8pLxwXvJ35b4 Kf318fpW9aGzDSQal6Lnow4lIohNRFmjbyZLjl67myf/D9ehk6kUUyCDW0/rxNqSSXKx 5qYltP58KevJemIgSUyQpkP4Cd75gcnHyoKunzZhfWD9kP/dr4rFkcA/qGcwXRbuAbAm qtO/P6rxTfuZJgtWQ8RMt5aFAyJ4J7e1vy/K5AxYFZdzjnaR1bHBAIrgZnhWbwuABx5r cDfJIL+ocGEWHwB33G1Ae6oXxIgesIVqHDY+gRus1wBsYA5DacWcK5IxrOFcvX3lwLXp jkkA== X-Gm-Message-State: AOAM533LMLtuE3FOETR7GZXQjhgx2nWzd3pXP+Xhuil6TqnAphC+8Q3W GvOf4tpk3UyCdcJoGz6b1mzekq5CwxHk/rOPf4Q= X-Google-Smtp-Source: ABdhPJw5TKWSnep0ON22DmPucZY/qR7fwrYCAKHwIKUd9qbesKLKJL7EJV0x4CuEwHZUcCX5uaMX3RaQdATiKikZ98E= X-Received: by 2002:ab0:3894:: with SMTP id z20mr12424187uav.82.1610787792585; Sat, 16 Jan 2021 01:03:12 -0800 (PST) MIME-Version: 1.0 References: <202101141227.3CQFCbmL-lkp@intel.com> In-Reply-To: From: Souptick Joarder Date: Sat, 16 Jan 2021 14:33:02 +0530 Message-ID: Subject: Re: [linux-next:master 2144/2798] drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1049:11: warning: variable 'vid' is uninitialized when used here To: kernel test robot Cc: Vladimir Oltean , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Jakub Kicinski , Ido Schimmel , Florian Fainelli , Kurt Kanzenbach Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 16, 2021 at 2:28 PM Souptick Joarder wrote: > > On Thu, Jan 14, 2021 at 9:54 AM kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: aa515cdce7a151dcc14b7600d33f1414c6fa32c9 > > commit: b7a9e0da2d1c954b7c38217a29e002528b90d174 [2144/2798] net: switchdev: remove vid_begin -> vid_end range from VLAN objects > > config: x86_64-randconfig-a004-20210114 (attached as .config) > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 6077d55381a6aa3e947ef7abdc36a7515c598c8a) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install x86_64 cross compiling tool for clang build > > # apt-get install binutils-x86-64-linux-gnu > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b7a9e0da2d1c954b7c38217a29e002528b90d174 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout b7a9e0da2d1c954b7c38217a29e002528b90d174 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1049:11: warning: variable 'vid' is uninitialized when used here [-Wuninitialized] > > vid, flag_untagged, > > ^~~ > > drivers/net/ethernet/marvell/prestera/prestera_switchdev.c:1032:9: note: initialize the variable 'vid' to silence this warning > > u16 vid; > > ^ > > = 0 > > 1 warning generated. > > > > > > vim +/vid +1049 drivers/net/ethernet/marvell/prestera/prestera_switchdev.c > > > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1020 > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1021 static int prestera_port_vlans_add(struct prestera_port *port, > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1022 const struct switchdev_obj_port_vlan *vlan, > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1023 struct switchdev_trans *trans, > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1024 struct netlink_ext_ack *extack) > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1025 { > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1026 bool flag_untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1027 bool flag_pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1028 struct net_device *dev = vlan->obj.orig_dev; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1029 struct prestera_bridge_port *br_port; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1030 struct prestera_switch *sw = port->sw; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1031 struct prestera_bridge *bridge; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1032 u16 vid; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1033 > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1034 if (netif_is_bridge_master(dev)) > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1035 return 0; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1036 > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1037 if (switchdev_trans_ph_commit(trans)) > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1038 return 0; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1039 > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1040 br_port = prestera_bridge_port_by_dev(sw->swdev, dev); > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1041 if (WARN_ON(!br_port)) > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1042 return -EINVAL; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1043 > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1044 bridge = br_port->bridge; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1045 if (!bridge->vlan_enabled) > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1046 return 0; > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1047 > > b7a9e0da2d1c954b Vladimir Oltean 2021-01-09 1048 return prestera_bridge_port_vlan_add(port, br_port, > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 @1049 vid, flag_untagged, > > Currently vid is passed as garbage value. Is initializing vid = 0 and > passing it to prestera_bridge_port_vlan_add() > the right thing to do ? Or do we need to pass more appropriate values ? Please ignore this comment. Vladimir has already posted the fix. > > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1050 flag_pvid, extack); > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1051 } > > e1189d9a5fbec815 Vadym Kochan 2020-09-16 1052 > > > > :::::: The code at line 1049 was first introduced by commit > > :::::: e1189d9a5fbec8153dbe03f3589bc2baa96694e2 net: marvell: prestera: Add Switchdev driver implementation > > > > :::::: TO: Vadym Kochan > > :::::: CC: David S. Miller > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org