From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0376C4361B for ; Fri, 11 Dec 2020 19:49:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A27623ED2 for ; Fri, 11 Dec 2020 19:49:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A27623ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5AD996B0036; Fri, 11 Dec 2020 14:49:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55EE36B005C; Fri, 11 Dec 2020 14:49:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49C6F6B005D; Fri, 11 Dec 2020 14:49:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 33FB46B0036 for ; Fri, 11 Dec 2020 14:49:41 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B92F9824999B for ; Fri, 11 Dec 2020 19:49:40 +0000 (UTC) X-FDA: 77582041320.23.waves57_020c8fe27403 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 9BF0837606 for ; Fri, 11 Dec 2020 19:49:40 +0000 (UTC) X-HE-Tag: waves57_020c8fe27403 X-Filterd-Recvd-Size: 3699 Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com [209.85.221.196]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 19:49:40 +0000 (UTC) Received: by mail-vk1-f196.google.com with SMTP id o195so234628vka.9 for ; Fri, 11 Dec 2020 11:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zf6uTTAIY9G26MStfdbgptTIf5sVivxH9li5sbNjMeM=; b=NNb8lyO8GY6UdwDmpdFrKC1riD4dEmOguYuXybsnGceq3vIRglEIQqe25SxdtwFn9+ xEEaqKiTR30Cg8cPzEaRLwaHg03VRRNknDHAVROxCJbci4quh4g5tuHgrcPVQ4q9r+B/ yKM5fGHa4C+5Fod20Wcc3OdpNkckG2kOP/o4aGRVBawKWUxGI+eIWhTxjn/0T87gvCat +0ZbcwZAKUaKgAC/3JXlaYFlM6cY+5leDfDpxoR74Kv8Onp0rNEh4e5nJ5wqbhm5amhH kUKgIq43UFWp5xu/JO/K8oFqGy8NkeOpmfeNU6X0xyYyCUkIExMq2sIe4a44zVqZAtKe aVKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zf6uTTAIY9G26MStfdbgptTIf5sVivxH9li5sbNjMeM=; b=D991psUIaVcFyIbqXF9BTJxYLlAG72uZztWNrw6EEVoxtODHNSBK7PrDfILnu5U5bM 4rl8/uK/g7vUPVssHpJxKWuXVnePgy2eA8SImoSSmWR284fb5B23zlw49L3i0+oW/Wjk hKuJ2c2RvKMo18yHTjeaQmsUjSRu/89/f0E1euGU21W6Wn/bWa6O4+AdcvgeBWAkgxZO jzMkg5+Yal0miAWivs1uCmw8NuWX/AjeN9cYHNGEEaMo9BWs+tGmoZMWCg5suboSNEeB J0ePVq9KX3ULfU8PJ6hcIKgNpEWK5kKYZc/g9SLSdB+8KWmJ3KxZBZtYvtppktBOlR5h wsig== X-Gm-Message-State: AOAM532XDJVYC5V1SM11xrBK/hhpJIfwz6/ZZSctWAa8uwVc7SKcjnsM KlNJfnBm1JKIFqoN5OqHbYN0AmB2wvHdecH/1QY= X-Google-Smtp-Source: ABdhPJzPqnOGn+hEf8rf1SrAcyvd3s4D7C/t7rnTf4FoN2TujEzSJQT1uugjLm4kHJj6CAbb26K/dAUjNQ0DBZxz398= X-Received: by 2002:a1f:8f48:: with SMTP id r69mr15747930vkd.6.1607716179509; Fri, 11 Dec 2020 11:49:39 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Souptick Joarder Date: Sat, 12 Dec 2020 01:19:28 +0530 Message-ID: Subject: Re: [PATCH] hugetlb: Fix an error code in hugetlb_reserve_pages() To: Dan Carpenter Cc: Mike Kravetz , Mina Almasry , Andrew Morton , David Rientjes , Linux-MM , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dan, On Fri, Dec 11, 2020 at 3:44 PM Dan Carpenter wrote: > > Preserve the error code from region_add() instead of returning success. > > Fixes: 0db9d74ed884 ("hugetlb: disable region_add file_region coalescing") > Signed-off-by: Dan Carpenter > --- > From static analysis. Untested. > > mm/hugetlb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 1f3bf1710b66..ac2e48b9f1d7 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5113,6 +5113,7 @@ int hugetlb_reserve_pages(struct inode *inode, > > if (unlikely(add < 0)) { > hugetlb_acct_memory(h, -gbl_reserve); > + ret = add; This function returns int but ret is long type. Does it need correction ? > goto out_put_pages; > } else if (unlikely(chg > add)) { > /* > -- > 2.29.2 > >