From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3563C433EF for ; Mon, 27 Jun 2022 01:05:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345B36B0071; Sun, 26 Jun 2022 21:05:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F50A6B0072; Sun, 26 Jun 2022 21:05:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF3F8E0001; Sun, 26 Jun 2022 21:05:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D6126B0071 for ; Sun, 26 Jun 2022 21:05:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DB536344A6 for ; Mon, 27 Jun 2022 01:05:41 +0000 (UTC) X-FDA: 79622223282.23.A5D26B8 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 8263140024 for ; Mon, 27 Jun 2022 01:05:41 +0000 (UTC) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-101d2e81bceso11262026fac.0 for ; Sun, 26 Jun 2022 18:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bEDEWM/uIediVqxTgHJ1ffqjVVrgXA7HPhbIDVnGRjA=; b=N0kobSzdTz1T5pZSU48sBPPO1LDhIsX6IU8x3mwYeyaf9BsgbSveanERApsoUkF6e3 2wR3FtV9u/Fx6PCJX7oe/R/5ul4XjCJrnIh3GJEMSR88iF6j3rkjiJoncM+02Z4fLOYB v+QcK249wDse+JdkMxAOzb0lLtvlrlJv/8Qf4iY4B9Vy302menS+GWt0kexRSOQj4bvN HUv0frlzdNtwdCCnJ+gIESQUF0ZynlonbAkkqOFNPPg8MyUnxKZzVb7n/S0KvPajOWF/ tX63CdA8mNYxHFVjGEh9J+rrhsvA3T0EEJ27F1MI8qmjVWMWIIw9zeNB4yqYo2mo52SV b3mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bEDEWM/uIediVqxTgHJ1ffqjVVrgXA7HPhbIDVnGRjA=; b=Iuebanh+eKI1XNc2UEiVNjZNsr0iFswLtVZ+LZkgu7G46cIwBuv9R/Sdb4MzfCNI+M RLrvAoi8BXQMRhj9NoiYsANQ49y7RO3diJ2Dw5x+VqLYc9sesSHgwDUQiGUZo4lYdJNv pmC0qixkGf1DiH1yi/0Rqtc9Yi4Ydl7oDr9rMZAGvxOiv0D55nt3aMyx8Hrq6yjOtz+L mAE0a0eoAld71dnNqxIKcfW8CAZpVxS6vo/28UbCg2UQ42BCSO539BR1pZnYU0X707oL H+yc1jnxlNK7ecyjfMgsWD37SZLwS5oEoQpcQ4RlCwKcdup65r/uy/sqqk/CHd7s1pFx 4xKA== X-Gm-Message-State: AJIora9qqEa+5iOc4mRdkIGI6rkOvg2I+Ds16OBmfgyct7XEF24gXe2z ZlSJnKYFyGnRJqpBW1hd2oDWDauBAMYNZ1ps7cU= X-Google-Smtp-Source: AGRyM1usK8XoCZ+Jm60xYYm5XWgIu/hR2mwVJiqsxvAhVLdVx5kpsc2MfE0Cvr+InPsxFp+qlwuYqkLSOhZFREg+e/I= X-Received: by 2002:a05:6870:b52a:b0:101:d9d7:e879 with SMTP id v42-20020a056870b52a00b00101d9d7e879mr6548422oap.258.1656291940718; Sun, 26 Jun 2022 18:05:40 -0700 (PDT) MIME-Version: 1.0 References: <20220625061844.226764-1-xiangyang3@huawei.com> In-Reply-To: <20220625061844.226764-1-xiangyang3@huawei.com> From: Souptick Joarder Date: Mon, 27 Jun 2022 06:35:28 +0530 Message-ID: Subject: Re: [PATCH -next] mm/memcontrol.c: replace cgroup_memory_nokmem with mem_cgroup_kmem_disabled() To: Xiang Yang Cc: Johannes Weiner , Michal Hocko , roman.gushchin@linux.dev, shakeelb@google.com, songmuchun@bytedance.com, Andrew Morton , cgroups@vger.kernel.org, Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656291941; a=rsa-sha256; cv=none; b=MaTu3iG9TSBw/zv98qzgIayXf4HArt/PgCpe2yZkctc50SS+CLLDL2P4I7i3TwRbKa2lA9 jeWoDaIpA9EReaD28Q/sVAO+0KOQqXkurtmU5kwGdoN9T4KwRqHRKVjR0CnGXQuBDFwkzq sl0rGT7P4feyKiBuezBb9MD3zf9bNZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656291941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bEDEWM/uIediVqxTgHJ1ffqjVVrgXA7HPhbIDVnGRjA=; b=LCzY+0RQKcqcBrANQ/8z1lt1xp7xIXGROLUFm7B90w5qpl9xmslvsSveuIME7ag8b5eG38 wqk9MkjS2NNJRFyef9zv8NcHfxArjQAI011fiki0BxM2slo3ukUUi2F77z38lk6DmBrbXO 4lDhlKqi87UXuQynmIbl5nmHpDgg1/M= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=N0kobSzd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.160.44 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com X-Stat-Signature: oc1xpfaqzdqc5toburu6iewpwy7nndcd X-Rspamd-Queue-Id: 8263140024 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=N0kobSzd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.160.44 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656291941-861840 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 25, 2022 at 11:51 AM Xiang Yang wrote: > > mem_cgroup_kmem_disabled() checks whether the kmem accounting is off. > Therefore, replace cgroup_memory_nokmem with mem_cgroup_kmem_disabled(), > which is the same work in percpu.c and slab_common.c. > > Signed-off-by: Xiang Yang Acked-by: Souptick Joarder (HPE) > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 85adc43c5a25..4672c9ddd188 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3815,7 +3815,7 @@ static u64 mem_cgroup_read_u64(struct cgroup_subsys_state *css, > #ifdef CONFIG_MEMCG_KMEM > static int memcg_online_kmem(struct mem_cgroup *memcg) > { > - if (cgroup_memory_nokmem) > + if (mem_cgroup_kmem_disabled()) > return 0; > > if (unlikely(mem_cgroup_is_root(memcg))) > @@ -3830,7 +3830,7 @@ static int memcg_online_kmem(struct mem_cgroup *memcg) > > static void memcg_offline_kmem(struct mem_cgroup *memcg) > { > - if (cgroup_memory_nokmem) > + if (mem_cgroup_kmem_disabled()) > return; > > if (unlikely(mem_cgroup_is_root(memcg))) > -- > 2.22.0 > >