From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A4EC43334 for ; Mon, 20 Jun 2022 01:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 778E66B0073; Sun, 19 Jun 2022 21:56:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7285C6B0074; Sun, 19 Jun 2022 21:56:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EF5B6B0075; Sun, 19 Jun 2022 21:56:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DC1A6B0073 for ; Sun, 19 Jun 2022 21:56:46 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 24AE5393 for ; Mon, 20 Jun 2022 01:56:46 +0000 (UTC) X-FDA: 79596950412.30.B7324B8 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf09.hostedemail.com (Postfix) with ESMTP id CD1EF1400B1 for ; Mon, 20 Jun 2022 01:56:45 +0000 (UTC) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-101e1a33fe3so2377297fac.11 for ; Sun, 19 Jun 2022 18:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ShQXyOSAkGVdNl9hgR0SL6zUjDlwyRW5Zc7GkdpEg0Q=; b=WgHTmNv0bTh+yjJYcsP7x+9KUUEGz7jXU+RdnCwpwFTGxQ1vZBPEigZMk3cz4Ey3yW VsvMvQiaAwlX64cbN2P0MPeN4woOgvtP6W4kw0S9Mg6fJHWwJOsyV4tfo8fZgoIQteRz hb8t1s2MyimEdexcwDiRt+jLdLS46k31CiZzhFPjx5uZDg7oNlADZzPlr+DFWQLaBaVK ISM9bvijAPwvlKE7qAsVx+6Vhx68xmaTpQbswCeG/pP6mRIaRPkrCmM6qI3aZlHNZZLH FMw4vF3Cgje9hZnYBFAkimJAv1Yu69u40z80i0gdfD12Ow0EvPDfN+lg6bb9jknOIJh5 PGLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ShQXyOSAkGVdNl9hgR0SL6zUjDlwyRW5Zc7GkdpEg0Q=; b=3sqILRBYClG7J8fXsLvRsw1Hqgt6nvi/fVTVJRFo1shXgsfsb3M3J1Mmz0JH2sgcMO ka8CoDTZTlNQvUrC4uk3hV3z90bhLIUj02SAbhl/ALBnunuTAXqiZz3kj7CQAnR40ME0 rYoxc9+MbBkMe4MZMcV/UWMD7e+7lSqDf1zIFexYx6xgVwwvqaOcxpZWIzZ9eQ6cKcmL kNjs8eVMQRx1L61X38G3RzEYBQvAjALnXhWLwy7/AvAUep2vSTayLoZgSJjOV6+/nSX7 8x43GORtPtXbgnhdkfqYJOD0MsNTtiHaNZuh1ve+cOZRhIr5mnuf095db4VK/Ugr7AGq vibA== X-Gm-Message-State: AJIora8UGv/ub4O71CDSxszFZzwUfvkfbLDRhexGXj8p/PV17i5ShMeL eO/IPDZkAHKWcF7/TXksC+8xrUNJeurk8AnSjJY= X-Google-Smtp-Source: AGRyM1tZ2SylSiiSfg3SA4yDfy4OID8z1nBg1YgKwrKbynmoPdknqOkUXo79BwO8C3BL1wyj4tnA7dfCCS2Kpd5qAds= X-Received: by 2002:a05:6870:d582:b0:fe:4131:6dbb with SMTP id u2-20020a056870d58200b000fe41316dbbmr17457867oao.76.1655690205040; Sun, 19 Jun 2022 18:56:45 -0700 (PDT) MIME-Version: 1.0 References: <20220619183617.1018438-1-p76091292@gs.ncku.edu.tw> In-Reply-To: <20220619183617.1018438-1-p76091292@gs.ncku.edu.tw> From: Souptick Joarder Date: Mon, 20 Jun 2022 07:26:34 +0530 Message-ID: Subject: Re: [PATCH] mm, docs: fix comments that mention mem_hotplug_end() To: Yun-Ze Li Cc: Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655690205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ShQXyOSAkGVdNl9hgR0SL6zUjDlwyRW5Zc7GkdpEg0Q=; b=D8c/uob6cHlo7flvfLRThY7f7lCSEB/VmlQRGBcZeMP15BF51+x+bTdzSAxZOgs09Nf5N3 1FYL4SJtn+V1f7WkMmKxCCS68uo3IboTa5tyoFKdARAklvWzwi7NgkfhOtjYPEDt9TNsPO 07qzKxeKSUqvkctyQViSMOXecHZOwqo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655690205; a=rsa-sha256; cv=none; b=iUESlZuIrhLJrsGB3PfCHmweWYQ6dvzI2l8uFUNWMacA345eOctwBdHBBjUWn/LffBmVTV Db4Se/zbFIeplfEb0rFsZBN94ota4CHMB+I7QDM7ujk9DnELkyWQk7XSAT8IWwaliLjoN6 cCqfIlPEMgp4E5SvjZBkkNTi1fqNFmQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WgHTmNv0; spf=pass (imf09.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: h7mbu8j15qeenzsrix8d9ezukratk4yy Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WgHTmNv0; spf=pass (imf09.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: CD1EF1400B1 X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1655690205-161685 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 12:06 AM Yun-Ze Li wrote: > > Comments that mention mem_hotplug_end() are confusing as there is no > function called mem_hotplug_end(). Fix them by replacing all the > occurences of mem_hotplug_end() in the comments with mem_hotplug_done(). > > Signed-off-by: Yun-Ze Li > --- > include/linux/mmzone.h | 4 ++-- > mm/compaction.c | 2 +- > mm/vmscan.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index aab70355d64f..7c7947109986 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -591,7 +591,7 @@ struct zone { > * give them a chance of being in the same cacheline. > * > * Write access to present_pages at runtime should be protected by > - * mem_hotplug_begin/end(). Any reader who can't tolerant drift of > + * mem_hotplug_begin/done(). Any reader who can't tolerant drift of > * present_pages should get_online_mems() to get a stable value. > */ > atomic_long_t managed_pages; > @@ -870,7 +870,7 @@ typedef struct pglist_data { > unsigned long nr_reclaim_start; /* nr pages written while throttled > * when throttling started. */ > struct task_struct *kswapd; /* Protected by > - mem_hotplug_begin/end() */ > + mem_hotplug_begin/done() */ > int kswapd_order; > enum zone_type kswapd_highest_zoneidx; > > diff --git a/mm/compaction.c b/mm/compaction.c > index 65970107b789..b8c1f60c84b9 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -3009,7 +3009,7 @@ void kcompactd_run(int nid) > > /* > * Called by memory hotplug when all memory in a node is offlined. Caller must > - * hold mem_hotplug_begin/end(). > + * hold mem_hotplug_begin/done(). Caller must be hold mem_hotplug_begin/done(). > */ > void kcompactd_stop(int nid) > { > diff --git a/mm/vmscan.c b/mm/vmscan.c > index c6918fff06e1..bd6aaf85ee7f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4586,7 +4586,7 @@ void kswapd_run(int nid) > > /* > * Called by memory hotplug when all memory in a node is offlined. Caller must > - * hold mem_hotplug_begin/end(). > + * hold mem_hotplug_begin/done(). Same here. > */ > void kswapd_stop(int nid) > { > -- > 2.25.1 > >