From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F9AC43461 for ; Sat, 5 Sep 2020 01:11:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1FF8420797 for ; Sat, 5 Sep 2020 01:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kxH98ftS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FF8420797 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4717A6B0037; Fri, 4 Sep 2020 21:11:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 422726B0055; Fri, 4 Sep 2020 21:11:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3108E6B005A; Fri, 4 Sep 2020 21:11:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 185A76B0037 for ; Fri, 4 Sep 2020 21:11:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC17D8245571 for ; Sat, 5 Sep 2020 01:11:24 +0000 (UTC) X-FDA: 77227229688.06.ant60_5b036b7270b6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 9CDE210050D72 for ; Sat, 5 Sep 2020 01:11:24 +0000 (UTC) X-HE-Tag: ant60_5b036b7270b6 X-Filterd-Recvd-Size: 3981 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 5 Sep 2020 01:11:24 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id w3so9980148ljo.5 for ; Fri, 04 Sep 2020 18:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cVcjVt4eRCCqDmBRs4CW6qVJs8qz0idz0moivADsBgI=; b=kxH98ftSFWAPsaHJTwX+WhvhUjCZUTPhHBinBNAIzR04z6fSpI1zS5DJZFMagawr0J YoQ3fUF+RlxxgduK7z1/GRhYa9Dygtd8Oc0WJJXK/Xq8aEk3HNbFpqsLPPM8BqcM9FLb hipXojb9Wzw77e5JIyXAOcsSzdZyPgGToQ2Ta7V8Z/sEFyXvS8pbjuiaROFpyTBn4JZf pCGdHmZqi/ao32ZRiHDJp/AeZTrbdv+9C0u/bApzFSMxVS0aSf2akzJL6yh6PaCREqx1 LgnVy+lwHmuAW9DM0z76gckFx9g1xmf+baJsP2LRzXT1j1AiHohOmvj7oSziChZq5gk9 lQDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cVcjVt4eRCCqDmBRs4CW6qVJs8qz0idz0moivADsBgI=; b=k30QUJ0XPXXyV16M5d+cs3w5OOzgdItHls0XRpCUPBU43XxWRWkoE8vbLXdQCbJ5n/ ilIaTBM2a0EdDT3cFekWjmYlZyvWzYiVOKWU93OIo9ZhUIxNlMhUOdv8cLUnieSPoW+8 TLJCS5P8bGt5QA/UYAvcsdE9trgH2wGVETlhDvJ99WFvm1mwV7ERQfGDuUgWUTc0Nh2E L2YqeLydS/3UzD/wNq5/Me+NCCtgDMmY5rzryFLAyBeXMaJgI1WxDAl/bvQYjgVJq4UZ /LIyJpGsLAvcQJ3vaxBzZRaLGENoHK5hiZYrI2iJTpEJp/7awmo1QVdSmoco5afefvOI iOEw== X-Gm-Message-State: AOAM530W+XLcNr4AqUUBrzUV9BD59nlHYBI0t/AbywhNW70ynkCPRnQ4 fYVBsiBnfT00dOojH5W/uegW2bF3pQiWuojAC3c= X-Google-Smtp-Source: ABdhPJzp6Hqvot9y7mTd2pN3V6/9sHFQaaXXammREKjLP1Pkf8aJMWhwhQ2SctDwvxrRX0w733PFGIGKk0ZmpypD0BQ= X-Received: by 2002:a2e:84d6:: with SMTP id q22mr4199950ljh.70.1599268282585; Fri, 04 Sep 2020 18:11:22 -0700 (PDT) MIME-Version: 1.0 References: <20200819110100.23504-1-song.bao.hua@hisilicon.com> <20200903183950.GF14765@casper.infradead.org> In-Reply-To: <20200903183950.GF14765@casper.infradead.org> From: Souptick Joarder Date: Sat, 5 Sep 2020 06:41:11 +0530 Message-ID: Subject: Re: [PATCH] mm/gup: don't permit users to call get_user_pages with FOLL_LONGTERM To: Matthew Wilcox Cc: John Hubbard , Barry Song , Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org, linuxarm@huawei.com, Jan Kara , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Jason Gunthorpe , Jonathan Corbet , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9CDE210050D72 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 4, 2020 at 12:09 AM Matthew Wilcox wrote: > > On Thu, Sep 03, 2020 at 12:42:44PM +0530, Souptick Joarder wrote: > > We can use is_valid_gup_flags() inside -> > > get_user_pages_locked(), > > get_user_pages_unlocked(), > > pin_user_pages_locked() as well. > > > > Are you planning to add it in future patches ? > > If you're looking for a new project, adding a foll_t or gup_t or > something for the FOLL flags (like we have for gfp_t or vm_fault_t) > would be helpful. We're inconsistent with our naming here. Sure. I will start looking into this and come up with a RFC version.