From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B2B6C56202 for ; Wed, 25 Nov 2020 15:49:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE9F6205CB for ; Wed, 25 Nov 2020 15:49:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rDhffU8a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE9F6205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1648B6B006E; Wed, 25 Nov 2020 10:49:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13BFD6B0071; Wed, 25 Nov 2020 10:49:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 077E06B0083; Wed, 25 Nov 2020 10:49:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id E74836B006E for ; Wed, 25 Nov 2020 10:49:47 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AC1428249980 for ; Wed, 25 Nov 2020 15:49:47 +0000 (UTC) X-FDA: 77523376014.04.cat61_0e0cd7e27377 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 1B8EC80105A0 for ; Wed, 25 Nov 2020 15:49:47 +0000 (UTC) X-HE-Tag: cat61_0e0cd7e27377 X-Filterd-Recvd-Size: 4366 Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 15:49:46 +0000 (UTC) Received: by mail-vs1-f67.google.com with SMTP id v8so1452199vso.2 for ; Wed, 25 Nov 2020 07:49:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NuolX140BHWDSfAnkAazVtuOkVaQx44vD4ygTSsH7i0=; b=rDhffU8agGCkAeyEzGOkE+j6cV0a1uoxirn6kM7BJm5UTghhnCpPPmC5ZcgkRQCU4/ ZrU+CSewAUPDIQI9wIDd+dZ+PYYK7Y7XqRFNNLI45GFBIWpejw2JQyysvQRB+OM2UVBg PIZe2C5VtJKmtFgGbXJizuw3zRmsSUPi9Go36xiqD3gZv3JmzxaHoeMfb7AUzUgCYHWM VxnFrZlP/9xAaOenxTittyfcWHh6gRIEvjbiymOcLLTVfBTJBJIf0cvUQp3Cip6IKhA4 N80sUDm/AngysoETFD0JET7QZBlgMeo21FqFtClS7CZYcWOdKWg53XZXja2tD/AeV749 4rYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NuolX140BHWDSfAnkAazVtuOkVaQx44vD4ygTSsH7i0=; b=Y7UszuUiUrSjvZOVaBsYa1LrtUod9XDM9m+8dGH9BrG9anuvNo7fbgCHPDRgiV/mz9 C/sK/4Sot/mmvW7haoBj1HksBt8iZqrvAlf58lo6JHTB9Sc/mLuxroBVp2hxLzxLtsc+ 4jnW+JL8kIj1GOZp0sOG9lXgDJmUQdjXOi7tU0W7fs64GyM5BqXKmsbsMJpFkDeg41om 4oTrQi+L3bWRGrJAY9cVlh+xFlQfNPvwzgzKPNVMfFJks/QqzrV9L7ZE8MFevguPdvAE 0o+unBlnJLP/rnzL0XbGMj60x5JADh4PDXvAm8tSNCICy1CoHk3yYZBG9XHElWVSQMxD mjyw== X-Gm-Message-State: AOAM530OJI06RRbcs3mmGDG8Wx0KWfAJFLCC/MXzSnT7Tm1J6/0uOYvo UoMzu57QstMsqg35HZuIXc2IvCXEDSEN0ve5aRc= X-Google-Smtp-Source: ABdhPJxZxRKOyaplIjBChIXrROxyvIkuHzgd6WsxFKaCKTd92HH//+2oU9GUNStdVCCIGEkeK0GTjeZoKR8p1QMq8EI= X-Received: by 2002:a05:6102:30a4:: with SMTP id y4mr2493751vsd.59.1606319385866; Wed, 25 Nov 2020 07:49:45 -0800 (PST) MIME-Version: 1.0 References: <1606318341-29521-1-git-send-email-charante@codeaurora.org> In-Reply-To: <1606318341-29521-1-git-send-email-charante@codeaurora.org> From: Souptick Joarder Date: Wed, 25 Nov 2020 21:19:34 +0530 Message-ID: Subject: Re: [PATCH] mm: cma: improve pr_debug log in cma_release() To: Charan Teja Reddy Cc: Andrew Morton , Joonsoo Kim , Linux-MM , linux-kernel@vger.kernel.org, vinmenon@codeaurora.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 25, 2020 at 9:02 PM Charan Teja Reddy wrote: > > It is required to print 'count' of pages, along with the pages, passed > to cma_release to debug the cases of mismatched count value passed > between cma_alloc() and cma_release() from a code path. > > As an example, consider the below scenario: > 1) CMA pool size is 4MB and > 2) User doing the erroneous step of allocating 2 pages but freeing 1 > page in a loop from this CMA pool. > The step 2 causes cma_alloc() to return NULL at one point of time > because of -ENOMEM condition. > > And the current pr_debug logs is not giving the info about these types > of allocation patterns because of count value not being printed in > cma_release(). > > We are printing the count value in the trace logs, just extend the same > to pr_debug logs too. > > Signed-off-by: Charan Teja Reddy Reviewed-by: Souptick Joarder > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 7f415d7..07c904b 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -512,7 +512,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count) > if (!cma || !pages) > return false; > > - pr_debug("%s(page %p)\n", __func__, (void *)pages); > + pr_debug("%s(page %p, count %zu)\n", __func__, (void *)pages, count); > > pfn = page_to_pfn(pages); > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a > member of the Code Aurora Forum, hosted by The Linux Foundation > >