From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464F3C433E0 for ; Wed, 23 Dec 2020 03:18:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E842020E65 for ; Wed, 23 Dec 2020 03:18:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E842020E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2F9098D0009; Tue, 22 Dec 2020 22:18:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AA586B0088; Tue, 22 Dec 2020 22:18:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF718D0009; Tue, 22 Dec 2020 22:18:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 03D756B0087 for ; Tue, 22 Dec 2020 22:18:35 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C4B531F08 for ; Wed, 23 Dec 2020 03:18:35 +0000 (UTC) X-FDA: 77623089390.12.fold89_2e0421a27465 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id A720F18027695 for ; Wed, 23 Dec 2020 03:18:35 +0000 (UTC) X-HE-Tag: fold89_2e0421a27465 X-Filterd-Recvd-Size: 4356 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 03:18:35 +0000 (UTC) Received: by mail-vs1-f54.google.com with SMTP id j140so8125032vsd.4 for ; Tue, 22 Dec 2020 19:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x5KXo634H8AVrpIQXiO9dBjapAtxmnNnBHRzxwMdKHI=; b=ddWCSCSOVyDtaeo9kTlkAlOUWYOzibX3dY5zQx/TVmggiAtgYdW4qFQWOO+ZCy84z7 1tvbFWNHFCZgDfx9uBoiyqHpHJ/olkcJTAFuFVcR5Q4U1oglqseDij8BYP4L3SnuATfK gHZpy90/od05DqxaeqBpU6/YTQGO2/oLJxvvVgrb8l3RE4pBDBUvLifNNzVpKE0UHwBZ FtlnnRWEkiL1KORtDfbffhXRvBHqAXSDtN7cWmiw/pjdfeYbp6NMbUAh9U8mJUv8GGGY yaqAL04PY4xTDaicVRu4AyhUAlLLhFSzNdPGQvp3sq3PzPvoFaZhRIkM88q4M1VetsHY Vxlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x5KXo634H8AVrpIQXiO9dBjapAtxmnNnBHRzxwMdKHI=; b=lLqlBavdwK7OOLKe0tEsWxM4kGj8SWJ2YJeDSjI85mJcbCx9608GdgP5+bCWS3CfGN 6fTfP8Q0xm3x74LxapvmmZtzvx58zuZ1+sL8Eb3Z/KS+LlIb0bMlLHQyGXb/mdJ6sJbu vI607x6ISD298LdCIjSYDKb4UnZ0Q1ewaWpnKYMofSJi/eBm6VxUPxGz/54PKtPPVlMz 3ZXkFRU1J4on9zgRRnqSMyLjiclsi9NIRlvhNqGQ7GBNnFs02Ss6PE+lMRZGW0DmFtQU geUwKXsofwpZmiMB6Y3WginOvvdQlClEAa3irxm9SGlPQySveddLJoKe3r1W9J5WWTea tzJQ== X-Gm-Message-State: AOAM532fXy0TMP3TyCPYFgYCPfkQDZyj77343r30Bv7Cal+Td2PhcQhH UVP97IKPERSY2/paSPWvc0Bhr8GPoVNWog/EaeQ= X-Google-Smtp-Source: ABdhPJx5IFP+CAFnNip3g0AbUoczXHv3s7OphmQOQhMSSTxC5tq3keIB7vO7XVHQWAlM9j/UszqQqtPWQlznnzzD6mk= X-Received: by 2002:a05:6102:215c:: with SMTP id h28mr17070685vsg.58.1608693514664; Tue, 22 Dec 2020 19:18:34 -0800 (PST) MIME-Version: 1.0 References: <1608693378-4392-1-git-send-email-jrdr.linux@gmail.com> In-Reply-To: <1608693378-4392-1-git-send-email-jrdr.linux@gmail.com> From: Souptick Joarder Date: Wed, 23 Dec 2020 08:48:23 +0530 Message-ID: Subject: Re: [PATCH] mm: add prototype for __add_to_page_cache_locked() To: Andrew Morton Cc: Linux-MM , linux-kernel@vger.kernel.org, Alex Shi , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 8:46 AM Souptick Joarder wrote: > > Otherwise it causes a gcc warning: > > ../mm/filemap.c:830:14: warning: no previous prototype for > `__add_to_page_cache_locked' [-Wmissing-prototypes] > > A previous attempt to make this function static led to compilation > errors when CONFIG_DEBUG_INFO_BTF is enabled because > __add_to_page_cache_locked() is referred to by BPF code. > > Adding a prototype will silence the warning. > Please ignore this patch. I forget to update version. > Signed-off-by: Souptick Joarder > Cc: Alex Shi > Cc: Andrew Morton > Cc: Matthew Wilcox > --- > include/linux/mm.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 5299b90a..c1e9081 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -216,6 +216,13 @@ int overcommit_kbytes_handler(struct ctl_table *, int, void *, size_t *, > loff_t *); > int overcommit_policy_handler(struct ctl_table *, int, void *, size_t *, > loff_t *); > +/* > + * Any attempt to mark this function as static leads to build failure > + * when CONFIG_DEBUG_INFO_BTF is enabled because __add_to_page_cache_locked() > + * is referred to by BPF code. This must be visible for error injection. > + */ > +int __add_to_page_cache_locked(struct page *page, struct address_space *mapping, > + pgoff_t index, gfp_t gfp, void **shadowp); > > #define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n)) > > -- > 1.9.1 >