From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFCEC433EF for ; Thu, 21 Jul 2022 01:09:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55A956B0072; Wed, 20 Jul 2022 21:09:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50B206B0073; Wed, 20 Jul 2022 21:09:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D2276B0074; Wed, 20 Jul 2022 21:09:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A3A46B0072 for ; Wed, 20 Jul 2022 21:09:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F11A51C61DE for ; Thu, 21 Jul 2022 01:09:11 +0000 (UTC) X-FDA: 79709323302.20.FF84471 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf23.hostedemail.com (Postfix) with ESMTP id 906C214000B for ; Thu, 21 Jul 2022 01:09:11 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 23so223733pgc.8 for ; Wed, 20 Jul 2022 18:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0ZYFWzKGzAB8/eYekT+g2mD9inXTQAbnlNbmq03r374=; b=eIkgq02SGpHqjd/pBkcMCeE3520yFITeIMJc/90z8VXljXIo4qfiYkmZ+fMPtYsC6f yV2VPXYh5GaxAlqdp0yq8g3dQvUZJQE8J16G3rV9i5ifGkWifL0M9CrluZqgghrxg6v7 XVWbeATRteCsEsl8bPPfUn0OTyXZu5AHGGkDl12f8/dxDggTJwohmNpDyfL6dHidg6yp 3PsNs1nb682zBeKHFR89ET4lwto5Qmk6SDa442wFTmcNq2kWCZF57ewHCIFyXygCWbkH fRHbu1z/R2/rSEfcLGBiXB2jRxG9cQpmUTn8Oiz+zPRAowIky0DRmUgLw4oIPCsaYRyc E2qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0ZYFWzKGzAB8/eYekT+g2mD9inXTQAbnlNbmq03r374=; b=78EQzWGG/QntUP7MMtkKrJCtNRcHHrXNBsjYSdzAIfRDk2ohCkS+g+5sQJaXNncfYg mLtUnaUMyd9/DisUJsqU3s265xa6ZT86wqlXplbAyfh9303hVA/Ce+hyP5jJzjG9Smmg g55y1fEBvlePZXtmf3nEkCyjTyrCs32YNM0j+5EWaaeWoDz0eBXzGLAzi6eYsnqK5s44 9BP7jy1b+kqlqSaesHvZktVvhc7i5YSR6L1qiQxb8qv0c790tRpK+wH1CbB1x9/kiEay Sp8BxcTZTKD1rHi3o0q6KDj8mKgCALoNFJZUIZoRP2tCl3I0zMhdL0UN5/Z6ojGRC61F nkcA== X-Gm-Message-State: AJIora9E2rcYIGiXrqsq9Vx1bibJeMqGL3/K5uacWpKdOLEyz9Hl71iZ gImIgMflM9j1oqjDDYWEucctrQmuH53mvAAkjyw= X-Google-Smtp-Source: AGRyM1vW48JwMh27yBs++6AUqzAGU9wpphasnTi/izAwOFDJ7JJHNjqPXx5rqT4NmpWrlMi0Y1qjad7oMKi97a8v+iM= X-Received: by 2002:a63:481a:0:b0:411:7951:cbcd with SMTP id v26-20020a63481a000000b004117951cbcdmr35813300pga.66.1658365750467; Wed, 20 Jul 2022 18:09:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Souptick Joarder Date: Thu, 21 Jul 2022 06:38:59 +0530 Message-ID: Subject: Re: [PATCH] selftests/vm: silence uninitialized variable warning To: Dan Carpenter Cc: Andrew Morton , Mike Kravetz , Shuah Khan , Linux-MM , linux-kselftest , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eIkgq02S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658365751; a=rsa-sha256; cv=none; b=bWMnz8EGlu5X3HT3cLz/hQBz2E1VRdQn7UPLlbj0iO/fb5BUKfPF7p6woQOtk8brdavj0w GacLSbYq29W8RdYnxnSh2uMQEPnoL9X5VMIUakTlbjT0E5o+LOmWQTsOlS+98PkOxiHZQP ghpU78zn6ffvAcU2CGkhxF6I4O+1nMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658365751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ZYFWzKGzAB8/eYekT+g2mD9inXTQAbnlNbmq03r374=; b=hUHouYBuI8QiZVSQ3QFdxxL0mlHQWuoffGy7dsq470lQgx1xL6+mgWGIKKockVOWvWSjaf kj//gJw1DDitFxSgRWYexEfl9+oNhG01RDQMizBDwQLI3wQ6WB0klbfcd61mtV8yaKP6+r dcGVJVls5/78FBeXJCKykog713NnfsY= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 906C214000B Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eIkgq02S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of jrdr.linux@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com X-Stat-Signature: ixbyxfr79mjip7948kazzami3zhueh6r X-HE-Tag: 1658365751-130727 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 19, 2022 at 3:13 PM Dan Carpenter wrote: > > This code just reads from memory without caring about the data itself. The caller has put an attempt to at least validate the address read from mmap() before passing it to read_fault_pages() which looks correct. I think this line is not needed. > However static checkers complain that "tmp" is never properly > initialized. Initialize it to zero and change the name to "dummy" to > show that we don't care about the value stored in it. > > Fixes: c4b6cb884011 ("selftests/vm: add hugetlb madvise MADV_DONTNEED MADV_REMOVE test") > Signed-off-by: Dan Carpenter Acked-by: Souptick Joarder (HPE) > --- > tools/testing/selftests/vm/hugetlb-madvise.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/vm/hugetlb-madvise.c b/tools/testing/selftests/vm/hugetlb-madvise.c > index 6c6af40f5747..3c9943131881 100644 > --- a/tools/testing/selftests/vm/hugetlb-madvise.c > +++ b/tools/testing/selftests/vm/hugetlb-madvise.c > @@ -89,10 +89,11 @@ void write_fault_pages(void *addr, unsigned long nr_pages) > > void read_fault_pages(void *addr, unsigned long nr_pages) > { > - unsigned long i, tmp; > + unsigned long dummy = 0; > + unsigned long i; > > for (i = 0; i < nr_pages; i++) > - tmp += *((unsigned long *)(addr + (i * huge_page_size))); > + dummy += *((unsigned long *)(addr + (i * huge_page_size))); > } > > int main(int argc, char **argv) > -- > 2.35.1 > >