From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55503C4332E for ; Sun, 22 Mar 2020 15:16:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EAB5220724 for ; Sun, 22 Mar 2020 15:16:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rR8TitqV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAB5220724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3ABD26B0005; Sun, 22 Mar 2020 11:16:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D6B6B0006; Sun, 22 Mar 2020 11:16:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 272AB6B0007; Sun, 22 Mar 2020 11:16:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 0B7EC6B0005 for ; Sun, 22 Mar 2020 11:16:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B18B8181AEF07 for ; Sun, 22 Mar 2020 15:16:26 +0000 (UTC) X-FDA: 76623349572.05.fish14_1b1ed41a3e019 X-HE-Tag: fish14_1b1ed41a3e019 X-Filterd-Recvd-Size: 3349 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sun, 22 Mar 2020 15:16:26 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id n20so8197136lfl.10 for ; Sun, 22 Mar 2020 08:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UiQbUXjkv7dvJPYjix5G08GTr5tXFgyICC/8mG3TbLM=; b=rR8TitqVvdTSiG5IDnpTZycycf9Juv73G4Oq20wrsO8YxX6DngsUCy1LjlHZFtog/3 on1H0z4jKEsE7lu9SGJQBZNtm2p5U4MCd2jXKDFUfA4N7DG1Rg3+onS0YfLmPZrV6NFc D3rkIpEG5nDNe8TiUYZojIxcUN9l4MfSeTF2afJnAid9bRhFmKCsrJbI6GtajF2Y/t6j Moxs1vzKpPPSpvA5pH/J/OtZ+ps2dHwAx2Nq8oT1Lx6YXSzRjvYPEML/lxQWcIjwajSS +d+JlSGOzOYo1xvlFTSuMBKTp1rbRcZ9Ew9rRjFUhLXaXvHfQpcJBkRHF4fRhBhyKViP TzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UiQbUXjkv7dvJPYjix5G08GTr5tXFgyICC/8mG3TbLM=; b=ceebR/8RAuYsRlvX34Q4vPG3C7o9Ij7Eq42CGjA4uYPf9RGn7MK63CV7OzGOWmX1kq mNwu4NlXtTFOWIAXUnJ2H8ir1LeKeTYqAz+52Uo33VHzt2pBez+cg9WLr8WRZq6oU//g j+BzfT9vfvubPLFVH4m1zkpsEM8Zk9CLc+q8zF7InH1/ri2BYmzp4tpUsITyvpsakGKJ zMMI6NBpNm0XcQ72VeXRH+TUKhGVWPgUnJaNhkk813SLCWqxE0fnXJgs/kCMV2VcPl0T 37v+TJmClr7Ucykr+Mc3QHtKqUVPOMJd5Hr26n6ZL2NvBLTOh5G6XdND0T4lBgVkkzPw 8sKw== X-Gm-Message-State: ANhLgQ02RXMJ12bNtkwkm1WOQHDF0+W9nafn457mS+Q43W1M2KkSOO05 LyK7dEOj3p/bfdD0oUBcwV1EM4bNu3xmwD+pehs= X-Google-Smtp-Source: ADFU+vsCUq5yboISgFixyCY71nyL49myzuOxRv5IfB4yL45p/mq8M+oDVJbl73ER46yiPXZDDtpIUZVSaAp5CwjfWDc= X-Received: by 2002:a19:ac42:: with SMTP id r2mr10521930lfc.38.1584890184772; Sun, 22 Mar 2020 08:16:24 -0700 (PDT) MIME-Version: 1.0 References: <1584065460-22205-1-git-send-email-jrdr.linux@gmail.com> <20200313122210.GB31668@ziepe.ca> In-Reply-To: <20200313122210.GB31668@ziepe.ca> From: Souptick Joarder Date: Sun, 22 Mar 2020 20:46:13 +0530 Message-ID: Subject: Re: [PATCH] mm/hmm.c : Remove additional check for lockdep_assert_held() To: Jason Gunthorpe Cc: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 13, 2020 at 5:52 PM Jason Gunthorpe wrote: > > On Fri, Mar 13, 2020 at 07:41:00AM +0530, Souptick Joarder wrote: > > walk_page_range() already has a check for lockdep_assert_held(). > > So additional check for lockdep_assert_held() can be removed from > > hmm_range_fault(). > > Is there a reason why you think this redundancy is bad? Other than removing an extra check , I don't have any other strong reason to support this patch. > > IMHO it makes it easier to understand the API contract if key top > level APIs have their assumptions coded in lockdep. Ok, I will drop this patch. Sorry for the noise.