From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE2AD64097 for ; Fri, 8 Nov 2024 22:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B30FA6B00B7; Fri, 8 Nov 2024 17:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB92B6B00BD; Fri, 8 Nov 2024 17:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 933426B00BE; Fri, 8 Nov 2024 17:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E3866B00B7 for ; Fri, 8 Nov 2024 17:12:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2DCE51A0FB4 for ; Fri, 8 Nov 2024 22:12:26 +0000 (UTC) X-FDA: 82764325938.27.76D77D4 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 74A50C0012 for ; Fri, 8 Nov 2024 22:11:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ff3zi5c8; spf=pass (imf28.hostedemail.com: domain of technoboy85@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=technoboy85@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731103858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KaeVr79q61Y3Gam887bzrKkz/UzFhMe5MAPAAQnkc54=; b=DbO3kQc6xHz5lRmLX6UcMtfDkVnVI5g2ohxERqSv609xCHe67XROb7oQ3d1JhaWr+FH1Ul +irSOnPrI9Z9mahCVTPonSTDV8AVtT+tHLSgpkvevx4V7KDTFxDpdbygxU5hDnRHQuB3Ch yePOkmlQ7kNp9cb7SCygQaR3dejXr8k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731103858; a=rsa-sha256; cv=none; b=hxR3eAlBT/kLpztiI6/IXNdqKwcNSpjGzIfOuq214POJKdSd/g6uj4UWzHwLwhO96hioWV KPm/oZd3lx5Ru3gk1GS+jLdCziHtcZAajyrmwVS2n8F2VT/GiK6qSVtWlgnxX0wdgj7oOs 3NH3RU1b8Wx69C7KRC9uPlMJ5+9hFAE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ff3zi5c8; spf=pass (imf28.hostedemail.com: domain of technoboy85@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=technoboy85@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c9634c9160so3109723a12.2 for ; Fri, 08 Nov 2024 14:12:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731103943; x=1731708743; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KaeVr79q61Y3Gam887bzrKkz/UzFhMe5MAPAAQnkc54=; b=ff3zi5c8RBZB139QVjKFVHDbrkWwB/QgzsqneOnEN17yE6aA6pwRX0USBGQo6ExYrz qXlLyJ2F9G0VKjVdEjH6gkB7IAzQYoh8nb3UU4sfYCTuZ8PpDFLjxLcIi6whBe9ct/+d yBWOhXmd77aaauRhLOVKxucfx1qWqaXXx9UPJ2N40ZwAOlT3wTtSuQkAcKgHCHdVwCJ5 dyskqLBVl7Gtkb5JQ5pFM31Lc66bEmQ8wvpbLkH0ht5y/WUPSAfh4RXn94j9F9RtypV4 mfdIAW2AcqO79rtiFB++Ne7RRvEhhXuBiI3R1W2FsLReQahLP8c0ZOG2HCIdWAqYL4IS 4F5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731103943; x=1731708743; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KaeVr79q61Y3Gam887bzrKkz/UzFhMe5MAPAAQnkc54=; b=qEyLKxZynOSXC4Odz3e3YswwXrjxrWqQzHpErsYDEU+coSl151jbqd2SrzZ5nSIX9D KWIymOeVAA6Xy7mm+guxOZSg8eoMDKKz7n/rdJO8KkQ+VTeMMq+8n8sYMsCBocjK7SqI 3yjNHJN93TxVc93cI4IQgsAm2SaeMsWPxlYBYv//KUOhdlHsTg45mGF5R+Li9bgjptCX 9hlcR4CG5I2DIJuaOo2Fc8Z1doNFB+oFMCWuLR1mTeWXAyBzHbbNJB5OlMRkL0Ow6oR/ R4+BJRYxxJOHnGXKtamwZtkYGbE2i3pNwL+7HNfH0Mvytm7m1oQiRPsTu/TNvA0IZBFF HXTA== X-Forwarded-Encrypted: i=1; AJvYcCXtUasMND6UP4yQSvd+kAPnjv/pAj98OYl/+uAo533nyPS3WgdF8dFdZhrX1QQwPbAp2sCyUG7vpw==@kvack.org X-Gm-Message-State: AOJu0YwDKftQGO7b9qWTMCoOOuG20zcGcu1FoPqIvv+NcYWhnzyXBc87 +1hxdv/kTlgUg+zCaF+eZc8kbIZ4HgtHczr5a341RYP6XLkppRDEQU4E65vOBUHiWoPrt49gmh8 Du327NzwxLW8h0Km81+5QLtBwbYQ= X-Google-Smtp-Source: AGHT+IFSL0Rj2MGxaQdDpfRcJh1RqKCazURp/EdKotRxtFoL7va3TLfHDNwmtxZ40d5yFwAeV0F9ZQMKfhlNCRAmLi4= X-Received: by 2002:a50:954c:0:b0:5cf:e43:7695 with SMTP id 4fb4d7f45d1cf-5cf0e4377d2mr2654802a12.11.1731103942600; Fri, 08 Nov 2024 14:12:22 -0800 (PST) MIME-Version: 1.0 References: <672ac50b.050a0220.2edce.1517.GAE@google.com> <20241107142335.GB1172372@cmpxchg.org> In-Reply-To: <20241107142335.GB1172372@cmpxchg.org> From: Matteo Croce Date: Fri, 8 Nov 2024 23:11:46 +0100 Message-ID: Subject: Re: [syzbot] [mm?] general protection fault in swap_reclaim_full_clusters To: Johannes Weiner Cc: syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Kairui Song , Daan De Meyer , Luca Boccassi Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Stat-Signature: 1opx1gg36sd3krc3mi3m7b4wbxo4xck4 X-Rspamd-Queue-Id: 74A50C0012 X-Rspam-User: X-HE-Tag: 1731103906-240168 X-HE-Meta: U2FsdGVkX19mC2KrD5MyxFdSJliPVKbV/TeZQpxuIachbMmJRJjidVUzCbJmmwIRSLiCsmsuuDwuE3+vREHSxXrHZwG+h7yS6JoBK1pGG9P93xIdeVjYR/20aAITi5wiTlFCNCIz3YA+l3rSI7uubropeo6W80NFu/ajbkVe6mgDkxBu6zoZLUKKny0VoaU/q4t/vF3MMbus3iphmxkl0tzYyaOQ+9hqAbxpw4ze3brDtIIP/mw2ihcfW+5OXZU53fn9M7tgT9Z1T/gFyN34X89sUWquaW4Mbflchis9i92hAe/EsQjHi2uHQfODZYMxj+GdW3AoELsrVWgT5+vpg7r5SkTQ4psUsQnN7rtMLgNKQrczYma1qcIzOYb1sZmDSDVsnwrbaDAecoSLmMCmfd2ExG5PsNhMskqCXPKBlfsGtZBbTrYDAffO27KyX24D+iG+Amvj/Y9BdEYDwwx9RGvO5kVAiBqDBYjiGFZtkvVyZryKPc3TSpI3ZPtcJdocGwBTdsnxrqZbRm7MwOkysp4MM3eBD5XIYaIx2DvGyGPYtUPmb56j7fvJmaCTCyiKXJf3vYsUzrNL53S9vpBW7Xjym22pGpgscitKCEdJOxjqO+95brWnMXLCOyIS9JnamAbW+MlJpG4nOn3kPkOzBmJY3h7FDpXwh45jHgxLC6mQjY+bZAFAES4bMGMD46bVTScoBzlzElY2erYFf24FdTHmu6Y6wF2PqIS1dlYGm5lw1XC8eSkW7+VDf8OKkhCnaPTeHmgXoyHpso5k6nxrdnbQBa1joZvnGarBVPPOpK3DZyeWX0dPDUzfcmSwOOfCzgWXpWWQA5cDy471vA24MsjR6e1v13y/YEMTUZozUidaoTQau8Qef8htr0P+/7xhDA+PyxkDmaAg606Px/3kQILd3DI+CqgZ5CgjNXZ35CuzQrJYnpBTAXKeYHmcpx8QtthXaglcGboc6nfaZDC xqC2rtOl YzOFKrvuAbNfWybQZ/aoDIyTWau8Ww5HBuh55aBVmqzbq0DITAF0F2qOadc91hjeY45CvqjuGHKR4dXKfD7cV9hseHiVQJex4Fsl1mErNcCwLGyCuCjQ/a8gCEnjCK7s4wPt2HKF1z3/b6Itbpd5+tKFvjLKNn23fNMOTqlT3D+GS6kSmuIPZ2+QcQTZA9WHW0ZcbFtRC+uQOR4P4YUtHums9m0099Q0sFBijA0bm1tySczzieA320uYO5kbaqnbTzaSo9C0acgNSDEp/B8UfbMWTeAKTqiK/DbGjWBxkpwwRwUCvfhBtiqNgd9oY4kw8AsodkCawhWJhTiD/pgFwnIJdrWuDhERmqZNAlxdzzH9dWqIwbJalfUGhakwEzyp4gIE5XoajAp6loq3PEsDEtXPrE/LkAPbQ479QVRGyC40Web4O+K8O5WniO2BdhawlHPJnLfqeWbfICYmM2Mi7aDg+D4Ckh7WqS/6KvugEsYFNFTKFsLCHahgwAGtISVz4Gel1dEDPCYtS+x71JE8wjhFC6jh6mukHJzPQm14a5a43/dgMO0VLVVT//JRkNd2zDNjHUsuQNc4hwQciM2I7M3ulIczMEnFOpdMbhCaPEoGk5sSYZvBE/nyrvdwil6YnsuQ9CaO0KACn9FVBdrRj0SGIWaOYkfuJrhkCxYz+HCPq+H2m2Uf8sSM62UdNyTdBWn4a+8V7iPC9AV8F+wD9swbLTgtHII1UTDn1squqlqEYz7BAE8/1nWjIY7ENFDTt1DknN6+5loDAEBo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Il giorno ven 8 nov 2024 alle ore 18:35 Johannes Weiner ha scritto: > The syzbot console output indicates a virtual environment where > swapfile is on a rotational device. In this case, clusters aren't > actually used, and si->full_clusters is not initialized. Daan's report > is from qemu, so likely rotational too. > > Make sure to only schedule the cluster reclaim work when clusters are > actually in use. > > Link: https://lore.kernel.org/lkml/672ac50b.050a0220.2edce.1517.GAE@google.com/ > Link: https://github.com/systemd/systemd/issues/35044 > Fixes: 5168a68eb78f ("mm, swap: avoid over reclaim of full clusters") > Reported-by: syzbot+078be8bfa863cb9e0c6b@syzkaller.appspotmail.com > Reported-by: Daan De Meyer > Signed-off-by: Johannes Weiner > --- > mm/swapfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 46bd4b1a3c07..9c85bd46ab7f 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -929,7 +929,7 @@ static void swap_range_alloc(struct swap_info_struct *si, unsigned long offset, > si->highest_bit = 0; > del_from_avail_list(si); > > - if (vm_swap_full()) > + if (si->cluster_info && vm_swap_full()) > schedule_work(&si->reclaim_work); > } > } > -- I've tested the patch and now the oomd test passes: 1/1 systemd:integration-tests / TEST-55-OOMD OK 63.48s Tested-by: Matteo Croce -- Matteo Croce perl -e 'for($t=0;;$t++){print chr($t*($t>>8|$t>>13)&255)}' |aplay