From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0255E7717F for ; Mon, 16 Dec 2024 10:23:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5710B6B0089; Mon, 16 Dec 2024 05:23:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 521656B008A; Mon, 16 Dec 2024 05:23:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E8BA6B008C; Mon, 16 Dec 2024 05:23:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 20BCB6B0089 for ; Mon, 16 Dec 2024 05:23:55 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2CCE12066F for ; Mon, 16 Dec 2024 10:23:54 +0000 (UTC) X-FDA: 82900435044.08.282C2B2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E15740005 for ; Mon, 16 Dec 2024 10:23:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="c/WekfEg"; spf=pass (imf07.hostedemail.com: domain of minlei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734344619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vJcwxIokippDLEGmOLSsMdzfJJziVp7aAF/Ta+P0mDo=; b=0ozszTblNmgMFF+lL+/2/e92qvPZYbvRXXDYZFsiHsxc+tIU3lvuuvgs80ixWJTW+RRtaO WjWz80WWUYtC+oRu2ENinCh8KLNvgG9aSxwHqIckeGyxTFbaUc/DeoZjy9hCNHYTAjmBzH 3yxH4UKTms9Yk8Ro7Y8+webjj8Hx5gI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="c/WekfEg"; spf=pass (imf07.hostedemail.com: domain of minlei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734344619; a=rsa-sha256; cv=none; b=sxQePxlJCfm/bHzZBKecerqE2Hw7NLqbA2ZzJ0zPibSnrRP79e9cEgHKQN/yv/P1lsQCsr jnMMv0nThGJGvHr4cseV5K7ewp+aya/CdBYdygY6dg+bycTO4huLbc2LlkZjvYVaMA4V8k pn/nrjeeAqQPsAapJkH2Pc2rt8IZY9A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734344631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vJcwxIokippDLEGmOLSsMdzfJJziVp7aAF/Ta+P0mDo=; b=c/WekfEg8bWNWVtRTAEm1Y3O03QNJMB6XhyYGFgaj2kfO1kNYdnpcCL82SHTT0dvLQWmor TE4xkgUdk3OBGrQ1eijyHqMbE5CdapK745jiQHS5oECikQutrUXIsrmLoyOnfzFFg+ACWw nyaujZR1tbrNTEKUigto0RSFBpGJPh4= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-8vQnZf1fPAySQ_VF_gWTWA-1; Mon, 16 Dec 2024 05:23:48 -0500 X-MC-Unique: 8vQnZf1fPAySQ_VF_gWTWA-1 X-Mimecast-MFC-AGG-ID: 8vQnZf1fPAySQ_VF_gWTWA Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-4afe8c469f3so2758863137.0 for ; Mon, 16 Dec 2024 02:23:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734344628; x=1734949428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJcwxIokippDLEGmOLSsMdzfJJziVp7aAF/Ta+P0mDo=; b=TVZM3R59WnZ7cm3ozBLXSue02oZ/D1baIYtS8+hLtPnmfmfllhodg0+9uk59PoeHIh wMP0DlATghAcBuZaq/UPXuzziZ2A2+AdAL2Z1W4Ehn9TbmwyvwiwqKrXpZ7JMd766Rsm i5d/UG0IP270JhxR9GS4lE++rBIu8h1F0xi3x6a8geWfDt1lFcsBsvkAHnM/QNcTSPOi GUZIOvur7wRIufWaF00/2lo5bCpp65K5eD52z/+TRJLR1CyIPodjOdDxyXdSazZJbCL5 Nuq9j3ydUC60X4IUWCVgaNs81RSsoElf+OEf9+iqdfx2eYQI8b+XIW25y3nIQ3Gd4p4/ /2Rg== X-Forwarded-Encrypted: i=1; AJvYcCU/8EeA2RjdK1m8wndwCxQ2LGdzJI28AI9C7VFfvK08Z+SAtzIXo7+UozGSkKbflg8tSsSTNnCGJA==@kvack.org X-Gm-Message-State: AOJu0Yzz/56TQDpD2CBonHr2iyztAZhRHJjucldQtCAa3UQsrvbLobcv vd7WP1//ilkJFZV6JiyNj6OI928fRGmv/OpU/j+dpzVDWbT/kF5cPwDWoAAytEnLxHFaFhKIseD cABjcqnG9MLB/hCEsEUpMHixSmbsPxX3xfJG5kr2HS80Uv0nVS9zw/GcguRz9GHoD5V9uGu8EEh 513r+cw1V+rUKgydkPGoC/Lgs= X-Gm-Gg: ASbGncsWohv91ssb/i+ppjks2covaFi461PhmLqLx7CLO2b0YKcTbzVK61fdCSMiSgK Qdt2DflulmHTM/CA+a0T1bWsmLwG8GEm+uw6GRGw= X-Received: by 2002:a05:6102:4429:b0:4b2:49ff:e470 with SMTP id ada2fe7eead31-4b25db3af8dmr10656194137.21.1734344628063; Mon, 16 Dec 2024 02:23:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWgSqRtLOuNkBzntYjpPcstXq1/HmQRBLuSGUi/bM5OVCIjhSFTH920y7viqRb3c8aGdcrUoqEC78K21wnR44= X-Received: by 2002:a05:6102:4429:b0:4b2:49ff:e470 with SMTP id ada2fe7eead31-4b25db3af8dmr10656192137.21.1734344627848; Mon, 16 Dec 2024 02:23:47 -0800 (PST) MIME-Version: 1.0 References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-10-mcgrof@kernel.org> <9fadee49-b545-440e-b0c9-e552bec1f079@oracle.com> In-Reply-To: From: Ming Lei Date: Mon, 16 Dec 2024 18:23:37 +0800 Message-ID: Subject: Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition To: John Garry Cc: Luis Chamberlain , willy@infradead.org, hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0Y4R4Cjp2GzKZ55yuDuhtXjPeYWxI1GLW2t6fGRm-fY_1734344628 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3E15740005 X-Stat-Signature: wmnazmapuhitz5yr6jhue58etrbgawnf X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734344592-595646 X-HE-Meta: U2FsdGVkX1/4WorTK5WmWYYAp4fv7+eyRaO5PfdBBU2j8RC4YXPs8HmG058niWS1BXRhfCT8DZQ3JCrQIrYyATSPnfGB1BZB8I3QwQ7dkZ2xF3DbnP2Br8qjkoHkShsHhQkNTU0g2qQfelLbVM6DhPQY3LN7DiVLlzRTcFI0RPDYNlPVAlIaZl76yDZXAnLndXkYqVRvsFmbVYsIjiAujVm0Ah5zUYJlpdPYPnoSjIo3ZB4aGlrRKmrrU9ClCZobdxq+lklGLeZ4CMI3v0f7+KFz3I4j9FFw53rfWBpwV+rsUiue3rxAyq6p+wzwAaxRfQSYpXr0pDOeQHxqi+mkmjNUD9Z4VLrRega6pqURE4i5vZbk86tsceXbc8uT6PNtWsAfymRx8o6GHRdTiwJaPGnfjP6nqr7B+1frWbqsPsRu3APA0uo1EjtErYAYwaCY0lZRaW33YUx6j/FxUMkGwu1yhuMu60bycUcZsTPlXVo8TxnCS0IjSTDeqHohfA38UrqhvtHLoAZs/aNaaVEU1r5H7ijIIO2p5bHi4crZPCYn0JVmO8CnyZLDCCsj/ZTx4FT7fVWhkvWkvhh/DUzmcGmRzXjvFljX+dkw6q3N3U1LWKztgaP+Ek6dsbjRWoPmN3sDQ2XgfY1tOsISF0c1If0qSb6p0EurDhdDCZWYCKac38WIj61DpySvWNtEpXLseonE4XK99VLYMuMOTtzW+4pbi5D/dn9k4+Sr+G+2CPbRON466rfcKjwZmaeCE8/QX0pCDeg1kkKcVOjMSEoKbZMMi7x/b2vc76lpP8tgpxs9qGAcnUSmAd0xdQIuOp+GzQMAFcp4zr33W0YjFT4ZmR86+NOkYA7a/qqhwwSCUZbP7pvm5OeTrqln5mNd80lKBsCTlBckjJSr4Y9yE3H4y9hsl3Rm8S6CVB2PKgzKwXvxRc5gIzBjF+XbiHQZu9S3qrwFGoGrsntZ2B5FWvK qBtH2IeW IrXKER8XAiZV7Fdqzeu4e1YvKT15P5MZicz+NHRGDO2zufWwHms4kd4QcUvvANkuxTUwJlIy+I30hwOSsIfC4yI84qRWFodKOumi5Ciw2Ukso4P3Ellf2Oa3JS049sL5RE2hI30kKB82WdC/6zsjafWKX1JZPmqDkDM7/kd3SQ2cf3w6LvT+uY/8TZy9Xo2yRnNd14bZyDT3vhkt2Vx/gS80m1NM0BI46ezcltkaPKLeltfqbwocI0EyQJ4w1uqntNcJ3QLGCjEAFeKQlNZsq3UsekRC+qeR6n0Tq9ws5mRgZWZkl00L2kEVgCoCm9vCHfPxwgrBIaq1cERNsX8w93+W6tv5HM41T8ka7L9f6Z5FiSKwIdS5xKkTGccDdsXEuGGmbImWVylZ5jwd1POQjovUF7Iuqe4sLGlRfQN10cZ1Wd5tMsc5q/p5D6PeyqIj5LVoEpLgBH24nmVghdPNIlrsVLtso5lpgyBsi X-Bogosity: Ham, tests=bogofilter, spamicity=0.435604, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 6:14=E2=80=AFPM John Garry wrote: > > On 16/12/2024 09:19, Ming Lei wrote: > > On Mon, Dec 16, 2024 at 4:58=E2=80=AFPM John Garry wrote: > >> > >> On 14/12/2024 03:10, Luis Chamberlain wrote: > >>> index 167d82b46781..b57dc4bff81b 100644 > >>> --- a/block/bdev.c > >>> +++ b/block/bdev.c > >>> @@ -157,8 +157,7 @@ int set_blocksize(struct file *file, int size) > >>> struct inode *inode =3D file->f_mapping->host; > >>> struct block_device *bdev =3D I_BDEV(inode); > >>> > >>> - /* Size must be a power of two, and between 512 and PAGE_SIZE *= / > >>> - if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size)) > >>> + if (blk_validate_block_size(size)) > >>> return -EINVAL; > >> > >> I suppose that this can be sent as a separate patch to be merged now. > > > > There have been some bugs found in case that PAGE_SIZE =3D=3D 64K, and = I > > think it is bad to use PAGE_SIZE for validating many hw/queue limits, w= e might > > have to fix them first. > > I am just suggesting to remove duplicated code, as these checks are same > as blk_validate_block_size() My fault, misunderstood your point as pushing this single patch only. > > > > > Such as: > > Aren't the below list just enforcing block layer requirements? And so > only block drivers need fixing for PAGE_SIZE > 4K (or cannot be used for > PAGE_SIZE > 4K), right? It is block layer which should be fixed to support PAGE_SIZE > 4K. Thanks,