From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6549E77180 for ; Mon, 16 Dec 2024 09:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2B356B007B; Mon, 16 Dec 2024 04:20:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDB846B0082; Mon, 16 Dec 2024 04:20:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7C116B0085; Mon, 16 Dec 2024 04:20:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB1F06B007B for ; Mon, 16 Dec 2024 04:20:05 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3B71443F8E for ; Mon, 16 Dec 2024 09:20:05 +0000 (UTC) X-FDA: 82900273470.20.A03EA34 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 8728B20013 for ; Mon, 16 Dec 2024 09:19:34 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cjv1v70A; spf=pass (imf13.hostedemail.com: domain of minlei@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734340783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ezr7V8tPAUqIcpXhm7ZLFTCr7/A1YkJY6xjiiBqkcIY=; b=rcK8Yxrn2E/P/6Zk8FhI40F1FilH3p1N+z6feDPp9HQuLdpbrCjESA60Y2Ah2yJBPKCxIu swaVNWp3N99tomjtL+JXJMwaEjxnWb42lfL8SB8B3BjpGz1hdXLy2dRcadFQihJ9190zCS cYkxfLkUSrHQ+Ya865N1vAi9RsNpDTY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cjv1v70A; spf=pass (imf13.hostedemail.com: domain of minlei@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734340783; a=rsa-sha256; cv=none; b=hobflyTbdP3dbUenpSkgVGY1njdj9l1YrKVab0sFDRjOW8L7MH3ZdDyqY+vuRUPpl2S7qz TE1fRpoawYZfwQ8PBxXtWEEE4g6n4b1L/kjxnhpcOj6yaCmT/lhDP8IhvqhZ1WvbX3U7hh szo7IU6utOuRcX92yQeBBAlKqDVgMF8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734340802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ezr7V8tPAUqIcpXhm7ZLFTCr7/A1YkJY6xjiiBqkcIY=; b=cjv1v70AV5UoPCN4ePqYM8z0tEfyKAzVg9qe0Sm9ZRQAvBiHTDbVMimKJU0ED0wF/02065 u9LX3fOd0qtoI2nMcKLsVyNgaOZgeyKzuE5iTb7EJPDvAtLdvBIali1p/D8WL7qmQtpfqw M9FGrQ+nXVP1/YnhlIc4T16D72jTWG4= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-neAOY6-5Oyi42yJdt1LrVQ-1; Mon, 16 Dec 2024 04:20:00 -0500 X-MC-Unique: neAOY6-5Oyi42yJdt1LrVQ-1 X-Mimecast-MFC-AGG-ID: neAOY6-5Oyi42yJdt1LrVQ Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-856ec7dc506so706020241.0 for ; Mon, 16 Dec 2024 01:20:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734340800; x=1734945600; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ezr7V8tPAUqIcpXhm7ZLFTCr7/A1YkJY6xjiiBqkcIY=; b=dytzVc+K9SRJKwEAAG9Obp9Hn/AYJHcy7bOcZYlM7mMh8qntNyz5+rUe8h2D7QaWtz eQ5F/Mu4pqcM0Y5WCK0+RbFNSzJEhBDSBBYJwqctF2kta3gCUwrdJymYYN09x9kxNQok TlGsjBgHwmxjIWMjuwHb7pJQhvSTumhK3mCxrlPUxFlIyacMR9eisbGECFcRaPA5tbOH Ic1D1p2+LtqiBe6RsQRC/vycvW+fcOIpYUy/sUYZh12p9+HCl09pb2Zdo5CqlaLQ/VXe lOWBWwW0FmqpInBBqZ/88RMiqcD8V+Uzw1dA3e7lAAyyouSis7rHxCRgIeeU7O29DAhH o7wg== X-Forwarded-Encrypted: i=1; AJvYcCVypvDfCDSa6uLDA5R8eIB8xhC4N98j15hCiqochwFsBIpZnGwO0rL8PQ5cQhBZCPzcs2RmxL/LOA==@kvack.org X-Gm-Message-State: AOJu0YzIvEYVpUw4hnpEudC8n/Yt3SZadiVXMZ7ugdVPeMCDuJ2Q4aus QibH0XCcmWrBqYMcK2KVB/0bTH90qwfBfAAsOVw0si+I8s6SNHwYLkAFqqQIBRGW11Sw4Zq5WIz Qg8yxJ4C0A7J8Zdh1LCULEA/Kw60UkApEK5ZC8MeiePjLHT5JrqQ8/lR0URLBRQ18Q6chBB2r9/ oRDHly14gbbtkvT35i7yy3ah0= X-Gm-Gg: ASbGncur3NcAglC1NzE4dXri6Sl27ogqrdk18kXBFjbqG87NOWevOXVzNQABCSiF68t QwYE4B3OmzzatDjv6Q9UN53pdnCLYVguk+5/mfHg= X-Received: by 2002:a05:6102:f08:b0:4af:ba51:a25f with SMTP id ada2fe7eead31-4b25db0b0a1mr10592471137.20.1734340800310; Mon, 16 Dec 2024 01:20:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhbzCeU5B+2v+R5K9FoBsbiFBRDBPbH+QRMgzW9zb6TVanCU3eaUlsdbe1uzLeYyZBNEEYYFyZyTin529p1eo= X-Received: by 2002:a05:6102:f08:b0:4af:ba51:a25f with SMTP id ada2fe7eead31-4b25db0b0a1mr10592460137.20.1734340800088; Mon, 16 Dec 2024 01:20:00 -0800 (PST) MIME-Version: 1.0 References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-10-mcgrof@kernel.org> <9fadee49-b545-440e-b0c9-e552bec1f079@oracle.com> In-Reply-To: <9fadee49-b545-440e-b0c9-e552bec1f079@oracle.com> From: Ming Lei Date: Mon, 16 Dec 2024 17:19:49 +0800 Message-ID: Subject: Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition To: John Garry Cc: Luis Chamberlain , willy@infradead.org, hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qyu22M5WIu9i4O_O87j8U9MIkq-AvgdMfGzc5XQpFBQ_1734340800 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: nztpyzx1dhq8q1prhd7fexcj7knq919s X-Rspamd-Queue-Id: 8728B20013 X-Rspam-User: X-HE-Tag: 1734340774-360530 X-HE-Meta: U2FsdGVkX1+YsGhE3uTXyz9j3b0D8Z5NfnOKAAul8n0VkF/XWf4sMeTczRrz0xn+Vft3O7zMidMN4+WLAonMvrAp0rVvYxr5PoyMzqlRS7+CMVzQ9TGGwSkBfKANhw5qxPV523USLBbc7SBcK6fnibqaCBKIgoEybwJkW9kGkPo5dRc6TwjRua+iUiPVorQiSLK8e3YP7r5AHGb84ts8su2bqVqOqynXYDWC7n825BCFGLcVH2kEO7TxaM1E4BjqPWNq6tMVqmfVhMJx72vekCubnyaiaOow7plkfdp7YkqquH/8F4EQulSW3XYnM4jkwTYrSbzYc1xSUAMAgHra8Jbvlel/sM6nRZsfF3JSVdlba59zFBwxtU6fqxBA2QwEfJNFEtjb8I+9FxLuF7zel9Qi/+S1oCbFekoyGupreLZgfhvVD5ZtxnIHmfuuaaAX6I2Pw+4nTmNaAJETgIhmIgFxFH33F8eL285VeLrZEOCpPAM0XeHnJ3Tc40lZFWo1HqXw2P6x+dS6uLflbjh3BpCIBniQJRi/pMqCdApF4t1U3sEmLMbdZyDFICrDwSv3bvDxmSM3Yi1SlwzhXG8T0ILfS189dwv/g7qRW/nHQn7GKc3kjPszZJ2v8pl3A2Lb3lqNVvLDkra0vJsj8TqNWe1nFGkoP20Xd5dxFUWTMHyFNfaKVcR3suZdr5MXb7Jivjfv10SnGiDketF8r8NP+Hv8wfZRLrpSgqyWV4BoOQ9mx82Cm7Tyf383KnEJ5cWJ6wMXKIR5ZAOXzDJhFbjzMZV1cfgE0snrLlVqwEDTe18jcOM4Q8wf9ZdUcBl1FjZIsr3mCbmWIrqXi3Uo80u2MBAnsAMLOhQWlHBlIpyXYw/SGo7lDTg16yVBIXKYPcOi4MHGQgStIy/fn/Qvps7+Z0hj3v0dcBrVOHZDtUVPeEgcakEaCi1My53TQWviPqRdCACg1jcK4yNQHf8O2TA oZnP/dGu fb9zAG76iiNhvrk2fq6xHnkOyJnBnviFwh5Lz86vDwQJkczUeg+/hhVxXXYTRgEubf8lzBcm34o21jyAgMkPt/9QWm6XLm2OquC2OeHLIbQeqk5oc7rbA/9GHibZrp91ct5je7CuVxhCRV4fcKHzp7tun/cr/jHWM4x9YDDHw6muFw7lAKNxBGw1C6ivWqsXbWuQs8Jg5SQZLFIs0DcMnv7cP+x/ormDDnk8IvkbofkAfUhJo1qQaQLMCtVV7VQ1c0dKQBE2sY3Pz0d73gxThNoQimc0OGa0UejQ7alVp30fIHLAkAMjHy+lsmZAcFQA8CyJIIgiD3ai4cZrlju2XeWYjB068GkszkiD19KQxZNI05mf/dapZSGw1rO5VbAbC81PSK7ueLFTfZl9osOeSB5tCC41D51aJeoMIaLedbOb/tkktyspX9nYIzH9CklqX8KFZgycLEj/LlTSHGkqpWPjN6NvhfBrK3pH9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.431493, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 4:58=E2=80=AFPM John Garry wrote: > > On 14/12/2024 03:10, Luis Chamberlain wrote: > > index 167d82b46781..b57dc4bff81b 100644 > > --- a/block/bdev.c > > +++ b/block/bdev.c > > @@ -157,8 +157,7 @@ int set_blocksize(struct file *file, int size) > > struct inode *inode =3D file->f_mapping->host; > > struct block_device *bdev =3D I_BDEV(inode); > > > > - /* Size must be a power of two, and between 512 and PAGE_SIZE */ > > - if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size)) > > + if (blk_validate_block_size(size)) > > return -EINVAL; > > I suppose that this can be sent as a separate patch to be merged now. There have been some bugs found in case that PAGE_SIZE =3D=3D 64K, and I think it is bad to use PAGE_SIZE for validating many hw/queue limits, we mi= ght have to fix them first. Such as: 1) blk_validate_limits() - failure if max_segment_size is less than 64K - max_user_sectors if (lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE) return -EINVAL; 2) bio_may_need_split() - max_segment_size may be less than 64K Thanks,