From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5CDBC3DA4A for ; Thu, 15 Aug 2024 01:42:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65F476B007B; Wed, 14 Aug 2024 21:42:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60FBF6B0082; Wed, 14 Aug 2024 21:42:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D6C26B0083; Wed, 14 Aug 2024 21:42:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 310A06B007B for ; Wed, 14 Aug 2024 21:42:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A704F1A1275 for ; Thu, 15 Aug 2024 01:42:43 +0000 (UTC) X-FDA: 82452780606.08.7E638C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 85A5140016 for ; Thu, 15 Aug 2024 01:42:41 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UecL9i5D; spf=pass (imf17.hostedemail.com: domain of minlei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723686149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SDO7p1/rCt/Ulp3/NJW+f3wt6sswEX3iXmzKx2IC/YQ=; b=hD8OTjOEua3GKdrD3LYPCKr2MDESxdlP+v5n4O4UiAxQYUFUYESb6Ae6CFlz7HqRs8IB4g Lzo+UcDI9fEohRBJbysnwLf5+v36neiPpU5VSObYr0Nmzf4LQooDEQkDeKlMqF0z5wnnfn MGo+FOWlKWg6m6XFVlqDLxyk7Khk5YA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UecL9i5D; spf=pass (imf17.hostedemail.com: domain of minlei@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=minlei@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723686149; a=rsa-sha256; cv=none; b=C6+bZtoxeaDy8uLXKNxfQhZdmuRLk2/BhJARHdbtJiZNR51RSybgdViMVB8a6mqt7Xcz/w FXScSirK0OY7ip1+ZwQjea8QvHalvUSXaEr08YAYlKR6t/Ac6m4KbYrr7fhjsgcXz5lMNy byaufZXlY1Rb5mt1Ilf45ZlTKgpHe5Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723686159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SDO7p1/rCt/Ulp3/NJW+f3wt6sswEX3iXmzKx2IC/YQ=; b=UecL9i5DgLJ1s01aef+sVOxzH2/5byQVcBFlxc/qAvJaLA9tYFgHsvK0Zqx2QvKvPVCBsf M8mOvsF+C8wrdpKHpSmC9iwnF+fDsFi9/nJ+VOHoXHpd09OH8Yi5JchwmmzBdKwnc1++p6 NqFtoCh+cy/LkHsbXVpBtw/5zL9YL2o= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-_rfFFY20P4eXWCFnRaLfZw-1; Wed, 14 Aug 2024 21:42:37 -0400 X-MC-Unique: _rfFFY20P4eXWCFnRaLfZw-1 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-49298970b4aso45861137.0 for ; Wed, 14 Aug 2024 18:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723686157; x=1724290957; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SDO7p1/rCt/Ulp3/NJW+f3wt6sswEX3iXmzKx2IC/YQ=; b=qkLPB0uwiyyS2iMLlA9H2aYnbApvCGw++XHpLpYGRMR/Im/8k66ublbLnQGQbrn3Er V3jBc2Kasj9KQCLpnj5CY5XtJYrZ7bHIt6cBFaLM8SsFoxst/r571flXkxUiauf1NRtT Ebf/dyWpZCxmOsMecy4H72dmJzld2WIcrzxZvN+dM8qGjg9a9um2dhCiuxaJUMR5i4VB TFbHhVS5cGUM0DpGMNaUCLEFbAuTR2H/ZczkfTLHqclIiFlJ8YYUf+BqH4WW4FUAdrRT cxTdrBunFPnH2LC9RGTynWbi4bLpaj1mzbK0LLvyCenmxgVkZj+pUOsdDPfnJBr4MLES 23OA== X-Forwarded-Encrypted: i=1; AJvYcCX7UrwrSbfPi+dRuBf0wdwDwECHV3oM6shdrEkcKMa5Jid/E/Y7hKmVSztdr7u7IeFnRzGK+qUfmg==@kvack.org X-Gm-Message-State: AOJu0YyhV+N5KT+B0erDuJoAcz3bXZBMyRUd7GkK3ZDvPVG5zZ1r1LTb BxHEqFZ5REDoQeCxJY6VRCZDbWv8Sw8iZRThXcI9MWjB1CtCnWR2WoEbLqjyvPEZo1POK+a6fcQ zhygXBm0A/0/2TtSoZ/9E5M/thnJ5w7m11VDgm0dpXBJ5rBmy9zCP90b6FpTvZMGKQLpYPrz3jE TCdb0bhkbMx6jr8hzPSYRlk4U= X-Received: by 2002:a05:6122:1685:b0:4f5:312a:658a with SMTP id 71dfb90a1353d-4fc5aa5ccdamr732814e0c.0.1723686157171; Wed, 14 Aug 2024 18:42:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEGkXgg3KEei4df4ZQe2BBMOv0cgXLjhI//+DZyaCr9SlaZy09JMcILmazo/fy8v4koEzrDcRzwJjOp/HiyDrY= X-Received: by 2002:a05:6122:1685:b0:4f5:312a:658a with SMTP id 71dfb90a1353d-4fc5aa5ccdamr732804e0c.0.1723686156775; Wed, 14 Aug 2024 18:42:36 -0700 (PDT) MIME-Version: 1.0 References: <6ecd7ab3386f63f1656dc766c1b5b038ff5353c2.1723601134.git.asml.silence@gmail.com> In-Reply-To: <6ecd7ab3386f63f1656dc766c1b5b038ff5353c2.1723601134.git.asml.silence@gmail.com> From: Ming Lei Date: Thu, 15 Aug 2024 09:42:24 +0800 Message-ID: Subject: Re: [RFC 5/5] block: implement io_uring discard cmd To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: c1shr514qyxbhfcr8z75imhd1piheuhx X-Rspamd-Queue-Id: 85A5140016 X-Rspamd-Server: rspam11 X-HE-Tag: 1723686161-283286 X-HE-Meta: U2FsdGVkX190xkEEpERElDmpurB0z4++Y57afif1arCPKn10OoR28JvuINUQcWpHFCS+RvOU3+/Uxzf5fZDYiSurRKxnttawdpVrqd/nePtj5tIO4nHuLysagzKN8jIPue98TqmrdW+OKtjL2Aga9SQXB+1SS/jflsdxEyJk7wzRGsUNQhD+EtdK1zZyc8YtqVALrnofbfFG//ymysYlV/UvjdgjQh0Aa9dYwN9DE7oUpViCchFWsfj/LcPUDX3f7YbnKdZxVE7v0y/ShtaknoB++ffHAcRcILxN76Et02cDR6iDtYd/YOdZ5AMCPZs0UCjdwwfkqJbWhtBFkDCfsDRoONG2XmNm1WJaEo/40VLQWmrL81hMcDdQfapgsvGz8O9Jd9teVVn6Dan4DKOvIXkjasHzHygCUVOsOGkJVd/nj9TlFbRmLAHyLfxrKgfi1r+nTL3nje5DRyb3T3fwKD11o33ltfIz1b5hSfMDE8Gc7men8S4yiR2v0jg1LtGkT+ZyiQLiuGgLfCUhAvBR2hav1v1apGWqWGuw9YvPYpvQELqVSVWFkQVqnYh4uNEf6XnQgFLTMONLwmYC/yVmVmQGQjD9i5SDe68WbzU9qB2muaQe3fhn89E/Mav/xnCXa9/lZRepc8DMSrOgHSHL1WHrzBwnEZwx6/eXSCAURbWDXEvFdNVMJtQuS2Vf0tV2qCx4Aq4ISsL9FEAFd8tUBxGajVj3qcwIvb3SCOxalaBUOIpCMl6eqdlzwSpTQU+pgFMyJD/IfWaQL6ycDVkIMXN3bn/ppt2qxM942uXh/KUoMTW27oZg71EHHFROQ5lK6YGHVDoWdCG64ky+xlv7/LUYK7Kd7E1J6TnWbsBHBHmO4VEXnKHYFKDMyNikae9niLZgzeiKZGDvYfScFXdB6wnvylVzDRNkQKS6oeC3sGia45mUm+w0tS62/TOMaVDXv+JDtvFCYNtDMxyytqL 5RofEoHy LGZ+QGxsFeMxWQ7IkpXRGgMmsZHiuAJ7YO0xOAcOYx18VvKu6UFHjCyd/npZBYGEO7Iaus+rtQSnlY/SLIHHJcEiz3+YWr6WBQRMZMw5wVorGq0yWvjib+f/FzzLyasRupeNhHfYZ6BUK47QpQ77az69NVHv4Ww1hi5S0zQIe0Ax54LC2qMKkJW9KQRxC2qz15l49bCGFbSFeqJhOPN4RtBMDuguD/HIiTHeBmqbDKEwbiztWHHG/L80+53QPi+7yzyAMv+3saITMIemJmu9kGtuL7sR87hv6KnVRt66vc+zge/+qV4MAAZvXm65y8YVTQTRmbtdxnCrIXnyphuddbL3OjAI8xZ4ncJoRvZdBhsiueOG+TorjegM83K+onl3iVrxLal3HIq908119k/IBv9lVDPTrSbFvy2+Ygevk8ES/WjUBSCyBb5Wt+fDFlq4xuuq/xyZpnseE3+NFDwxX3a1GIkEjbXOn59hKICPjbMyEQekAnnC5nfMYFKoOASEAaPQ/mmrh0FJnzCEwjNle/5cm3m4jBJU2gSx421HUl3UdQZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000730, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 6:46=E2=80=AFPM Pavel Begunkov wrote: > > Add ->uring_cmd callback for block device files and use it to implement > asynchronous discard. Normally, it first tries to execute the command > from non-blocking context, which we limit to a single bio because > otherwise one of sub-bios may need to wait for other bios, and we don't > want to deal with partial IO. If non-blocking attempt fails, we'll retry > it in a blocking context. > > Suggested-by: Conrad Meyer > Signed-off-by: Pavel Begunkov > --- > block/blk.h | 1 + > block/fops.c | 2 + > block/ioctl.c | 94 +++++++++++++++++++++++++++++++++++++++++ > include/uapi/linux/fs.h | 2 + > 4 files changed, 99 insertions(+) > > diff --git a/block/blk.h b/block/blk.h > index e180863f918b..5178c5ba6852 100644 > --- a/block/blk.h > +++ b/block/blk.h > @@ -571,6 +571,7 @@ blk_mode_t file_to_blk_mode(struct file *file); > int truncate_bdev_range(struct block_device *bdev, blk_mode_t mode, > loff_t lstart, loff_t lend); > long blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg); > +int blkdev_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags)= ; > long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long = arg); > > extern const struct address_space_operations def_blk_aops; > diff --git a/block/fops.c b/block/fops.c > index 9825c1713a49..8154b10b5abf 100644 > --- a/block/fops.c > +++ b/block/fops.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include "blk.h" > > static inline struct inode *bdev_file_inode(struct file *file) > @@ -873,6 +874,7 @@ const struct file_operations def_blk_fops =3D { > .splice_read =3D filemap_splice_read, > .splice_write =3D iter_file_splice_write, > .fallocate =3D blkdev_fallocate, > + .uring_cmd =3D blkdev_uring_cmd, Just be curious, we have IORING_OP_FALLOCATE already for sending discard to block device, why is .uring_cmd added for this purpose? Thanks,