From: Matthew Wilcox <willy6545@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Julia Lawall <julia.lawall@lip6.fr>,
linux-mm@kvack.org, mhocko@kernel.org, cl@linux.com,
Jan Kara <jack@suse.cz>,
matthew@wil.cx, x86@kernel.org, luto@amacapital.net,
martin.petersen@oracle.com, jthumshirn@suse.de,
broonie@kernel.org, Juergen Gross <jgross@suse.com>,
linux-spi@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"lsf-pc@lists.linux-foundation.org"
<lsf-pc@lists.linux-foundation.org>
Subject: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love
Date: Sat, 28 Apr 2018 19:10:47 +0000 [thread overview]
Message-ID: <CAFhKne8u7KcBkpgiQ0fFZyh5_EorfY-_MJJaEYk3feCOd9LsRQ@mail.gmail.com> (raw)
In-Reply-To: <20180428185514.GW27853@wotan.suse.de>
[-- Attachment #1: Type: text/plain, Size: 1991 bytes --]
Another way we could approach this is to get rid of ZONE_DMA. Make GFP_DMA
a flag which doesn't map to a zone. Rather, it redirects to a separate
allocator. At boot, we hand all memory under 16MB to the DMA allocator. The
DMA allocator can have a shrinker which just hands back all the memory once
we're under memory pressure (if it's never had an allocation).
I think we can get rid of the GFP_DMA support in slab/slub. We still need
to be able to allocate pages to support bounce buffers / dma_alloc_foo, but
there's really no reason to allocate sub-pages at this point.
On Sat, Apr 28, 2018, 14:55 Luis R. Rodriguez, <mcgrof@kernel.org> wrote:
> On Sat, Apr 28, 2018 at 01:42:21AM -0700, Christoph Hellwig wrote:
> > On Fri, Apr 27, 2018 at 04:14:56PM +0000, Luis R. Rodriguez wrote:
> > > Do we have a list of users for x86 with a small DMA mask?
> > > Or, given that I'm not aware of a tool to be able to look
> > > for this in an easy way, would it be good to find out which
> > > x86 drivers do have a small mask?
> >
> > Basically you'll have to grep for calls to dma_set_mask/
> > dma_set_coherent_mask/dma_set_mask_and_coherent and their pci_*
> > wrappers with masks smaller 32-bit. Some use numeric values,
> > some use DMA_BIT_MASK and various places uses local variables
> > or struct members to parse them, so finding them will be a bit
> > more work. Nothing a coccinelle expert couldn't solve, though :)
>
> Thing is unless we have a specific flag used consistently I don't believe
> we
> can do this search with Coccinelle. ie, if we have local variables and
> based on
> some series of variables things are set, this makes the grammatical
> expression
> difficult to express. So Cocinelle is not designed for this purpose.
>
> But I believe smatch [0] is intended exactly for this sort of purpose, is
> that
> right Dan? I gave a cursory look and I think it'd take me significant time
> to
> get such hunt down.
>
> [0] https://lwn.net/Articles/691882/
>
> Luis
>
[-- Attachment #2: Type: text/html, Size: 2527 bytes --]
next prev parent reply other threads:[~2018-04-28 19:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 21:54 Luis R. Rodriguez
2018-04-27 1:09 ` [Lsf-pc] " Rik van Riel
2018-04-27 5:35 ` Christoph Hellwig
2018-04-27 7:18 ` Michal Hocko
2018-04-27 16:07 ` Christopher Lameter
2018-04-27 16:18 ` Matthew Wilcox
2018-04-27 16:36 ` Christopher Lameter
2018-04-28 8:33 ` Christoph Hellwig
2018-04-27 16:37 ` Michal Hocko
2018-04-28 8:33 ` Christoph Hellwig
2018-04-28 8:30 ` Christoph Hellwig
2018-04-27 16:14 ` Luis R. Rodriguez
2018-04-27 16:28 ` Matthew Wilcox
2018-04-28 8:42 ` Christoph Hellwig
2018-04-28 18:55 ` Luis R. Rodriguez
2018-04-28 19:10 ` Matthew Wilcox [this message]
2018-05-03 12:03 ` Michal Hocko
2018-05-03 12:13 ` Christoph Hellwig
2018-04-28 19:46 ` Julia Lawall
2018-04-28 20:41 ` Matthew Wilcox
2018-04-29 14:34 ` Julia Lawall
2018-05-03 8:20 ` Geert Uytterhoeven
2018-05-05 16:08 ` Are media drivers abusing of GFP_DMA? - was: " Mauro Carvalho Chehab
2018-05-07 13:26 ` Laurent Pinchart
2018-05-07 15:19 ` Mauro Carvalho Chehab
2018-05-14 8:00 ` Fabien DESSENNE
2018-05-14 10:35 ` Mauro Carvalho Chehab
2018-05-14 10:39 ` Mauro Carvalho Chehab
2018-05-15 7:30 ` Fabien DESSENNE
2018-05-15 8:27 ` Laurent Pinchart
2018-05-15 10:30 ` Mauro Carvalho Chehab
2018-05-15 16:24 ` Luis R. Rodriguez
2018-05-10 4:39 ` Yasunari.Takiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFhKne8u7KcBkpgiQ0fFZyh5_EorfY-_MJJaEYk3feCOd9LsRQ@mail.gmail.com \
--to=willy6545@gmail.com \
--cc=broonie@kernel.org \
--cc=cl@linux.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=jthumshirn@suse.de \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=luto@amacapital.net \
--cc=martin.petersen@oracle.com \
--cc=matthew@wil.cx \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox