From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E56B3C54E58 for ; Thu, 21 Mar 2024 19:57:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E6A26B0083; Thu, 21 Mar 2024 15:57:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 596D26B0087; Thu, 21 Mar 2024 15:57:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45E976B0088; Thu, 21 Mar 2024 15:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3337C6B0083 for ; Thu, 21 Mar 2024 15:57:38 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02403A04A4 for ; Thu, 21 Mar 2024 19:57:37 +0000 (UTC) X-FDA: 81922106196.24.3BB471C Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 1BA62C001C for ; Thu, 21 Mar 2024 19:57:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JrZ35GPT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=justinstitt@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711051056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ck9XtKTBgRiwFDSQngG8cInr2uoxIAAWioBX8TmAnyo=; b=bBBry4lk828wOhJ9WwqJUuClw4Nlnwvj1/sD2DhGtRQa3Om5dId2goN1WxYNGgo1HoyDoi xWWtmCMdqsFc175veIVcKQ+ENKgBTyemVzwsoLTZoLYL96Rw9C1i/k253R3f3p4x47qcYm sRC6M+SkZSjtOaUJXOJTgHr+FQ9QjFw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JrZ35GPT; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=justinstitt@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711051056; a=rsa-sha256; cv=none; b=1iyvgm/LpN9VIqS4XLOeCaLG+EwFLQQYpfI6vpu/tsJc6SHdQSr7S0uPCx/UKQeirL2mHR TpEnIspc2po+1qz/ub9+rBSgvy0CnjXF8Yt+O9Ktknz9wrm2NZ52MHsncgxMmHWUmtWuf2 Z9e6HOX8Eu7kBrmjajQhLU1msuB+RbM= Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-513da1c1f26so1792992e87.3 for ; Thu, 21 Mar 2024 12:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711051054; x=1711655854; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ck9XtKTBgRiwFDSQngG8cInr2uoxIAAWioBX8TmAnyo=; b=JrZ35GPTZknWZJzgfie4k8O7wS4u2j3hNPcJqSKSFX/2Hxg4GkONS6NPrfWtmVe6Pl ZAR9cNBoDUFJLnNAbmQFMv1nrCMyMihrer80l8JC+ZpRCNvBMApS1K9Dg1fU3frRCjCW Wdvpl8sS1Xhzq9La2Um3YSHS91PtBto4kjbkkoe3uYju+LV3kux98v5yWmMtoY/fnesu NRpkFI1iTKm/LQKvzwfK1e2gHC1af6Dc5Hof2ACakG1GVIKCuNGHFBa/rtsAHsz6LTnn dGVoTSQBhhJDHSq2Rm7X0ungU83VrDOJU2pk7HlbQDRfYk9P1U+T+F3WYMSdpIWnkEQ9 YX+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711051054; x=1711655854; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ck9XtKTBgRiwFDSQngG8cInr2uoxIAAWioBX8TmAnyo=; b=GsrxhWuZAvBQ9Z+vo+8eE9ZRr7EpsHpBM/eX/UjJWSVw5zWFC360963kNcZswJioi/ hhKyWHbKoUgAhXgn4o/+GuvA4Zm9/+XfBGY3/YHaOMuc4FbmVSmy9GzOORxK+vss4Rp6 7S4/tj60jzYyrrOIdOfOc0DOE9rJ8c5Ova89j/pAIQ7PNjOCQNGy2pYvAOboMbF60E9q wGcSxJtY6Bta/NlSMXfHtabWQoO7QcAnPVMoESP2eD6s3+P/6EmHpchoE6Maf+8Y79bK BGe9cmzLrIbe9fAgaKYhTkmG7I6BshRFUPonykKyjIFbB6VlWPYYFTkOlYqx3dQpWJGU gnnA== X-Forwarded-Encrypted: i=1; AJvYcCUhzwRgReNRW6SJzygyHs1gBDd/rNo5KcsO3DoRpxyZImM7voYx7liHQvyVpl3e5StGw2l6TeH/d2cDNZmk9QQVIKw= X-Gm-Message-State: AOJu0YyUh/c3fURuBr5vJszM+B08zqe+LUto4fFlrTMVOJH7OpQPNCSJ pK0UpjZSabtZNLBlFVFf/fcAvJ9m7pFjI6wulxncee9PmPP1q2zngUvBfbPyTA1GW8uvAE3E16g q/gG3xaewy1ZjwQbVnrzbXwsEBfPsTnObeajJ X-Google-Smtp-Source: AGHT+IEm3LB16hV2ttktwzI7uFI9wHrobF/GyRBvFlFKy38e078SgRE+nrCXL99kg0aKWSlsYgwHdwgeQSI3HPnhMyQ= X-Received: by 2002:a19:ca13:0:b0:513:da24:fc0b with SMTP id a19-20020a19ca13000000b00513da24fc0bmr247849lfg.33.1711051053968; Thu, 21 Mar 2024 12:57:33 -0700 (PDT) MIME-Version: 1.0 References: <20240321-strncpy-fs-binfmt_elf_fdpic-c-v1-1-fdde26c8989e@google.com> <871q83eepl.fsf@email.froward.int.ebiederm.org> In-Reply-To: <871q83eepl.fsf@email.froward.int.ebiederm.org> From: Justin Stitt Date: Thu, 21 Mar 2024 12:57:21 -0700 Message-ID: Subject: Re: [PATCH] binfmt: replace deprecated strncpy with strscpy_pad To: "Eric W. Biederman" Cc: Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1BA62C001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pnpyj3sqjof6en8quuj3bykme4wipx4m X-HE-Tag: 1711051055-692312 X-HE-Meta: U2FsdGVkX19ox5A5FmLKxwfhyuv9/Jf68XVEUUykgqerPpLrfhBPhmBdqSCQocXxPRBWSLKM7XfmwUVIQm0SXqtriv7L4lUarML6SDTRMdnzY6EL8sKOY+bbvhOlR8Bemz/qbOQU2iwkhq897vBP8pU9PcwOrzYUJ4q0SYbtSPuaK+7WwDHbU9U1YRC7X+aawIbPttM3PIZIRe172eYD2pZzkTK6obdn1RKa+PRPWs4WkI5Cq6Vr6EIGzMV0xP5Fy8iOBGNRmT9nuCQlrgt2d6zNAxh/1If/K0nWydkQ0aUTKh3TfY8p8IIsceDEQfGTX0v/ILa5l1s5+LqjDtGoi+yh3jwHUD9z2mWpuFCCNt5pt/XacQo4SfSn36T76XZ0SlCmpnM2QmTLYo4jzczfX3DLK+x+Oal4rpphNEVEWvDws1LJr22G6oJ5zgtckmg26su525e9cJFnb6zg3KEgboi+NBrueSW1QxN5TOjK2xFRg3RiE/cp+VfiQx5YPyH/hNC/saCpnyseTjtfVE2V1/3dym3nn6fMWqOMWICGN7Wf+XZcZRQySaHrIPPfvjeGWxPFE1iKwHI8n07DX3qW1MWmMu+CxE39M1rBQ6pmLtiDc+FiWYvbV5EVgKYp5khcredqOTKpV4nU4OUoEmANQtbqSE5N85YaIySMSG3Yf1xCXPfTA3d2IGBAX9kNIGeas5U64nTHYn/d517Hn8Z4NeIGrtf0Nv67EiE9u/1qhmmYGIMPHRpL8WmCw0izPjIdEfgv9AoseKCYKTrU3FMfOWTZh+xAj5iBU/uWDFk7BMTwsqii+oza7tpyotuT9xkuPmM1e9PnabVZvtkxDEo+NMuT35Vh+OqvPdjkmrkDXi5TSB7CjNylhoSG/iq74l9N3F5Ozx8w3p5c4sh3kZhc/zOloPwNVQSRVLPMww2w1iftz482mfIZBFw59yPTo60yVlbcBTu1IF5mkH2dZKP 7CxxHOv9 /HTNfa5t/ZyB3q4HEnV4BBdazHfRLAKD5HymWeblDsgvsEFNoxxQ8KOYRG69pXgPzRtq2nhFoYTY329dLBgQBlRjO1iBzNJwwqSgQGsA8hXADguYLJA2YL3KOsh91cyoJjpLJQi/Y/rFkSynOlbLHKmSbh5f2WzOGuDV7bdZN4XKV7p7dq8e43MU8S1lziQFykYfRDecURvAfAlzHnoqe/hL5wgtyC4nyFPjupszJEGhxMKx9b9cZ4608RkJ3ugoEOae0utTax6aEnTsKG2Ss9uuApwDfh0a4zyElpx0qt55IUEKOdW8weaxTC19zFjbXIxoLy4+2q8B30m8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Thu, Mar 21, 2024 at 9:23=E2=80=AFAM Eric W. Biederman wrote: > > I am perplexed. Why not use get_task_comm fill_psinfo like binfmt_elf > does? > > It seems very silly to copy half the function without locking and then > not copy it's locking as well. > > Given that the more highly tested binfmt_elf uses get_task_comm I can't > imagine a reason why binfmt_elf_fdpic can't use it as well. I am not sure why the original opted for strncpy over get_task_comm but I made the replacement without being aware of the literally identical code present in binfmt_elf.c I'll send a v2. > > Eric Thanks Justin