From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F1A9C52D7B for ; Tue, 13 Aug 2024 22:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FB8D6B0088; Tue, 13 Aug 2024 18:31:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AB546B008A; Tue, 13 Aug 2024 18:31:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84C116B0092; Tue, 13 Aug 2024 18:31:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 606AF6B0088 for ; Tue, 13 Aug 2024 18:31:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10DA6A797C for ; Tue, 13 Aug 2024 22:31:41 +0000 (UTC) X-FDA: 82448670402.20.C41FD39 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) by imf20.hostedemail.com (Postfix) with ESMTP id 570FA1C000B for ; Tue, 13 Aug 2024 22:31:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tmiatuAL; spf=pass (imf20.hostedemail.com: domain of justinstitt@google.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723588204; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PjDal07NYOKBjkEkz7/rPrI2L3lDW5tzH1NRX7vsX+E=; b=2Mam4IQO7saE4GnPDlQmaIth/69cT7OsAXVXF3F3yegme4xYmXX4O11a+EwWQ4dNco4E31 PBBi1a1yjKTYZEGYph9EKafuSLaqp1Ypl8295o6trt16aQ+b00zqAmqORH2E8p9UyZH95u 2vekxJRG4L/oSJZbIghnD8mUtl1++kQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tmiatuAL; spf=pass (imf20.hostedemail.com: domain of justinstitt@google.com designates 209.85.222.52 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723588204; a=rsa-sha256; cv=none; b=cNJ841GHoNSxcBla8BdR58bIYU8VYs/K31E0WcRbGZ699R3sVCFs1yRX+csz3d+oRMOfYM jVfGS+Z7mXgKiMwjoAE/fHB2PouHTR4OSrS6JgeuWMsVLwTETyM9OOBaaUhN6BJfP8DpkN E+KXNW6MWnTx0wlPnd9Zk4m+U/pCdYk= Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-82d192d9234so1320541241.1 for ; Tue, 13 Aug 2024 15:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723588298; x=1724193098; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PjDal07NYOKBjkEkz7/rPrI2L3lDW5tzH1NRX7vsX+E=; b=tmiatuALM0fWXoSStxmXM17TSkv85Msz1Lj3g83PYJFlA4W3+IzzAMqV3ngVfCGo7d shCRmLGOutjWHSpf47Nk7OVISx2Q0uGV3FTgHl89j4Am4jgppoZelVqI/77StPtv5K+U ig4yzZuxn+02qR7UbGS/rMKxpxvB/Tnola+bQaEQYJoAytnE+LeiYnxeSnEkYc6J0Uct AMevIVonNKz+ywz+uxp4LgWs/JBq6KJTxOFtf8V5l/8t3kSvgCvumFf876x3bUUypqm/ EHvm3zOrDLVUUkJ25L5Hmq9LivIeR0Xy2u7KQoAXwza+oe/x00AZwsWVZbZVjLDv8geM mzCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723588298; x=1724193098; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PjDal07NYOKBjkEkz7/rPrI2L3lDW5tzH1NRX7vsX+E=; b=iREkPVqGNZzyz5LUEgAjuNh3ereWGLGUH+y8dN7AFKYTmgiWMCzAbfUAyogEH6Drfh FjRlwUl/j13Mt2XSPCzp35DiVahys7hKp+RxU7INeDIkwXE3uOtqQuOzaZFdNwdqVbMH dsSh8kOqGsOeOQCoKpQOl0ApkRmaXsj1kbgkcTuFqDXHb3YfIwmV+FN7JM4KPrkFd07W Xy4oSNCJOw1XZJ05wmIRu9LMrAyRQmYIHZsfCOIluJ7CCrY3y4Ix1j9WwwwrgdVdiOrU VDjxRKPoQnEae3BR7+FlsXINhwxRw/rkXxGSe4P7DyfDsJ5QVoWevH2w0277nJg6OzIc uibQ== X-Forwarded-Encrypted: i=1; AJvYcCXPElYJPulqUHmjfz0GiGnaAth9eAjtgdklSBpBKP/quFkHwXRb2PlR+DBtnffGTtU8ihC2aPe0NjzJubbFtjyf4Tg= X-Gm-Message-State: AOJu0Yw1htiCR1t8VCk8HJ6RgOv8C3sg6pbsBYdVkh19qlYbeKVuFr5T hrChVaYad9BC/I2yp/u4QFswm3kuigrkFmjhGqlVHPrbfJdrrnnRHj47t6AMWk4WuBG8X6RWD1D 55izUybO737mZHP+wSMexQHk6UZXag/4/U0ld X-Google-Smtp-Source: AGHT+IH/QraxU2fjWjOPkx0WDZKuaY29L3Zen/pzf+3bC1KTX13QSkaN1GEjq4vqJeNmusG+MLJVL3jxUBZoAMXwy+8= X-Received: by 2002:a05:6102:c04:b0:493:b4b5:4850 with SMTP id ada2fe7eead31-497599e9a02mr915097137.31.1723588298200; Tue, 13 Aug 2024 15:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20240812022933.69850-1-laoar.shao@gmail.com> <20240812022933.69850-8-laoar.shao@gmail.com> In-Reply-To: From: Justin Stitt Date: Tue, 13 Aug 2024 15:31:26 -0700 Message-ID: Subject: Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy() To: Yafang Shao Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Masami Hiramatsu , Mathieu Desnoyers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 570FA1C000B X-Stat-Signature: j7ehgiawbapi5k3stiqn8zdw1uh4uuc6 X-Rspam-User: X-HE-Tag: 1723588299-36021 X-HE-Meta: U2FsdGVkX19c0st9NZxhypMGySo3NrqXdzSYeHzC7WxXxUyTPL+yPSHuYdWzrwJN/VMKEAC79ByurQbpBfLTjWhYmDjjTgy2sBh2pTTJujK1xTQXWoiVDB17wYDZaHLijNZGZR8cHLDhCpMgxaZ+8KT/T1yMVn3wYQ/KJfCzZH77SiNhPdW1cnLmPlnptfZMXP0WuTNEMfQm/NrBDLMTZtnaS3GlMsdS4SPyFZizBAwloPc/TVCvRvV0MpKIi6qm2t5d1JHdX0xF+XdHJqle04cGUvh0apFga6edGnFUrjWdWBU8nFDFdkiXuumJKer6p9qA0S2h6+gPl3ji8SmdTK3nzpzHsMkcjrcTFtxJuseN26/oUYgK6i1JJp1E+6xqCv51Gj0LFbDGF74ozJ9Kp4uwMrbyAmq+gA3t8T3NBA59BQA6z0G8/jJqYG186uInTo9FLVUnNVh2Wdrlt7C1RTDRWWx9XynYpRV2ygf73FbXlxw8x4ttDVlK6nLASvqLzUYt3geUDwE2lIK27y5nv5m3qX5osT4T/2gGrCwnXqO+Xq2gdtnUeQKIGziSIwtYDHhp40RliAj7za5y/ED90E+8vgCSxcymp4dGxxkO8Sc8LNTgm30ld7mY2bMXOKe2ScceeMdJi3KeM6Hcf4+8Ol9RQTDNES7zlaYgh4QJz7f0MISHCYeUm5Rh69g6FbHykx9nh9GyoxNRcuM/qLpp/glNLoLFwFGzXDu6IfLB2ww2asyHXsqKgp9CGHQzrscDbCbNzgYD3wPAXNM7Pn8BmiK1qq73RZ4Zh3BFSnHWTzhTLJ77Y42pooTohBRNZRttXMFPt1sS1fIrkeGQJ6P1aaMkYi4htk/29Vmv/zYAS4yliTtPjMwe4HPMzkiPFVvS0B43oMJ7gJ8Q/4QYElH3rQ6RdJiW48oVe8/SfgN1VAsnX6W7eurTou7pJsxyXaTWMNyY0rGblcYboE3ZEOf 6nsnwXxr gInd/N4vmHbStTzria3yVcKuZHh8k39hj0oRAO165fQnq4Hm1OpzfE9yVEvrewJEYHHOCLECcEa/P4aYcMM478DsXMocUlAc2J0TFJZeQM+3w0uDyRyHqEu07MZLyQITpaSwniD62QR1mvBatTl69RP16/Y7GrO+G5OR8q1mzh6oVichBgq2COJ4n8DaT8K4pOw9Wi26rXulZk9AxZSpm4qMehf3lGxO70yCelRbyimjcCFSz6bXYtou2Gu3Ekyo2rBQUy5k/UxvUZ89dFWnfhpLFvG+5/ztUG3Q0ezHe0nkJDfenPR0oxh2nm3gGshHiQq9eeJ1g9+mZYPs5Q13xEFgjVluzxrtVn1/5DynyUAEQCd77rhbXfWjnB7oaGrpcjnYsCIHSTe3uqWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.097472, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 13, 2024 at 3:19=E2=80=AFPM Justin Stitt wrote: > > Hi, > > On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote: > > Using strscpy() to read the task comm ensures that the name is > > always NUL-terminated, regardless of the source string. This approach a= lso > > facilitates future extensions to the task comm. > > Thanks for sending patches replacing str{n}cpy's! > > I believe there's at least two more instances of strncpy in trace.c as > well as in trace_events_hist.c (for a grand total of 6 instances in the > files you've touched in this specific patch). > > It'd be great if you could replace those instances in this patch as well = :>) > > This would help greatly with [1]. > I just saw that Jinjie Ruan sent replacements for these strncpy's too and tracked down and replaced an instance of strscpy() that was present in trace.c but was moved to trace_sched_switch.c during a refactor. They even used the new 2-argument strscpy which is pretty neat. See their patch here: https://lore.kernel.org/all/20240731075058.617588-1-ruanjinjie@huawei.com/ > Link: https://github.com/KSPP/linux/issues/90 [1] > Link: https://lore.kernel.org/all/CAHk-=3DwhWtUC-AjmGJveAETKOMeMFSTwKwu99= v7+b6AyHMmaDFA@mail.gmail.com/ [2] > > Thanks > Justin