From: Justin Stitt <justinstitt@google.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
ebiederm@xmission.com, alexei.starovoitov@gmail.com,
rostedt@goodmis.org, catalin.marinas@arm.com,
penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v6 7/9] tracing: Replace strncpy() with strscpy()
Date: Tue, 13 Aug 2024 15:31:26 -0700 [thread overview]
Message-ID: <CAFhGd8oBmBVooQha7EB+_wenO8TfOjqJsZAzgHLuDUSYmwxy=w@mail.gmail.com> (raw)
In-Reply-To: <hbjxkyhugi27mbrj5zo2thfdg2gotz6syz6qoeows6l6qwbzkt@c3yb26z4pn62>
On Tue, Aug 13, 2024 at 3:19 PM Justin Stitt <justinstitt@google.com> wrote:
>
> Hi,
>
> On Mon, Aug 12, 2024 at 10:29:31AM GMT, Yafang Shao wrote:
> > Using strscpy() to read the task comm ensures that the name is
> > always NUL-terminated, regardless of the source string. This approach also
> > facilitates future extensions to the task comm.
>
> Thanks for sending patches replacing str{n}cpy's!
>
> I believe there's at least two more instances of strncpy in trace.c as
> well as in trace_events_hist.c (for a grand total of 6 instances in the
> files you've touched in this specific patch).
>
> It'd be great if you could replace those instances in this patch as well :>)
>
> This would help greatly with [1].
>
I just saw that Jinjie Ruan sent replacements for these strncpy's too
and tracked down and replaced an instance of strscpy() that was
present in trace.c but was moved to trace_sched_switch.c during a
refactor.
They even used the new 2-argument strscpy which is pretty neat.
See their patch here:
https://lore.kernel.org/all/20240731075058.617588-1-ruanjinjie@huawei.com/
> Link: https://github.com/KSPP/linux/issues/90 [1]
> Link: https://lore.kernel.org/all/CAHk-=whWtUC-AjmGJveAETKOMeMFSTwKwu99v7+b6AyHMmaDFA@mail.gmail.com/ [2]
>
> Thanks
> Justin
next prev parent reply other threads:[~2024-08-13 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 2:29 [PATCH v6 0/9] Improve the copy of task comm Yafang Shao
2024-08-12 2:29 ` [PATCH v6 1/9] Get rid of __get_task_comm() Yafang Shao
2024-08-12 8:05 ` Alejandro Colomar
2024-08-12 13:20 ` Yafang Shao
2024-08-12 2:29 ` [PATCH v6 2/9] auditsc: Replace memcpy() with strscpy() Yafang Shao
2024-08-12 2:29 ` [PATCH v6 3/9] security: Replace memcpy() with get_task_comm() Yafang Shao
2024-08-12 2:29 ` [PATCH v6 4/9] bpftool: Ensure task comm is always NUL-terminated Yafang Shao
2024-08-12 2:29 ` [PATCH v6 5/9] mm/util: Fix possible race condition in kstrdup() Yafang Shao
2024-08-12 2:29 ` [PATCH v6 6/9] mm/util: Deduplicate code in {kstrdup,kstrndup,kmemdup_nul} Yafang Shao
2024-08-12 2:29 ` [PATCH v6 7/9] tracing: Replace strncpy() with strscpy() Yafang Shao
2024-08-13 22:19 ` Justin Stitt
2024-08-13 22:31 ` Justin Stitt [this message]
2024-08-14 2:34 ` Yafang Shao
2024-08-12 2:29 ` [PATCH v6 8/9] net: Replace strcpy() " Yafang Shao
2024-08-12 2:29 ` [PATCH v6 9/9] drm: " Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFhGd8oBmBVooQha7EB+_wenO8TfOjqJsZAzgHLuDUSYmwxy=w@mail.gmail.com' \
--to=justinstitt@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=audit@vger.kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rostedt@goodmis.org \
--cc=selinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox