From: Mostafa Saleh <smostafa@google.com>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-mm@kvack.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
corbet@lwn.net, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, akpm@linux-foundation.org, vbabka@suse.cz,
surenb@google.com, mhocko@suse.com, jackmanb@google.com,
hannes@cmpxchg.org, ziy@nvidia.com, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, rppt@kernel.org, xiaqinxin@huawei.com,
baolu.lu@linux.intel.com, rdunlap@infradead.org,
Samiullah Khawaja <skhawaja@google.com>
Subject: Re: [PATCH v6 3/4] iommu: debug-pagealloc: Track IOMMU pages
Date: Wed, 14 Jan 2026 17:41:55 +0000 [thread overview]
Message-ID: <CAFgf54pBAUm3ao-UJksiuGKtvv4wzRyFq_uKwLe0H1ettO4DLQ@mail.gmail.com> (raw)
In-Reply-To: <f239e391-ac7c-4d26-ab82-4024a77ec3d3@kernel.org>
On Wed, Jan 14, 2026 at 5:30 PM David Hildenbrand (Red Hat)
<david@kernel.org> wrote:
>
> On 1/13/26 16:08, Jason Gunthorpe wrote:
> > On Tue, Jan 13, 2026 at 10:49:28AM +0000, Mostafa Saleh wrote:
> >> Would you have a problem if we added a new function in page_ext
> >> "page_ext_from_phys()" as Jason suggested?
> >
> > Given the hidden complexity that David just pointed out I think this
> > is essential to encapsulate it in a function.
> >
> > The function must be able to accept any phys_addr_t and safely returns
> > NULL if page_ext cannot be used for some reason.
>
> Right. I think pfn_to_online_page() is the appropriate check.
>
> @Mostafa, I saw you already sent a v7, is the pfn_to_online_page() stuff
> handled in there?
>
Yes, it's in the first patch in function page_ext_get_phys(). After
spending some time looking into it, that was my conclusion also.
Thanks,
Mostafa
> --
> Cheers
>
> David
next prev parent reply other threads:[~2026-01-14 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 17:18 [PATCH v6 0/4] iommu: Add page_ext for IOMMU_DEBUG_PAGEALLOC Mostafa Saleh
2026-01-09 17:18 ` [PATCH v6 1/4] " Mostafa Saleh
2026-01-09 17:18 ` [PATCH v6 2/4] iommu: Add calls " Mostafa Saleh
2026-01-09 17:18 ` [PATCH v6 3/4] iommu: debug-pagealloc: Track IOMMU pages Mostafa Saleh
2026-01-09 19:15 ` Pranjal Shrivastava
2026-01-09 19:51 ` Jason Gunthorpe
2026-01-12 10:20 ` Mostafa Saleh
2026-01-12 13:32 ` Jason Gunthorpe
2026-01-12 13:43 ` Mostafa Saleh
2026-01-12 13:52 ` Jason Gunthorpe
2026-01-12 14:58 ` Mostafa Saleh
2026-01-12 18:27 ` Jason Gunthorpe
2026-01-12 19:11 ` David Hildenbrand (Red Hat)
2026-01-12 19:17 ` Jason Gunthorpe
2026-01-13 10:22 ` Mostafa Saleh
2026-01-13 10:30 ` David Hildenbrand (Red Hat)
2026-01-13 10:49 ` Mostafa Saleh
2026-01-13 15:08 ` Jason Gunthorpe
2026-01-14 17:30 ` David Hildenbrand (Red Hat)
2026-01-14 17:41 ` Mostafa Saleh [this message]
2026-01-09 17:18 ` [PATCH v6 4/4] iommu: debug-pagealloc: Check mapped/unmapped kernel memory Mostafa Saleh
2026-01-09 19:16 ` Pranjal Shrivastava
2026-01-10 9:53 ` [PATCH v6 0/4] iommu: Add page_ext for IOMMU_DEBUG_PAGEALLOC Jörg Rödel
2026-01-13 11:10 ` Mostafa Saleh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFgf54pBAUm3ao-UJksiuGKtvv4wzRyFq_uKwLe0H1ettO4DLQ@mail.gmail.com \
--to=smostafa@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolu.lu@linux.intel.com \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=iommu@lists.linux.dev \
--cc=jackmanb@google.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=skhawaja@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=xiaqinxin@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox