From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A56C33C9E for ; Wed, 8 Jan 2020 09:11:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10AB62072A for ; Wed, 8 Jan 2020 09:11:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XPYFISJs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10AB62072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5F6FA8E0006; Wed, 8 Jan 2020 04:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A7DF8E0001; Wed, 8 Jan 2020 04:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BEB58E0006; Wed, 8 Jan 2020 04:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 368538E0001 for ; Wed, 8 Jan 2020 04:11:41 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id E91A2181AEF09 for ; Wed, 8 Jan 2020 09:11:40 +0000 (UTC) X-FDA: 76353899160.05.cord51_65ee747444508 X-HE-Tag: cord51_65ee747444508 X-Filterd-Recvd-Size: 3596 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jan 2020 09:11:40 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id b15so2073541iln.3 for ; Wed, 08 Jan 2020 01:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HiScsc8fYkbMip54VqKL4tItZafxLw4MyIS0lizry60=; b=XPYFISJsNDUzYgwHeEMoJFqlPEIiLTOBdTkvNyofwoadgg/GUV/dDo1HHFG3rUUVkp wndVlaq1ZtGafLRqRBJNLLYxiLp1cpf57VYhuAjAGfOeITYvXdi1JnEatb+XfPt71e3k Do7g4faVMKhvLJdXsMbKxdXORFt6EQj12G23q5dtKKDj6F8yzJHo/CjgUCwNQrK5/Srq F7+W6ZQEwHSsw9y4Zlf84uWURfaQaomQgZ8FmNbXvO4hwzJF034AfGoopr4KHctaSIyn Ri4VpBWP8C+4X9AboNil+3eAUcRs/lIkLXn0/7U7igKwh/C4sFETUNdz5hxa0kzo7W1z 8QAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HiScsc8fYkbMip54VqKL4tItZafxLw4MyIS0lizry60=; b=V59wAzzs5fayy87cdUofdzyjlYIWdXTI7Qy3Sd9j/Dj//kCV6S6MCXJx5WcAQjB8qF iydd2g4CuD+1c4QyaqOwSNuVrA8sNUdix6OY0K93opgEtF7Xcg6e+unYjAzB7JoMFStY TfIJM4BmINB1ZKkHG5yze5IwMXhdjLgNxbhIDIHir16zm+E6P5ANtM4FYbD+RorwqgDs M7FJPkD39aY2wKxodKp5tco8Fe5HvJAzxYCoY3WJjN/O9OfFH9w5Im4jQBRvhOiH6mxk y9NAbwZvnesjPaeNm8TVpI6ymRdgD4LLGBx5ZU0CGY6YEbO48n9MQXyD7ZuqVtElztNa xGig== X-Gm-Message-State: APjAAAVCKnjVIqHBEJlMTHePndoji/h8M2PLtQiEX+va/EJihttliYk6 OlkX0Gl9UF753lwVwElYyXTwW0ePqH3v/PyhBw== X-Google-Smtp-Source: APXvYqycqsG0eMrRQQGBh8EYG3fuXU0BazufSoKErRf07lrU8ZdhdySYieu7jsFtB3vh/beU3vTCT06uZwGlWu61IUU= X-Received: by 2002:a92:d98e:: with SMTP id r14mr2738722iln.15.1578474699660; Wed, 08 Jan 2020 01:11:39 -0800 (PST) MIME-Version: 1.0 References: <20191217104637.5509-1-david@redhat.com> In-Reply-To: From: Pingfan Liu Date: Wed, 8 Jan 2020 17:11:28 +0800 Message-ID: Subject: Re: [PATCH v1] mm/memory_hotplug: Don't free usage map when removing a re-added early section To: David Hildenbrand Cc: LKML , Andrew Morton , linux-mm@kvack.org, Dan Williams , Oscar Salvador , Michal Hocko , Pingfan Liu Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 8, 2020 at 4:24 PM David Hildenbrand wrote: > > > We have another reproducer that is used more frequently than memtrace :) > > Using Dynamic Memory under a Power DLAPR can trigger it easily. > Triggering removal (I assume after previously removed+re-added) of > memory from the HMC GUI can crash the kernel with the same call trace > and is fixed by this patch. > > CCing Pingfan who verified that this patch fixes the issue - maybe he > wants to provide a Tested-by: Yes, this patch fixes the hot remove+add+remove bug on POWERVM, which can be reproduced by dlpar. Tested-by: Pingfan Liu > > @Andrew, any chance we can get this upstream soon-ish? Thanks! > > -- > Thanks, > > David / dhildenb >